Add HTMLDraftmanTest — direct visitor tests #10

New Issue

2026-03-27T15:01:25Z

thib8956 commented

2026-03-27 15:01:25 +00:00

Priority: P1 — Medium

Context: Same rationale as #9 — direct visitor tests isolate failures better than the full HTMLExporter pipeline tests. Additionally, a bug was previously found and fixed in HTMLDraftman.visitTriangle() where this.hashCode() was used instead of sTriangle.hashCode() (commit edd5167). A direct visitor test would have caught this immediately. A regression test should be included.

Scope: src/main/java/ovh/gasser/newshapes/ui/visitors/HTMLDraftman.java

Goal: Test each visit*() method in isolation.

Edge cases to cover:

Text font styles (ITALIC, BOLD, ITALIC+BOLD)
Nested collections
Null ColorAttributes
Filled only / stroked only / both / neither
Regression test for visitTriangle() hashCode fix

Estimate: 2 hours
Dependencies: None

**Priority:** P1 — Medium **Context:** Same rationale as #9 — direct visitor tests isolate failures better than the full HTMLExporter pipeline tests. Additionally, a bug was previously found and fixed in `HTMLDraftman.visitTriangle()` where `this.hashCode()` was used instead of `sTriangle.hashCode()` (commit `edd5167`). A direct visitor test would have caught this immediately. A regression test should be included. **Scope:** `src/main/java/ovh/gasser/newshapes/ui/visitors/HTMLDraftman.java` **Goal:** Test each `visit*()` method in isolation. **Edge cases to cover:** - Text font styles (ITALIC, BOLD, ITALIC+BOLD) - Nested collections - Null ColorAttributes - Filled only / stroked only / both / neither - Regression test for `visitTriangle()` hashCode fix **Estimate:** 2 hours **Dependencies:** None

thib8956 referenced this issue from a commit

2026-03-27 15:29:39 +00:00

test: add HTMLDraftman direct visitor tests

thib8956 referenced a pull request that will close this issue

2026-03-27 15:29:46 +00:00

test: add HTMLDraftman direct visitor tests #19

thib8956 referenced this issue from a commit

2026-03-27 17:02:20 +00:00

test: add HTMLDraftman direct visitor tests

thib8956 closed this issue

2026-03-27 17:05:38 +00:00

Sign in to join this conversation.