thib8956/new-shapes
1
0
Fork 0
Code Issues 7 Pull Requests Actions Wiki Activity

test: add SVGDraftman direct visitor tests #18

Merged
thib8956 merged 1 commits from issue-9/svg-draftman-tests into master 2026-03-27 17:19:14 +00:00
Conversation 0 Commits 1 Files Changed 1 +370
thib8956 commented 2026-03-27 15:27:34 +00:00
Owner
Copy Link

Summary

  • Add 27 unit tests for SVGDraftman, testing each visit*() method in isolation with @Nested test classes.
  • Covers rectangle, circle, triangle, text, and collection visitors with attribute combinations (filled/stroked/both/neither), null color fallback, empty and nested collections, and generateSVG wrapper output.
  • All 63 tests pass (27 new + 36 existing).

Closes #9

## Summary - Add 27 unit tests for `SVGDraftman`, testing each `visit*()` method in isolation with `@Nested` test classes. - Covers rectangle, circle, triangle, text, and collection visitors with attribute combinations (filled/stroked/both/neither), null color fallback, empty and nested collections, and `generateSVG` wrapper output. - All 63 tests pass (27 new + 36 existing). Closes #9
thib8956 added 1 commit 2026-03-27 17:05:49 +00:00
test: add SVGDraftman direct visitor tests
All checks were successful
CI / build-and-test (pull_request) Successful in 18s
Details
3623928bb6 
Add 27 tests covering each visit*() method in isolation:
- visitRectangle: dimensions, filled/stroked/both/neither color combos
- visitCircle: center calculation, fill/stroke variants
- visitTriangle: polygon points, fill style, stroke style
- visitText: content, position offset, font attributes, color fallbacks
- visitCollection: empty, multiple children, nested collections
- generateSVG: XML declaration, SVG namespace, closing tag, shape content

Closes #9
thib8956 force-pushed issue-9/svg-draftman-tests from a5ea4ee79a to 3623928bb6 2026-03-27 17:05:49 +00:00 Compare
thib8956 merged commit 2ccea4b107 into master 2026-03-27 17:19:14 +00:00
thib8956 deleted branch issue-9/svg-draftman-tests 2026-03-27 17:19:14 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
thib8956
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: thib8956/new-shapes#18
Delete Branch "issue-9/svg-draftman-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?