bug: SText.updateMeasuredBounds() mutates a defensive copy instead of internal state #27

New Issue

thib8956 · 2026-03-27T16:19:49Z

thib8956 commented

2026-03-27 16:19:49 +00:00

In SText.updateMeasuredBounds(), the call getBounds().setSize(...) mutates a copy of the bounds rectangle (since getBounds() returns a defensive copy) and discards the result. This means resized dimensions are silently lost.

Impact: Cloning an SText that has been resized will produce a clone with default dimensions instead of the resized ones.

Found during: Review of PR #15 (ShapeContractTest). The contract test passes only because the factory creates SText with default bounds.

Expected fix: updateMeasuredBounds() should mutate the internal bounds field directly rather than calling getBounds().

In `SText.updateMeasuredBounds()`, the call `getBounds().setSize(...)` mutates a **copy** of the bounds rectangle (since `getBounds()` returns a defensive copy) and discards the result. This means resized dimensions are silently lost. **Impact:** Cloning an `SText` that has been resized will produce a clone with default dimensions instead of the resized ones. **Found during:** Review of PR #15 (ShapeContractTest). The contract test passes only because the factory creates `SText` with default bounds. **Expected fix:** `updateMeasuredBounds()` should mutate the internal `bounds` field directly rather than calling `getBounds()`.

thib8956 referenced this issue from a commit

2026-03-27 22:58:14 +00:00

fix: SText.updateMeasuredBounds() must mutate internal bounds, not defensive copy

thib8956 referenced a pull request that will close this issue

2026-03-27 22:58:56 +00:00

fix: SText.updateMeasuredBounds() mutates defensive copy instead of internal state #32

thib8956 referenced this issue from a commit

2026-03-27 23:22:10 +00:00

fix: SText.updateMeasuredBounds() must mutate internal bounds, not defensive copy

thib8956 closed this issue

2026-03-27 23:22:21 +00:00

Sign in to join this conversation.