thib8956/nginx-proxy
1
0
Fork 0
mirror of https://github.com/thib8956/nginx-proxy synced 2025-10-31 09:09:20 +00:00
Code Issues Releases Wiki Activity

tests(pytest.sh): Update Syntax

Browse Source 
- Added clarification comment of the DIR command
- Quoted `ARGS` usage required wrapping `ARGS` assignment in an array to properly expand. This wasn't broken before, but is required change to keep ShellCheck  lint happy.
- Quote wrapped `DIR` usage, the volume target had an extra `/` before the `DIR` which seems unnecessary as `pwd` should return absolute path.
- Expanded `docker run` options to long-form.
This commit is contained in:
polarathene
2021-09-25 20:07:08 +12:00
parent e81001615c
commit 0cd573f043
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
test/pytest.sh
View File

@@ -8,17 +8,18 @@
# # # #
############################################################################### ###############################################################################
# Returns the absolute directory path to this script
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
ARGS="$@" ARGS=("$@")
# check requirements # check requirements
echo "> Building nginx-proxy-tester image..." echo "> Building nginx-proxy-tester image..."
docker build -t nginx-proxy-tester -f $DIR/requirements/Dockerfile-nginx-proxy-tester $DIR/requirements docker build -t nginx-proxy-tester -f "${DIR}/requirements/Dockerfile-nginx-proxy-tester" "${DIR}/requirements"
# run the nginx-proxy-tester container setting the correct value for the working dir in order for # run the nginx-proxy-tester container setting the correct value for the working dir in order for
# docker-compose to work properly when run from within that container. # docker-compose to work properly when run from within that container.
exec docker run --rm -it \ exec docker run --rm -it \
-v ${DIR}:/${DIR} \ --volume /var/run/docker.sock:/var/run/docker.sock \
-w ${DIR} \ --volume "${DIR}:${DIR}" \
-v /var/run/docker.sock:/var/run/docker.sock \ --workdir "${DIR}" \
nginx-proxy-tester ${ARGS} nginx-proxy-tester "${ARGS[@]}"