Add SelectionAttributes unit tests

Test core data type for selected/unselected state, default values,
ID constant, interface compliance, and instance independence.

8 tests covering all public API of SelectionAttributes.

Closes #6

TODO.md

@@ -1,6 +1,6 @@
 # TODO
 
-- [X] Box selection (drag to select multiple shapes)
+- [ ] Box selection (drag to select multiple shapes)
 - [ ] Undo/redo stack
 - [ ] Copy/paste functionality
 - [ ] Group/Ungroup shapes

src/main/java/ovh/gasser/newshapes/shapes/AbstractShape.java

@@ -77,14 +77,6 @@ public abstract class AbstractShape implements Shape {
         return new Rectangle(this.bounds);
     }
 
-    public void setBounds(Rectangle newBounds) {
-        this.bounds.setBounds(newBounds);
-        onBoundsChanged();
-    }
-
-    protected void onBoundsChanged() {
-    }
-
     @Override
     public String toString() {
         return String.format("x=%d, y=%d, width=%d, height=%d", bounds.x, bounds.y, bounds.width, bounds.height);

src/main/java/ovh/gasser/newshapes/shapes/SCircle.java

@@ -53,14 +53,6 @@ public class SCircle extends AbstractShape {
         return radius;
     }
 
-    @Override
-    protected void onBoundsChanged() {
-        int diameter = Math.max(bounds.width, bounds.height);
-        bounds.width = diameter;
-        bounds.height = diameter;
-        this.radius = diameter / 2;
-    }
-
     public static SCircle create(int x, int y, int radius) {
         return create(x, y, radius, Color.BLACK);
     }

src/main/java/ovh/gasser/newshapes/shapes/SCollection.java

@@ -9,6 +9,7 @@ import ovh.gasser.newshapes.attributes.ColorAttributes;
 import ovh.gasser.newshapes.attributes.SelectionAttributes;
 import ovh.gasser.newshapes.util.Streamable;
 
+import javax.swing.text.html.Option;
 import java.awt.*;
 import java.util.*;
 import java.util.List;
@@ -18,7 +19,6 @@ public class SCollection extends AbstractShape implements Streamable<Shape> {
     private final List<Shape> children;
 
     private SCollection(Shape... shapes) {
-        super(new Rectangle());
         this.children = new ArrayList<>(List.of(shapes));
     }
 
@@ -57,29 +57,6 @@ public class SCollection extends AbstractShape implements Streamable<Shape> {
         children.forEach(s -> s.translate(dx, dy));
     }
 
-    @Override
-    public void resize(ResizeHandle handle, int dx, int dy) {
-        if (children.isEmpty()) {
-            return;
-        }
-
-        Rectangle currentBounds = getBounds();
-        Rectangle resizedBounds = resizeBounds(currentBounds, handle, dx, dy);
-        double scaleX = resizedBounds.width / (double) currentBounds.width;
-        double scaleY = resizedBounds.height / (double) currentBounds.height;
-
-        for (Shape child : children) {
-            Rectangle childBounds = child.getBounds();
-            Rectangle targetChildBounds = new Rectangle(
-                    resizedBounds.x + (int) Math.round((childBounds.x - currentBounds.x) * scaleX),
-                    resizedBounds.y + (int) Math.round((childBounds.y - currentBounds.y) * scaleY),
-                    Math.max(1, (int) Math.round(childBounds.width * scaleX)),
-                    Math.max(1, (int) Math.round(childBounds.height * scaleY))
-            );
-            resizeChild(child, targetChildBounds);
-        }
-    }
-
     @Override
     public Iterator<Shape> iterator() {
         return children.iterator();
@@ -94,45 +71,12 @@ public class SCollection extends AbstractShape implements Streamable<Shape> {
         children.add(s);
     }
 
-    public void clear() {
-        children.clear();
-    }
-
-    public void replaceWith(SCollection other) {
-        if (other == this) {
-            return;
-        }
-
-        clear();
-        other.stream().forEach(children::add);
-    }
-
-    public void add(int index, Shape s) {
-        children.add(index, s);
-    }
-
-    public void insert(int index, Shape s) {
-        children.add(Math.max(0, Math.min(index, children.size())), s);
-    }
-
     public void remove(Shape s) {
         if (!children.remove(s)) {
             logger.error("Unable to delete shape: {}", s);
         }
     }
 
-    public int indexOf(Shape s) {
-        return children.indexOf(s);
-    }
-
-    public int size() {
-        return children.size();
-    }
-
-    public boolean contains(Shape s) {
-        return children.contains(s);
-    }
-
     @Override
     public Attributes getAttributes(String key) {
         if (key.equals(ColorAttributes.ID)) {
@@ -166,69 +110,4 @@ public class SCollection extends AbstractShape implements Streamable<Shape> {
         collection.addAttributes(new SelectionAttributes());
         return collection;
     }
-
-    private static Rectangle resizeBounds(Rectangle bounds, ResizeHandle handle, int dx, int dy) {
-        Rectangle resizedBounds = new Rectangle(bounds);
-
-        switch (handle) {
-            case E -> resizedBounds.width += dx;
-            case W -> {
-                resizedBounds.x += dx;
-                resizedBounds.width -= dx;
-            }
-            case S -> resizedBounds.height += dy;
-            case N -> {
-                resizedBounds.y += dy;
-                resizedBounds.height -= dy;
-            }
-            case SE -> {
-                resizedBounds.width += dx;
-                resizedBounds.height += dy;
-            }
-            case SW -> {
-                resizedBounds.x += dx;
-                resizedBounds.width -= dx;
-                resizedBounds.height += dy;
-            }
-            case NE -> {
-                resizedBounds.width += dx;
-                resizedBounds.y += dy;
-                resizedBounds.height -= dy;
-            }
-            case NW -> {
-                resizedBounds.x += dx;
-                resizedBounds.width -= dx;
-                resizedBounds.y += dy;
-                resizedBounds.height -= dy;
-            }
-        }
-
-        if (resizedBounds.width < 1) {
-            resizedBounds.width = 1;
-        }
-        if (resizedBounds.height < 1) {
-            resizedBounds.height = 1;
-        }
-
-        return resizedBounds;
-    }
-
-    private static void resizeChild(Shape child, Rectangle targetChildBounds) {
-        if (child instanceof SCollection collection) {
-            Rectangle currentBounds = collection.getBounds();
-            collection.translate(targetChildBounds.x - currentBounds.x, targetChildBounds.y - currentBounds.y);
-
-            Rectangle translatedBounds = collection.getBounds();
-            collection.resize(
-                    ResizeHandle.SE,
-                    targetChildBounds.width - translatedBounds.width,
-                    targetChildBounds.height - translatedBounds.height
-            );
-            return;
-        }
-
-        if (child instanceof AbstractShape abstractShape) {
-            abstractShape.setBounds(targetChildBounds);
-        }
-    }
 }

src/test/java/ovh/gasser/newshapes/attributes/ColorAttributesTest.java

@@ -1,129 +0,0 @@
-package ovh.gasser.newshapes.attributes;
-
-import org.junit.jupiter.api.Test;
-
-import java.awt.*;
-
-import static org.junit.jupiter.api.Assertions.*;
-
-class ColorAttributesTest {
-
-    @Test
-    void testConstructorStoresFilledFlag() {
-        ColorAttributes attrs = new ColorAttributes(true, false, Color.RED, Color.BLACK);
-        assertTrue(attrs.filled, "filled flag should be true when constructed with true");
-    }
-
-    @Test
-    void testConstructorStoresStrokedFlag() {
-        ColorAttributes attrs = new ColorAttributes(false, true, Color.RED, Color.BLACK);
-        assertTrue(attrs.stroked, "stroked flag should be true when constructed with true");
-    }
-
-    @Test
-    void testConstructorStoresFilledColor() {
-        ColorAttributes attrs = new ColorAttributes(true, false, Color.BLUE, Color.BLACK);
-        assertEquals(Color.BLUE, attrs.filledColor, "filledColor should match the constructor argument");
-    }
-
-    @Test
-    void testConstructorStoresStrokedColor() {
-        ColorAttributes attrs = new ColorAttributes(false, true, Color.RED, Color.GREEN);
-        assertEquals(Color.GREEN, attrs.strokedColor, "strokedColor should match the constructor argument");
-    }
-
-    @Test
-    void testFilledAndStrokedBothTrue() {
-        ColorAttributes attrs = new ColorAttributes(true, true, Color.RED, Color.BLUE);
-        assertTrue(attrs.filled);
-        assertTrue(attrs.stroked);
-    }
-
-    @Test
-    void testFilledAndStrokedBothFalse() {
-        ColorAttributes attrs = new ColorAttributes(false, false, Color.RED, Color.BLUE);
-        assertFalse(attrs.filled);
-        assertFalse(attrs.stroked);
-    }
-
-    @Test
-    void testNullFilledColor() {
-        ColorAttributes attrs = new ColorAttributes(true, false, null, Color.BLACK);
-        assertNull(attrs.filledColor, "filledColor should accept null");
-    }
-
-    @Test
-    void testNullStrokedColor() {
-        ColorAttributes attrs = new ColorAttributes(false, true, Color.RED, null);
-        assertNull(attrs.strokedColor, "strokedColor should accept null");
-    }
-
-    @Test
-    void testBothColorsNull() {
-        ColorAttributes attrs = new ColorAttributes(false, false, null, null);
-        assertNull(attrs.filledColor);
-        assertNull(attrs.strokedColor);
-    }
-
-    @Test
-    void testGetIDReturnsCorrectValue() {
-        ColorAttributes attrs = new ColorAttributes(false, false, Color.RED, Color.BLACK);
-        assertEquals(ColorAttributes.ID, attrs.getID());
-    }
-
-    @Test
-    void testIDConstant() {
-        assertEquals("COLOR_ATTRS", ColorAttributes.ID);
-    }
-
-    @Test
-    void testImplementsAttributes() {
-        ColorAttributes attrs = new ColorAttributes(false, false, Color.RED, Color.BLACK);
-        assertInstanceOf(Attributes.class, attrs);
-    }
-
-    @Test
-    void testToStringContainsAllFields() {
-        ColorAttributes attrs = new ColorAttributes(true, false, Color.RED, Color.BLUE);
-        String str = attrs.toString();
-        assertTrue(str.contains("filled=true"), "toString should contain filled value");
-        assertTrue(str.contains("stroked=false"), "toString should contain stroked value");
-        assertTrue(str.contains("filledColor"), "toString should contain filledColor");
-        assertTrue(str.contains("strokedColor"), "toString should contain strokedColor");
-    }
-
-    @Test
-    void testToStringWithNullColors() {
-        ColorAttributes attrs = new ColorAttributes(false, false, null, null);
-        String str = attrs.toString();
-        assertNotNull(str, "toString should not throw with null colors");
-        assertTrue(str.contains("filledColor=null"), "toString should show null filledColor");
-        assertTrue(str.contains("strokedColor=null"), "toString should show null strokedColor");
-    }
-
-    @Test
-    void testTwoInstancesAreIndependent() {
-        ColorAttributes attrs1 = new ColorAttributes(true, false, Color.RED, Color.BLACK);
-        ColorAttributes attrs2 = new ColorAttributes(false, true, Color.BLUE, Color.GREEN);
-
-        assertTrue(attrs1.filled);
-        assertFalse(attrs2.filled);
-        assertFalse(attrs1.stroked);
-        assertTrue(attrs2.stroked);
-        assertEquals(Color.RED, attrs1.filledColor);
-        assertEquals(Color.BLUE, attrs2.filledColor);
-    }
-
-    @Test
-    void testFieldsAreImmutable() {
-        Color fillColor = Color.RED;
-        Color strokeColor = Color.BLACK;
-        ColorAttributes attrs = new ColorAttributes(true, true, fillColor, strokeColor);
-
-        // Since fields are final, verify they retain their values
-        assertEquals(Color.RED, attrs.filledColor);
-        assertEquals(Color.BLACK, attrs.strokedColor);
-        assertTrue(attrs.filled);
-        assertTrue(attrs.stroked);
-    }
-}

src/test/java/ovh/gasser/newshapes/shapes/ResizeHandleTest.java

@@ -1,94 +0,0 @@
-package ovh.gasser.newshapes.shapes;
-
-import org.junit.jupiter.api.Test;
-import java.awt.Cursor;
-
-import static org.junit.jupiter.api.Assertions.*;
-
-class ResizeHandleTest {
-
-    @Test
-    void testEightHandlesExist() {
-        assertEquals(8, ResizeHandle.values().length,
-                "ResizeHandle enum should define exactly 8 handles");
-    }
-
-    @Test
-    void testAllHandleNamesExist() {
-        assertNotNull(ResizeHandle.valueOf("NW"), "Handle NW should exist");
-        assertNotNull(ResizeHandle.valueOf("N"),  "Handle N should exist");
-        assertNotNull(ResizeHandle.valueOf("NE"), "Handle NE should exist");
-        assertNotNull(ResizeHandle.valueOf("E"),  "Handle E should exist");
-        assertNotNull(ResizeHandle.valueOf("SE"), "Handle SE should exist");
-        assertNotNull(ResizeHandle.valueOf("S"),  "Handle S should exist");
-        assertNotNull(ResizeHandle.valueOf("SW"), "Handle SW should exist");
-        assertNotNull(ResizeHandle.valueOf("W"),  "Handle W should exist");
-    }
-
-    @Test
-    void testNwMapsToCorrectCursorType() {
-        assertEquals(Cursor.NW_RESIZE_CURSOR, ResizeHandle.NW.getCursorType(),
-                "NW handle should map to Cursor.NW_RESIZE_CURSOR");
-    }
-
-    @Test
-    void testNMapsToCorrectCursorType() {
-        assertEquals(Cursor.N_RESIZE_CURSOR, ResizeHandle.N.getCursorType(),
-                "N handle should map to Cursor.N_RESIZE_CURSOR");
-    }
-
-    @Test
-    void testNeMapsToCorrectCursorType() {
-        assertEquals(Cursor.NE_RESIZE_CURSOR, ResizeHandle.NE.getCursorType(),
-                "NE handle should map to Cursor.NE_RESIZE_CURSOR");
-    }
-
-    @Test
-    void testEMapsToCorrectCursorType() {
-        assertEquals(Cursor.E_RESIZE_CURSOR, ResizeHandle.E.getCursorType(),
-                "E handle should map to Cursor.E_RESIZE_CURSOR");
-    }
-
-    @Test
-    void testSeMapsToCorrectCursorType() {
-        assertEquals(Cursor.SE_RESIZE_CURSOR, ResizeHandle.SE.getCursorType(),
-                "SE handle should map to Cursor.SE_RESIZE_CURSOR");
-    }
-
-    @Test
-    void testSMapsToCorrectCursorType() {
-        assertEquals(Cursor.S_RESIZE_CURSOR, ResizeHandle.S.getCursorType(),
-                "S handle should map to Cursor.S_RESIZE_CURSOR");
-    }
-
-    @Test
-    void testSwMapsToCorrectCursorType() {
-        assertEquals(Cursor.SW_RESIZE_CURSOR, ResizeHandle.SW.getCursorType(),
-                "SW handle should map to Cursor.SW_RESIZE_CURSOR");
-    }
-
-    @Test
-    void testWMapsToCorrectCursorType() {
-        assertEquals(Cursor.W_RESIZE_CURSOR, ResizeHandle.W.getCursorType(),
-                "W handle should map to Cursor.W_RESIZE_CURSOR");
-    }
-
-    @Test
-    void testValueOfReturnsCorrectConstant() {
-        assertSame(ResizeHandle.NW, ResizeHandle.valueOf("NW"), "valueOf(\"NW\") should return ResizeHandle.NW");
-        assertSame(ResizeHandle.N,  ResizeHandle.valueOf("N"),  "valueOf(\"N\") should return ResizeHandle.N");
-        assertSame(ResizeHandle.NE, ResizeHandle.valueOf("NE"), "valueOf(\"NE\") should return ResizeHandle.NE");
-        assertSame(ResizeHandle.E,  ResizeHandle.valueOf("E"),  "valueOf(\"E\") should return ResizeHandle.E");
-        assertSame(ResizeHandle.SE, ResizeHandle.valueOf("SE"), "valueOf(\"SE\") should return ResizeHandle.SE");
-        assertSame(ResizeHandle.S,  ResizeHandle.valueOf("S"),  "valueOf(\"S\") should return ResizeHandle.S");
-        assertSame(ResizeHandle.SW, ResizeHandle.valueOf("SW"), "valueOf(\"SW\") should return ResizeHandle.SW");
-        assertSame(ResizeHandle.W,  ResizeHandle.valueOf("W"),  "valueOf(\"W\") should return ResizeHandle.W");
-    }
-
-    @Test
-    void testValueOfWithInvalidNameThrowsIllegalArgumentException() {
-        assertThrows(IllegalArgumentException.class,
-                () -> ResizeHandle.valueOf("INVALID"),
-                "valueOf() with an unknown name should throw IllegalArgumentException");
-    }
-}

src/test/java/ovh/gasser/newshapes/shapes/SCollectionTest.java

@@ -114,51 +114,6 @@ class SCollectionTest {
         assertEquals(30, bounds.y);
     }
 
-    @Test
-    void testResizeEmptyCollectionIsNoOp() {
-        SCollection collection = SCollection.of();
-
-        assertDoesNotThrow(() -> collection.resize(ResizeHandle.SE, 25, 25));
-        assertEquals(new Rectangle(App.WIN_SIZE), collection.getBounds());
-    }
-
-    @Test
-    void testResizeSingleChildResizesChildAndCollection() {
-        SRectangle rect = SRectangle.create(10, 20, 100, 50);
-        SCollection collection = SCollection.of(rect);
-
-        collection.resize(ResizeHandle.E, 20, 0);
-
-        assertEquals(new Rectangle(10, 20, 120, 50), rect.getBounds());
-        assertEquals(new Rectangle(10, 20, 120, 50), collection.getBounds());
-    }
-
-    @Test
-    void testResizeMultipleChildrenScalesChildrenProportionally() {
-        SRectangle rect1 = SRectangle.create(0, 0, 10, 10);
-        SRectangle rect2 = SRectangle.create(20, 10, 20, 10);
-        SCollection collection = SCollection.of(rect1, rect2);
-
-        collection.resize(ResizeHandle.SE, 20, 10);
-
-        assertEquals(new Rectangle(0, 0, 15, 15), rect1.getBounds());
-        assertEquals(new Rectangle(30, 15, 30, 15), rect2.getBounds());
-        assertEquals(new Rectangle(0, 0, 60, 30), collection.getBounds());
-    }
-
-    @Test
-    void testResizeFromNorthWestRepositionsAndScalesChildren() {
-        SRectangle rect1 = SRectangle.create(0, 0, 10, 10);
-        SRectangle rect2 = SRectangle.create(10, 10, 10, 10);
-        SCollection collection = SCollection.of(rect1, rect2);
-
-        collection.resize(ResizeHandle.NW, 10, 10);
-
-        assertEquals(new Rectangle(10, 10, 5, 5), rect1.getBounds());
-        assertEquals(new Rectangle(15, 15, 5, 5), rect2.getBounds());
-        assertEquals(new Rectangle(10, 10, 10, 10), collection.getBounds());
-    }
-
     @Test
     void testClone() {
         SRectangle rect = SRectangle.create(10, 20, 100, 50);

src/test/java/ovh/gasser/newshapes/ui/visitors/HTMLDraftmanTest.java

@@ -1,409 +0,0 @@
-package ovh.gasser.newshapes.ui.visitors;
-
-import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Nested;
-import org.junit.jupiter.api.Test;
-import ovh.gasser.newshapes.attributes.ColorAttributes;
-import ovh.gasser.newshapes.shapes.*;
-
-import java.awt.*;
-import java.io.PrintWriter;
-import java.io.StringWriter;
-
-import static org.junit.jupiter.api.Assertions.*;
-
-class HTMLDraftmanTest {
-
-    private StringWriter htmlBuffer;
-    private StringWriter cssBuffer;
-    private PrintWriter htmlWriter;
-    private PrintWriter cssWriter;
-    private HTMLDraftman draftman;
-
-    @BeforeEach
-    void setUp() {
-        htmlBuffer = new StringWriter();
-        cssBuffer = new StringWriter();
-        htmlWriter = new PrintWriter(htmlBuffer);
-        cssWriter = new PrintWriter(cssBuffer);
-        draftman = new HTMLDraftman(htmlWriter, cssWriter);
-    }
-
-    private String html() {
-        htmlWriter.flush();
-        return htmlBuffer.toString();
-    }
-
-    private String css() {
-        cssWriter.flush();
-        return cssBuffer.toString();
-    }
-
-    // ── visitRectangle ──────────────────────────────────────────────
-
-    @Nested
-    class VisitRectangleTests {
-
-        @Test
-        void testRectangleProducesDivWithId() {
-            SRectangle rect = SRectangle.create(10, 20, 100, 50);
-            draftman.visitRectangle(rect);
-
-            assertTrue(html().contains("<div id=\"rec"), "Should produce a div with rec id");
-        }
-
-        @Test
-        void testRectangleCssContainsCorrectPosition() {
-            SRectangle rect = SRectangle.create(10, 20, 100, 50);
-            draftman.visitRectangle(rect);
-
-            String cssOut = css();
-            assertTrue(cssOut.contains("top:20px"), "CSS should contain correct top");
-            assertTrue(cssOut.contains("left:10px"), "CSS should contain correct left");
-        }
-
-        @Test
-        void testRectangleCssContainsCorrectDimensions() {
-            SRectangle rect = SRectangle.create(10, 20, 100, 50);
-            draftman.visitRectangle(rect);
-
-            String cssOut = css();
-            assertTrue(cssOut.contains("width:100px"), "CSS should contain correct width");
-            assertTrue(cssOut.contains("height:50px"), "CSS should contain correct height");
-        }
-
-        @Test
-        void testRectangleCssPositionIsAbsolute() {
-            SRectangle rect = SRectangle.create(0, 0, 30, 30);
-            draftman.visitRectangle(rect);
-
-            assertTrue(css().contains("position:absolute"), "CSS should use absolute positioning");
-        }
-
-        @Test
-        void testRectangleHtmlIdMatchesCssSelector() {
-            SRectangle rect = SRectangle.create(0, 0, 30, 30);
-            draftman.visitRectangle(rect);
-
-            String id = "rec" + rect.hashCode();
-            assertTrue(html().contains("id=\"" + id + "\""), "HTML should contain div with correct id");
-            assertTrue(css().contains("#" + id), "CSS should reference same id");
-        }
-
-        @Test
-        void testRectangleFilledAndStroked() {
-            SRectangle rect = SRectangle.create(0, 0, 30, 30);
-            rect.addAttributes(new ColorAttributes(true, true, Color.RED, Color.BLUE));
-            draftman.visitRectangle(rect);
-
-            String cssOut = css();
-            assertTrue(cssOut.contains("background:"), "CSS should contain background");
-            assertTrue(cssOut.contains("border:"), "CSS should contain border");
-        }
-
-        @Test
-        void testRectangleFilledOnly() {
-            SRectangle rect = SRectangle.create(0, 0, 30, 30);
-            rect.addAttributes(new ColorAttributes(true, false, Color.RED, Color.BLACK));
-            draftman.visitRectangle(rect);
-
-            String cssOut = css();
-            assertTrue(cssOut.contains("background:"), "CSS should contain background for filled");
-            assertFalse(cssOut.contains("border:"), "CSS should not contain border when not stroked");
-        }
-
-        @Test
-        void testRectangleStrokedOnly() {
-            SRectangle rect = SRectangle.create(0, 0, 30, 30);
-            rect.addAttributes(new ColorAttributes(false, true, Color.RED, Color.BLUE));
-            draftman.visitRectangle(rect);
-
-            String cssOut = css();
-            assertTrue(cssOut.contains("border:"), "CSS should contain border for stroked");
-            assertTrue(cssOut.contains("background:#ffffff"), "CSS should have white background when not filled");
-        }
-
-        @Test
-        void testRectangleNeitherFilledNorStroked() {
-            SRectangle rect = SRectangle.create(0, 0, 30, 30);
-            rect.addAttributes(new ColorAttributes(false, false, Color.RED, Color.BLUE));
-            draftman.visitRectangle(rect);
-
-            String cssOut = css();
-            assertFalse(cssOut.contains("background:"), "CSS should not contain background");
-            assertFalse(cssOut.contains("border:"), "CSS should not contain border");
-        }
-    }
-
-    // ── visitCircle ─────────────────────────────────────────────────
-
-    @Nested
-    class VisitCircleTests {
-
-        @Test
-        void testCircleProducesDivWithClass() {
-            SCircle circle = SCircle.create(50, 60, 30);
-            draftman.visitCircle(circle);
-
-            assertTrue(html().contains("circle"), "HTML should contain circle class div");
-        }
-
-        @Test
-        void testCircleCssContainsBorderRadius() {
-            SCircle circle = SCircle.create(50, 60, 30);
-            draftman.visitCircle(circle);
-
-            String cssOut = css();
-            assertTrue(cssOut.contains("border-radius:"), "CSS should contain border-radius");
-            assertTrue(cssOut.contains("-webkit-border-radius:"), "CSS should contain webkit prefix");
-            assertTrue(cssOut.contains("-moz-border-radius:"), "CSS should contain moz prefix");
-        }
-
-        @Test
-        void testCircleCssContainsCorrectPosition() {
-            SCircle circle = SCircle.create(50, 60, 30);
-            draftman.visitCircle(circle);
-
-            String cssOut = css();
-            assertTrue(cssOut.contains("top:60px"), "CSS should contain correct top");
-            assertTrue(cssOut.contains("left:50px"), "CSS should contain correct left");
-        }
-
-        @Test
-        void testCircleHtmlClassMatchesCssSelector() {
-            SCircle circle = SCircle.create(0, 0, 20);
-            draftman.visitCircle(circle);
-
-            String className = "circle" + circle.hashCode();
-            assertTrue(html().contains(className), "HTML should have circle class");
-            assertTrue(css().contains("." + className), "CSS should reference same class");
-        }
-    }
-
-    // ── visitTriangle ───────────────────────────────────────────────
-
-    @Nested
-    class VisitTriangleTests {
-
-        @Test
-        void testTriangleProducesDivWithClass() {
-            STriangle tri = STriangle.create(10, 20, 40, Color.RED, Color.BLACK);
-            draftman.visitTriangle(tri);
-
-            assertTrue(html().contains("triangle"), "HTML should contain triangle class div");
-        }
-
-        @Test
-        void testTriangleCssContainsBorderTrick() {
-            STriangle tri = STriangle.create(10, 20, 40, Color.RED, Color.BLACK);
-            draftman.visitTriangle(tri);
-
-            String cssOut = css();
-            assertTrue(cssOut.contains("border-left-width:"), "CSS should use border-left-width");
-            assertTrue(cssOut.contains("border-right-width:"), "CSS should use border-right-width");
-            assertTrue(cssOut.contains("border-bottom:"), "CSS should use border-bottom");
-            assertTrue(cssOut.contains("width: 0px"), "CSS should set width to 0");
-            assertTrue(cssOut.contains("height: 0px"), "CSS should set height to 0");
-        }
-
-        @Test
-        void testTriangleCssContainsCorrectPosition() {
-            STriangle tri = STriangle.create(10, 20, 40, Color.RED, Color.BLACK);
-            draftman.visitTriangle(tri);
-
-            String cssOut = css();
-            assertTrue(cssOut.contains("top: 20px"), "CSS should contain correct top");
-            assertTrue(cssOut.contains("left: 10px"), "CSS should contain correct left");
-        }
-
-        @Test
-        void testTriangleCssContainsFillColor() {
-            STriangle tri = STriangle.create(0, 0, 20, Color.BLUE, Color.BLACK);
-            tri.addAttributes(new ColorAttributes(true, false, Color.BLUE, Color.BLACK));
-            draftman.visitTriangle(tri);
-
-            assertTrue(css().contains("#0000ff"), "CSS should contain the triangle fill color");
-        }
-
-        @Test
-        void testTriangleHtmlClassMatchesCssSelector_regressionHashCode() {
-            // Regression test: visitTriangle previously used this.hashCode()
-            // instead of sTriangle.hashCode(), causing HTML class and CSS
-            // selector mismatch when rendered by a different draftman instance.
-            STriangle tri = STriangle.create(5, 5, 30, Color.RED, Color.BLACK);
-            draftman.visitTriangle(tri);
-
-            String htmlOut = html();
-            String cssOut = css();
-
-            // Extract the class name from HTML: class="triangleNNN"
-            int classStart = htmlOut.indexOf("triangle");
-            assertNotEquals(-1, classStart, "HTML should contain triangle class");
-            int classEnd = htmlOut.indexOf("\"", classStart);
-            String htmlClassName = htmlOut.substring(classStart, classEnd);
-
-            // CSS should use the same class name
-            assertTrue(cssOut.contains("." + htmlClassName),
-                    "CSS selector should match HTML class — " +
-                    "if this fails, visitTriangle may be using this.hashCode() instead of sTriangle.hashCode()");
-        }
-    }
-
-    // ── visitText ───────────────────────────────────────────────────
-
-    @Nested
-    class VisitTextTests {
-
-        @Test
-        void testTextProducesDivWithContent() {
-            SText text = SText.create(10, 20, "Hello");
-            draftman.visitText(text);
-
-            assertTrue(html().contains(">Hello</div>"), "HTML should contain text content in div");
-        }
-
-        @Test
-        void testTextHtmlIdMatchesCssSelector() {
-            SText text = SText.create(0, 0, "Test");
-            draftman.visitText(text);
-
-            String id = "txt" + text.hashCode();
-            assertTrue(html().contains("id=\"" + id + "\""), "HTML should contain text div with correct id");
-            assertTrue(css().contains("#" + id), "CSS should reference same text id");
-        }
-
-        @Test
-        void testTextCssContainsPosition() {
-            SText text = SText.create(15, 25, "Pos");
-            draftman.visitText(text);
-
-            String cssOut = css();
-            assertTrue(cssOut.contains("top:25px"), "CSS should contain correct top");
-            assertTrue(cssOut.contains("left:15px"), "CSS should contain correct left");
-        }
-
-        @Test
-        void testTextCssContainsDefaultFontAttributes() {
-            SText text = SText.create(0, 0, "Font");
-            draftman.visitText(text);
-
-            String cssOut = css();
-            assertTrue(cssOut.contains("font-family:"), "CSS should contain font-family");
-            assertTrue(cssOut.contains("font-size:16px"), "CSS should contain default font size");
-            assertTrue(cssOut.contains("font-style:normal"), "CSS should contain normal font style");
-            assertTrue(cssOut.contains("font-weight:normal"), "CSS should contain normal font weight");
-        }
-
-        @Test
-        void testTextCssContainsColor() {
-            SText text = SText.create(0, 0, "Colored");
-            text.addAttributes(new ColorAttributes(true, false, Color.RED, Color.BLACK));
-            draftman.visitText(text);
-
-            assertTrue(css().contains("color:#ff0000"), "CSS should contain fill color as text color");
-        }
-
-        @Test
-        void testTextCssWhiteSpaceNowrap() {
-            SText text = SText.create(0, 0, "NoWrap");
-            draftman.visitText(text);
-
-            assertTrue(css().contains("white-space: nowrap"), "CSS should prevent text wrapping");
-        }
-
-        @Test
-        void testTextWithNullColorAttributesFallsBackToBlack() {
-            SText text = SText.create(0, 0, "Fallback");
-            text.addAttributes(new ColorAttributes(false, false, null, null));
-            draftman.visitText(text);
-
-            assertTrue(css().contains("color:#000000"), "Should fall back to black with null colors");
-        }
-    }
-
-    // ── visitCollection ─────────────────────────────────────────────
-
-    @Nested
-    class VisitCollectionTests {
-
-        @Test
-        void testEmptyCollection() {
-            SCollection empty = SCollection.of();
-            draftman.visitCollection(empty);
-
-            assertEquals("", html(), "Empty collection should produce no HTML");
-            assertEquals("", css(), "Empty collection should produce no CSS");
-        }
-
-        @Test
-        void testCollectionVisitsAllChildren() {
-            SCollection coll = SCollection.of(
-                    SRectangle.create(0, 0, 10, 10),
-                    SCircle.create(20, 20, 5)
-            );
-            draftman.visitCollection(coll);
-
-            assertTrue(html().contains("rec"), "Should visit rectangle");
-            assertTrue(html().contains("circle"), "Should visit circle");
-        }
-
-        @Test
-        void testNestedCollectionVisitsAllDescendants() {
-            SCollection inner = SCollection.of(
-                    SRectangle.create(0, 0, 5, 5)
-            );
-            SCollection outer = SCollection.of(
-                    inner,
-                    SCircle.create(10, 10, 3)
-            );
-            draftman.visitCollection(outer);
-
-            assertTrue(html().contains("rec"), "Should visit nested rectangle");
-            assertTrue(html().contains("circle"), "Should visit circle at outer level");
-        }
-    }
-
-    // ── generateHTML ────────────────────────────────────────────────
-
-    @Nested
-    class GenerateHTMLTests {
-
-        @Test
-        void testGenerateHTMLIncludesDoctype() {
-            SCollection model = SCollection.of();
-            draftman.generateHTML(model);
-
-            assertTrue(html().contains("<!DOCTYPE html>"), "Should include DOCTYPE");
-        }
-
-        @Test
-        void testGenerateHTMLIncludesHtmlStructure() {
-            SCollection model = SCollection.of();
-            draftman.generateHTML(model);
-
-            String htmlOut = html();
-            assertTrue(htmlOut.contains("<html"), "Should include html tag");
-            assertTrue(htmlOut.contains("<head>"), "Should include head tag");
-            assertTrue(htmlOut.contains("<body>"), "Should include body tag");
-            assertTrue(htmlOut.contains("</body>"), "Should close body tag");
-        }
-
-        @Test
-        void testGenerateHTMLReferencesStylesheet() {
-            SCollection model = SCollection.of();
-            draftman.generateHTML(model);
-
-            assertTrue(html().contains("style.css"), "Should reference CSS stylesheet");
-        }
-
-        @Test
-        void testGenerateHTMLIncludesShapeContent() {
-            SCollection model = SCollection.of(
-                    SRectangle.create(1, 2, 3, 4)
-            );
-            draftman.generateHTML(model);
-
-            assertTrue(html().contains("<div id=\"rec"), "Should include shape elements");
-        }
-    }
-}

src/test/java/ovh/gasser/newshapes/ui/visitors/SVGDraftmanTest.java

@@ -1,370 +0,0 @@
-package ovh.gasser.newshapes.ui.visitors;
-
-import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Nested;
-import org.junit.jupiter.api.Test;
-import ovh.gasser.newshapes.attributes.ColorAttributes;
-import ovh.gasser.newshapes.shapes.*;
-
-import java.awt.*;
-import java.io.PrintWriter;
-import java.io.StringWriter;
-
-import static org.junit.jupiter.api.Assertions.*;
-
-class SVGDraftmanTest {
-
-    private StringWriter buffer;
-    private PrintWriter writer;
-    private SVGDraftman draftman;
-
-    @BeforeEach
-    void setUp() {
-        buffer = new StringWriter();
-        writer = new PrintWriter(buffer);
-        draftman = new SVGDraftman(writer);
-    }
-
-    private String output() {
-        writer.flush();
-        return buffer.toString();
-    }
-
-    // ── visitRectangle ──────────────────────────────────────────────
-
-    @Nested
-    class VisitRectangleTests {
-
-        @Test
-        void testRectangleElementWithCorrectDimensions() {
-            SRectangle rect = SRectangle.create(10, 20, 100, 50);
-            draftman.visitRectangle(rect);
-
-            String svg = output();
-            assertTrue(svg.contains("<rect"), "Should produce a <rect> element");
-            assertTrue(svg.contains("width=\"100\""), "Should have correct width");
-            assertTrue(svg.contains("height=\"50\""), "Should have correct height");
-            assertTrue(svg.contains("x=\"10\""), "Should have correct x");
-            assertTrue(svg.contains("y=\"20\""), "Should have correct y");
-        }
-
-        @Test
-        void testRectangleFilledOnly() {
-            SRectangle rect = SRectangle.create(0, 0, 30, 30);
-            rect.addAttributes(new ColorAttributes(true, false, Color.RED, Color.BLACK));
-            draftman.visitRectangle(rect);
-
-            String svg = output();
-            assertTrue(svg.contains("fill=\"#ff0000\""), "Should contain fill color");
-            assertFalse(svg.contains("stroke="), "Should not contain stroke when stroked=false");
-        }
-
-        @Test
-        void testRectangleStrokedOnly() {
-            SRectangle rect = SRectangle.create(0, 0, 30, 30);
-            rect.addAttributes(new ColorAttributes(false, true, Color.RED, Color.BLUE));
-            draftman.visitRectangle(rect);
-
-            String svg = output();
-            assertTrue(svg.contains("stroke=\"#0000ff\""), "Should contain stroke color");
-            assertTrue(svg.contains("stroke-width=\"1\""), "Should contain stroke-width");
-            assertTrue(svg.contains("fill=\"none\""), "Should have fill=none when not filled");
-        }
-
-        @Test
-        void testRectangleFilledAndStroked() {
-            SRectangle rect = SRectangle.create(0, 0, 30, 30);
-            rect.addAttributes(new ColorAttributes(true, true, Color.RED, Color.BLUE));
-            draftman.visitRectangle(rect);
-
-            String svg = output();
-            assertTrue(svg.contains("fill=\"#ff0000\""), "Should contain fill color");
-            assertTrue(svg.contains("stroke=\"#0000ff\""), "Should contain stroke color");
-        }
-
-        @Test
-        void testRectangleNeitherFilledNorStroked() {
-            SRectangle rect = SRectangle.create(0, 0, 30, 30);
-            rect.addAttributes(new ColorAttributes(false, false, Color.RED, Color.BLUE));
-            draftman.visitRectangle(rect);
-
-            String svg = output();
-            assertTrue(svg.contains("fill=\"none\""), "Should have fill=none");
-            assertFalse(svg.contains("stroke="), "Should not have stroke attribute");
-        }
-    }
-
-    // ── visitCircle ─────────────────────────────────────────────────
-
-    @Nested
-    class VisitCircleTests {
-
-        @Test
-        void testCircleElementWithCorrectAttributes() {
-            SCircle circle = SCircle.create(50, 60, 30);
-            draftman.visitCircle(circle);
-
-            String svg = output();
-            assertTrue(svg.contains("<circle"), "Should produce a <circle> element");
-            // cx = x + r = 50 + 30 = 80, cy = y + r = 60 + 30 = 90
-            assertTrue(svg.contains("cx=\"80\""), "cx should be x + radius");
-            assertTrue(svg.contains("cy=\"90\""), "cy should be y + radius");
-            assertTrue(svg.contains("r=\"30\""), "Should have correct radius");
-        }
-
-        @Test
-        void testCircleFilledOnly() {
-            SCircle circle = SCircle.create(0, 0, 20);
-            circle.addAttributes(new ColorAttributes(true, false, Color.GREEN, Color.BLACK));
-            draftman.visitCircle(circle);
-
-            String svg = output();
-            assertTrue(svg.contains("fill=\"#00ff00\""), "Should contain fill color");
-            assertFalse(svg.contains("stroke="), "Should not contain stroke");
-        }
-
-        @Test
-        void testCircleStrokedOnly() {
-            SCircle circle = SCircle.create(0, 0, 20);
-            circle.addAttributes(new ColorAttributes(false, true, Color.RED, Color.MAGENTA));
-            draftman.visitCircle(circle);
-
-            String svg = output();
-            assertTrue(svg.contains("stroke=\"#ff00ff\""), "Should contain stroke color");
-            assertTrue(svg.contains("fill=\"none\""), "Should have fill=none");
-        }
-
-        @Test
-        void testCircleFilledAndStroked() {
-            SCircle circle = SCircle.create(0, 0, 15);
-            circle.addAttributes(new ColorAttributes(true, true, Color.YELLOW, Color.BLACK));
-            draftman.visitCircle(circle);
-
-            String svg = output();
-            assertTrue(svg.contains("fill=\"#ffff00\""), "Should contain fill color");
-            assertTrue(svg.contains("stroke=\"#000000\""), "Should contain stroke color");
-        }
-    }
-
-    // ── visitTriangle ───────────────────────────────────────────────
-
-    @Nested
-    class VisitTriangleTests {
-
-        @Test
-        void testTriangleProducesPolygonElement() {
-            STriangle tri = STriangle.create(10, 20, 40, Color.RED, Color.BLACK);
-            draftman.visitTriangle(tri);
-
-            String svg = output();
-            assertTrue(svg.contains("<polygon"), "Should produce a <polygon> element");
-            assertTrue(svg.contains("points="), "Should have points attribute");
-        }
-
-        @Test
-        void testTrianglePointsAreCorrect() {
-            STriangle tri = STriangle.create(10, 20, 40, Color.RED, Color.BLACK);
-            draftman.visitTriangle(tri);
-
-            String svg = output();
-            // bottom-left: (x, y+size) = (10, 60)
-            assertTrue(svg.contains("10,60"), "Should contain bottom-left point");
-            // top-center: (x + size/2, y) = (30, 20)
-            assertTrue(svg.contains("30,20"), "Should contain top-center point");
-            // bottom-right: (x + size, y + size) = (50, 60)
-            assertTrue(svg.contains("50,60"), "Should contain bottom-right point");
-        }
-
-        @Test
-        void testTriangleFilledOnly() {
-            STriangle tri = STriangle.create(0, 0, 20, Color.BLUE, Color.BLACK);
-            tri.addAttributes(new ColorAttributes(true, false, Color.BLUE, Color.BLACK));
-            draftman.visitTriangle(tri);
-
-            String svg = output();
-            assertTrue(svg.contains("fill:#0000ff"), "Should contain fill style");
-            assertFalse(svg.contains("stroke:"), "Should not contain stroke style when not stroked");
-        }
-
-        @Test
-        void testTriangleStrokedAndFilled() {
-            STriangle tri = STriangle.create(0, 0, 20, Color.RED, Color.GREEN);
-            tri.addAttributes(new ColorAttributes(true, true, Color.RED, Color.GREEN));
-            draftman.visitTriangle(tri);
-
-            String svg = output();
-            assertTrue(svg.contains("fill:#ff0000"), "Should contain fill style");
-            assertTrue(svg.contains("stroke:#00ff00"), "Should contain stroke style");
-        }
-
-        @Test
-        void testTriangleNotFilled() {
-            STriangle tri = STriangle.create(0, 0, 20, Color.RED, Color.BLACK);
-            tri.addAttributes(new ColorAttributes(false, true, Color.RED, Color.BLACK));
-            draftman.visitTriangle(tri);
-
-            String svg = output();
-            assertTrue(svg.contains("fill:none"), "Should have fill:none when not filled");
-        }
-    }
-
-    // ── visitText ───────────────────────────────────────────────────
-
-    @Nested
-    class VisitTextTests {
-
-        @Test
-        void testTextElementWithCorrectContent() {
-            SText text = SText.create(10, 20, "Hello");
-            draftman.visitText(text);
-
-            String svg = output();
-            assertTrue(svg.contains("<text"), "Should produce a <text> element");
-            assertTrue(svg.contains(">Hello</text>"), "Should contain the text content");
-        }
-
-        @Test
-        void testTextPositionIncludesFontSizeOffset() {
-            SText text = SText.create(10, 20, "Hi");
-            draftman.visitText(text);
-
-            String svg = output();
-            assertTrue(svg.contains("x=\"10\""), "x should match bounds.x");
-            // y = bounds.y + fontSize = 20 + 16 = 36
-            assertTrue(svg.contains("y=\"36\""), "y should be bounds.y + fontSize");
-        }
-
-        @Test
-        void testTextDefaultFontAttributes() {
-            SText text = SText.create(0, 0, "Test");
-            draftman.visitText(text);
-
-            String svg = output();
-            assertTrue(svg.contains("font-family=\"SansSerif\""), "Should use default font family");
-            assertTrue(svg.contains("font-size=\"16\""), "Should use default font size");
-            assertTrue(svg.contains("font-style=\"normal\""), "Default style should be normal");
-            assertTrue(svg.contains("font-weight=\"normal\""), "Default weight should be normal");
-        }
-
-        @Test
-        void testTextDefaultColorIsBlack() {
-            SText text = SText.create(0, 0, "Test");
-            // default ColorAttributes: filled=true, filledColor=BLACK
-            draftman.visitText(text);
-
-            String svg = output();
-            assertTrue(svg.contains("fill=\"#000000\""), "Default text color should be black");
-        }
-
-        @Test
-        void testTextWithCustomFillColor() {
-            SText text = SText.create(0, 0, "Colored");
-            text.addAttributes(new ColorAttributes(true, false, Color.RED, Color.BLACK));
-            draftman.visitText(text);
-
-            String svg = output();
-            assertTrue(svg.contains("fill=\"#ff0000\""), "Text should use filledColor");
-        }
-
-        @Test
-        void testTextWithNullColorAttributesFallsBackToBlack() {
-            SText text = SText.create(0, 0, "NoColor");
-            text.addAttributes(new ColorAttributes(false, false, null, null));
-            draftman.visitText(text);
-
-            String svg = output();
-            assertTrue(svg.contains("fill=\"#000000\""), "Should fall back to black with null colors");
-        }
-    }
-
-    // ── visitCollection ─────────────────────────────────────────────
-
-    @Nested
-    class VisitCollectionTests {
-
-        @Test
-        void testEmptyCollection() {
-            SCollection empty = SCollection.of();
-            draftman.visitCollection(empty);
-
-            String svg = output();
-            assertEquals("", svg, "Empty collection should produce no output");
-        }
-
-        @Test
-        void testCollectionVisitsAllChildren() {
-            SCollection coll = SCollection.of(
-                    SRectangle.create(0, 0, 10, 10),
-                    SCircle.create(20, 20, 5)
-            );
-            draftman.visitCollection(coll);
-
-            String svg = output();
-            assertTrue(svg.contains("<rect"), "Should visit rectangle");
-            assertTrue(svg.contains("<circle"), "Should visit circle");
-        }
-
-        @Test
-        void testNestedCollectionVisitsAllDescendants() {
-            SCollection inner = SCollection.of(
-                    SRectangle.create(0, 0, 5, 5)
-            );
-            SCollection outer = SCollection.of(
-                    inner,
-                    SCircle.create(10, 10, 3)
-            );
-            draftman.visitCollection(outer);
-
-            String svg = output();
-            assertTrue(svg.contains("<rect"), "Should visit nested rectangle");
-            assertTrue(svg.contains("<circle"), "Should visit circle at outer level");
-        }
-    }
-
-    // ── generateSVG ─────────────────────────────────────────────────
-
-    @Nested
-    class GenerateSVGTests {
-
-        @Test
-        void testGenerateSVGIncludesXmlDeclaration() {
-            SCollection model = SCollection.of();
-            draftman.generateSVG(model);
-
-            String svg = output();
-            assertTrue(svg.contains("<?xml version=\"1.0\" encoding=\"utf-8\"?>"),
-                    "Should include XML declaration");
-        }
-
-        @Test
-        void testGenerateSVGIncludesSvgNamespace() {
-            SCollection model = SCollection.of();
-            draftman.generateSVG(model);
-
-            String svg = output();
-            assertTrue(svg.contains("xmlns=\"http://www.w3.org/2000/svg\""),
-                    "Should include SVG namespace");
-        }
-
-        @Test
-        void testGenerateSVGClosesSvgTag() {
-            SCollection model = SCollection.of();
-            draftman.generateSVG(model);
-
-            String svg = output();
-            assertTrue(svg.contains("</svg>"), "Should close <svg> tag");
-        }
-
-        @Test
-        void testGenerateSVGIncludesShapeContent() {
-            SCollection model = SCollection.of(
-                    SRectangle.create(1, 2, 3, 4)
-            );
-            draftman.generateSVG(model);
-
-            String svg = output();
-            assertTrue(svg.contains("<rect"), "Should include shape elements");
-            assertTrue(svg.contains("</svg>"), "Should close SVG after shapes");
-        }
-    }
-}