thib8956/new-shapes
1
0
Fork 0
Code Issues 7 Pull Requests Actions Wiki Activity

Add edge case tests (null, negative coords, zero dimensions) #13

New Issue
Closed
opened 2026-03-27 15:01:29 +00:00 by thib8956 · 0 comments
thib8956 commented 2026-03-27 15:01:29 +00:00
Owner
Copy Link

Priority: P2 — Lower

Context: A testing audit identified that existing shape tests have no edge case coverage. Specific issues found:

  • No null handling — no tests verify behavior with null arguments
  • No negative coordinates — untested territory
  • No zero dimensions — shapes with width/height 0 untested
  • Reflection usage — SCircleTest uses reflection to check color (fragile, should be replaced)

Scope: All shape classes + SCollection + Selection

Goal: Harden existing tests with:

  • Null arguments handling
  • Negative coordinates
  • Zero-dimension shapes
  • Shapes at Integer.MAX_VALUE boundaries

Estimate: 2 hours
Dependencies: Benefits from #8 (ShapeContractTest) being done first for the parameterized pattern

**Priority:** P2 — Lower **Context:** A testing audit identified that existing shape tests have no edge case coverage. Specific issues found: - **No null handling** — no tests verify behavior with null arguments - **No negative coordinates** — untested territory - **No zero dimensions** — shapes with width/height 0 untested - **Reflection usage** — SCircleTest uses reflection to check color (fragile, should be replaced) **Scope:** All shape classes + SCollection + Selection **Goal:** Harden existing tests with: - Null arguments handling - Negative coordinates - Zero-dimension shapes - Shapes at Integer.MAX_VALUE boundaries **Estimate:** 2 hours **Dependencies:** Benefits from #8 (ShapeContractTest) being done first for the parameterized pattern
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
thib8956
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: thib8956/new-shapes#13
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?