thib8956/new-shapes
1
0
Fork 0
Code Issues 7 Pull Requests 2 Actions 1 Wiki Activity

Create ShapeContractTest (parameterized) #8

New Issue
Closed
opened 2026-03-27 15:01:20 +00:00 by thib8956 · 1 comment
thib8956 commented 2026-03-27 15:01:20 +00:00
Owner
Copy Link

Priority: P0 — High

Context: A testing audit identified these issues in the existing test suite:

  • Shallow coverage — most shape tests only verify creation and bounds
  • No contract tests — Shape interface has no tests verifying invariants across implementations
  • Inconsistent clone testing — some tests verify deep copy, others do not

A parameterized contract test would catch violations across all Shape implementations at once.

Scope: All Shape implementations (SRectangle, SCircle, STriangle, SText, SCollection)

Goal: Verify Shape interface invariants across all implementations using @ParameterizedTest + @MethodSource:

  • clone() returns independent copy
  • getBounds() returns a copy (not internal state)
  • translate() mutates in place

Recommended pattern:

class ShapeContractTest {
    @ParameterizedTest
    @MethodSource("ovh.gasser.newshapes.shapes.ShapeFactory#allShapes")
    void testCloneIsIndependent(Shape s) { ... }

    @ParameterizedTest
    @MethodSource("ovh.gasser.newshapes.shapes.ShapeFactory#allShapes")
    void testGetBoundsReturnsCopy(Shape s) { ... }

    @ParameterizedTest
    @MethodSource("ovh.gasser.newshapes.shapes.ShapeFactory#allShapes")
    void testTranslateMutatesInPlace(Shape s) { ... }
}

Estimate: 2 hours
Dependencies: None

**Priority:** P0 — High **Context:** A testing audit identified these issues in the existing test suite: - **Shallow coverage** — most shape tests only verify creation and bounds - **No contract tests** — Shape interface has no tests verifying invariants across implementations - **Inconsistent clone testing** — some tests verify deep copy, others do not A parameterized contract test would catch violations across all Shape implementations at once. **Scope:** All Shape implementations (SRectangle, SCircle, STriangle, SText, SCollection) **Goal:** Verify Shape interface invariants across all implementations using `@ParameterizedTest` + `@MethodSource`: - `clone()` returns independent copy - `getBounds()` returns a copy (not internal state) - `translate()` mutates in place **Recommended pattern:** ```java class ShapeContractTest { @ParameterizedTest @MethodSource("ovh.gasser.newshapes.shapes.ShapeFactory#allShapes") void testCloneIsIndependent(Shape s) { ... } @ParameterizedTest @MethodSource("ovh.gasser.newshapes.shapes.ShapeFactory#allShapes") void testGetBoundsReturnsCopy(Shape s) { ... } @ParameterizedTest @MethodSource("ovh.gasser.newshapes.shapes.ShapeFactory#allShapes") void testTranslateMutatesInPlace(Shape s) { ... } } ``` **Estimate:** 2 hours **Dependencies:** None
thib8956 commented 2026-03-27 15:15:23 +00:00
Author
Owner
Copy Link

Work in progress on branch issue-8/shape-contract-test. Commit 2ff811e adds parameterized contract tests for clone(), getBounds(), and translate() across all Shape implementations. All 15 new tests pass.

Work in progress on branch `issue-8/shape-contract-test`. Commit 2ff811e adds parameterized contract tests for clone(), getBounds(), and translate() across all Shape implementations. All 15 new tests pass.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
thib8956
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: thib8956/new-shapes#8
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?