thib8956/new-shapes
1
0
Fork 0
Code Issues 7 Pull Requests 7 Actions Wiki Activity

fix: SText.updateMeasuredBounds() mutates defensive copy instead of internal state #32

Merged
thib8956 merged 1 commits from fix/issue-27-stext-update-measured-bounds into master 2026-03-27 23:22:21 +00:00
Conversation 0 Commits 1 Files Changed 2 +37 -1
thib8956 commented 2026-03-27 22:58:55 +00:00
Owner
Copy Link

Closes #27

Problem

SText.updateMeasuredBounds() called getBounds() which returns a defensive copy (new Rectangle(this.bounds)), then called setSize() on that copy. The internal bounds field was never updated.

Fix

Use the protected bounds field directly instead of getBounds().

Tests

Added 4 regression tests to STextTest verifying that updateMeasuredBounds() actually persists to getBounds().

Closes #27 ## Problem SText.updateMeasuredBounds() called getBounds() which returns a defensive copy (new Rectangle(this.bounds)), then called setSize() on that copy. The internal bounds field was never updated. ## Fix Use the protected bounds field directly instead of getBounds(). ## Tests Added 4 regression tests to STextTest verifying that updateMeasuredBounds() actually persists to getBounds().
thib8956 added 1 commit 2026-03-27 23:22:10 +00:00
fix: SText.updateMeasuredBounds() must mutate internal bounds, not defensive copy
All checks were successful
CI / build-and-test (pull_request) Successful in 17s
Details
873f5d2711 
Closes #27
thib8956 force-pushed fix/issue-27-stext-update-measured-bounds from a8b908ca1d to 873f5d2711 2026-03-27 23:22:10 +00:00 Compare
thib8956 merged commit 5415c10c26 into master 2026-03-27 23:22:21 +00:00
thib8956 deleted branch fix/issue-27-stext-update-measured-bounds 2026-03-27 23:22:21 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
thib8956
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: thib8956/new-shapes#32
Delete Branch "fix/issue-27-stext-update-measured-bounds"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?