thib8956/new-shapes
1
0
Fork 0
Code Issues 7 Pull Requests 7 Actions Wiki Activity

Implement #38: Polygon Shapes #45

Open
thib8956 wants to merge 2 commits from feature/issue-38-polygon into master
pull from: feature/issue-38-polygon
merge into: thib8956:master
Conversation 0 Commits 2 Files Changed 12 +1193 -1
thib8956 commented 2026-03-27 23:58:11 +00:00
Owner
Copy Link

Implements polygon shapes (SPolygon) with arbitrary number of points. Updates ShapeVisitor, SVGDraftman, HTMLDraftman to support polygon rendering.

Implements polygon shapes (SPolygon) with arbitrary number of points. Updates ShapeVisitor, SVGDraftman, HTMLDraftman to support polygon rendering.
thib8956 added 1 commit 2026-03-28 00:36:08 +00:00
test: add comprehensive SPolygon unit tests for PR #45
All checks were successful
CI / build-and-test (pull_request) Successful in 17s
Details
a1e24292e4 
Add tests to restore code coverage above 50% threshold:
- SPolygonTest: 14 tests for creation, translate, resize, clone, edge cases
- ShapeFactory: Updated contract tests to include SPolygon
- SVGDraftmanTest: 4 tests for SVG polygon rendering
- HTMLDraftmanTest: 4 tests for HTML/CSS polygon rendering
- ShapeDraftmanTest: 2 tests for Graphics2D polygon drawing

All tests use reflection to work with SPolygon class.
Fixes coverage failure on PR #45 (Issue #38).
thib8956 force-pushed feature/issue-38-polygon from 99cf057c3e to a1e24292e4 2026-03-28 00:36:08 +00:00 Compare
All checks were successful
CI / build-and-test (pull_request) Successful in 17s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/issue-38-polygon:feature/issue-38-polygon
git checkout feature/issue-38-polygon
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
thib8956
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: thib8956/new-shapes#45
Delete Branch "feature/issue-38-polygon"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?