thib8956/nginx-proxy
1
0
Fork 0
mirror of https://github.com/thib8956/nginx-proxy synced 2026-08-15 18:42:48 +00:00
Code Issues Releases Wiki Activity
950 Commits 3 Branches 6 Tags
7b6b2f773d47b10c41085694e836b29e8be4c90b
Commit Graph
38 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Richard Hansen 2494e20784 chore: Remove support for legacy swarm 
It doesn't work with the newer Docker Swarm mode so it doesn't have
much value anymore.
 2023-02-01 03:04:37 -05:00
Richard HansenandTrent Harvey 2115974e93 feat: Add ability to completely override location blocks 
Co-authored-by: Trent Harvey <trent@harvdog.net>
 2023-01-31 04:53:12 -05:00
Richard Hansen 912a065406 chore: Pass --pull to docker build to get fresh images 
This is a no-op if the images are already up to date, and it prevents
puzzling problems when the images are old.
 2023-01-28 18:17:40 -05:00
Richard Hansen 6162427c45 fix: Generate at most one server directive per container 2023-01-28 18:01:19 -05:00
Richard Hansen bcec2d9075 chore: Refactor upstream template for readability 
In particular, reduce the nesting depth to make it easier to
understand what the code is doing by:

  * converting an $O(nm)$ nested loop into two serial $O(n)+O(m)$
    loops, and
  * consolidating similar nested `if` cases.
 2023-01-28 18:01:19 -05:00
Richard Hansen daeed502cb feat: Add a warning comment if the container port is published 2023-01-28 18:01:19 -05:00
Richard Hansen 5a8a6ceae2 chore: Improve debug comments in upstream template 2023-01-28 18:01:19 -05:00
Richard Hansen 2760ead490 chore: Remove warning comment when port is not exposed 
Exposing ports is largely deprecated because it doesn't actually do
anything in Docker.
 2023-01-28 18:01:19 -05:00
Richard Hansen e97bf606c8 chore: Move version comment to the top of the template 
to ensure that the version is always the first output line.

Also, always output `# nginx-proxy`, even if the version isn't known.
This makes it easier to find the start of the generated config in the
output of `nginx -T`.
 2023-01-28 18:01:19 -05:00
Richard HansenandGitHub d6d53893e8 Merge pull request #2152 from vincent-herlemont/documentation-log-format 
Documentation custom log format.
 2023-01-28 03:32:21 -05:00
Richard Hansen 8346b68a28 fix: Ignore VIRTUAL_HOST set to the empty string 
Fixes #2144
 2023-01-23 20:48:16 -05:00
Richard Hansen f8ae0a4b00 feat: DEFAULT_ROOT=none disables the default location / block 2023-01-23 20:47:00 -05:00
Richard HansenandGitHub 98b6473c84 Merge pull request #2141 from rhansen/debug 
feat: Unconditionally produce debug comments
 2023-01-21 19:02:27 -05:00
Richard HansenandNicolas Duchon 8fbc8514ef feat: Unconditionally produce debug comments 
Rationale for eliminating the check to see if the `DEBUG` environment
variable holds a true value:
  * The `DEBUG` environment variable might be set on a container (for
    purposes specific to that container, not `nginx-proxy`) to a value
    that cannot be parsed as a bool, which would break `nginx-proxy`.
  * It simplifies the template.
  * It eliminates a cold code path.
  * It avoids heisenbugs.
  * It makes debugging easier for users.

Also delete the debug info tests, as they are fragile and they provide
limited value.

Alternatively, we could avoid collision with the container's use of
the `DEBUG` environment variable by using a container label [1] such
as `com.google.nginx-proxy.nginx-proxy.debug`.  I think doing so has
dubious value, especially if we want to attempt backwards
compatibility with the `DEBUG` environment variable.

Fixes #2139

[1] https://docs.docker.com/engine/reference/commandline/run/#-set-metadata-on-container--l---label---label-file

Co-authored-by: Nicolas Duchon <nicolas.duchon@gmail.com>
 2023-01-18 17:27:04 -05:00
Richard Hansen 92e1a6567e tests: Remove extraction of nginx.tmpl (now unnecessary) 2023-01-17 18:02:30 -05:00
Richard Hansen 486addd144 tests: Bind-mount the entire nginx-proxy directory in the container 2023-01-17 18:02:30 -05:00
Richard Hansen 569953521a tests: Exit non-zero if creation of nginx-proxy-tester image fails 2023-01-17 18:02:30 -05:00
Richard Hansen 55cfae9636 tests: Avoid unnecessary bashisms 2023-01-17 18:02:30 -05:00
Richard Hansen d56b5b370d tests: Whitespace fixes 2023-01-17 18:02:30 -05:00
Richard Hansen 26b0b05f73 tests: Fix test_debug/* tests when IPv6 is enabled 2023-01-17 18:02:29 -05:00
Richard Hansen 2427b383b5 chore: Move global variables to a $globals dict 
Planned future changes will introduce more embedded templates, and the ability
to pass the globals to the templates will be useful.
 2023-01-17 00:42:20 -05:00
Richard Hansen 1b253cd908 chore: Wrap long comments 2023-01-17 00:42:20 -05:00
Richard Hansen 0da38122bd chore: Consistent indentation 2023-01-17 00:42:20 -05:00
Richard Hansen f20662eeaa chore: Use {{- instead of {{ to clean up whitespace 2023-01-17 00:42:20 -05:00
Richard Hansen d6d8b2205f chore: Fix comment terminators 2023-01-17 00:42:20 -05:00
Richard Hansen 4651bf411d chore: Fix comment for $proxy_connection variable 2023-01-17 00:42:20 -05:00
Richard Hansen 744bd82c54 chore: Combine identical HTTP and HTTPS servers 2023-01-17 00:42:20 -05:00
Richard Hansen 491642b1e9 chore: Factor out duplicate virtual path code 2023-01-17 00:42:20 -05:00
Richard Hansen 14d0f3f222 chore: Rename $container to $containers 
The value is actually a slice/array of containers so it should be
pluralized.
 2023-01-17 00:42:20 -05:00
Richard Hansen 05423c681a fix: Use parseBool to parse boolean strings 2023-01-17 00:42:20 -05:00
Richard Hansen c117ae8fd8 chore: Use boolean for $server_found variable 2023-01-17 00:42:20 -05:00
Richard HansenandGitHub 05eee4b7a3 Merge pull request #2136 from nginx-proxy/dependabot/pip/test/requirements/pytest-7.2.1 
chore(deps): bump pytest from 7.2.0 to 7.2.1 in /test/requirements
 2023-01-16 23:28:47 -05:00
Richard HansenandGitHub cc9edec1c6 Merge pull request #2134 from nginx-proxy/dependabot/pip/test/requirements/requests-2.28.2 
chore(deps): bump requests from 2.28.1 to 2.28.2 in /test/requirements
 2023-01-13 16:35:16 -05:00
Richard HansenandGitHub 3531fa4d37 Merge pull request #2132 from nginx-proxy/dependabot/docker/golang-1.19.5 
chore(deps): bump golang from 1.19.4 to 1.19.5
 2023-01-11 14:10:23 -05:00
Richard Hansen 8aa00fcea2 feat: Option to not trust X-Forwarded-* headers from clients 
If header values from a malicious client are passed to the backend
server unchecked and unchanged, the client may be able to subvert
security checks done by the backend server.
 2022-12-19 02:48:01 -05:00
Richard Hansen 5f15f04556 docs: Document the request headers sent to the backend server 2022-12-19 02:48:01 -05:00
Richard Hansen 9cb21132a4 docs: Sync README.md with default proxy.conf settings 2022-12-19 02:48:01 -05:00
Richard Hansen 55d913255d Fix IPv6 HTTP listen port 2022-03-20 18:54:07 -04:00