3 Commits

Author SHA1 Message Date
b87deecf40 test: add contains(Point) hit-testing tests for all shapes
All checks were successful
CI / build-and-test (pull_request) Successful in 17s
Add 36 tests covering bounds-based hit-testing (getBounds().contains(Point))
for SRectangle, SCircle, STriangle, SText, and SCollection:
- Point inside, outside, on boundary (inclusive top-left, exclusive bottom-right)
- Point after translate to verify position update
- SCollection union bounds, gap between children, single-child bounds

Closes #11
2026-03-27 23:23:57 +00:00
5415c10c26 Merge pull request 'fix: SText.updateMeasuredBounds() mutates defensive copy instead of internal state' (#32) from fix/issue-27-stext-update-measured-bounds into master
All checks were successful
CI / build-and-test (push) Successful in 16s
Reviewed-on: #32
2026-03-27 23:22:20 +00:00
873f5d2711 fix: SText.updateMeasuredBounds() must mutate internal bounds, not defensive copy
All checks were successful
CI / build-and-test (pull_request) Successful in 17s
Closes #27
2026-03-27 23:22:08 +00:00
7 changed files with 551 additions and 775 deletions

Submodule new-shapes.wiki deleted from 731a57b080

View File

@@ -11,8 +11,6 @@ import ovh.gasser.newshapes.ui.listeners.MenuEditListener;
import javax.swing.*;
import java.awt.*;
import java.awt.event.InputEvent;
import java.awt.event.KeyEvent;
import java.io.FileNotFoundException;
public class App {
@@ -21,8 +19,6 @@ public class App {
private SCollection model;
private JCheckBoxMenuItem editFill;
private JCheckBoxMenuItem editBorder;
private JMenuItem editGroup;
private JMenuItem editUngroup;
private App() throws HeadlessException {
final JFrame frame = new JFrame("Reactive shapes");
@@ -75,38 +71,12 @@ public class App {
private JMenu buildFileMenu(ShapesView sview) {
JMenu menuFile = new JMenu("File");
JMenuItem openItem = new JMenuItem("Open");
JMenuItem saveItem = new JMenuItem("Save");
JMenuItem addRectItem = new JMenuItem("Add SRectangle");
JMenuItem addCircleItem = new JMenuItem("Add SCircle");
JMenuItem addTextItem = new JMenuItem("Add Text");
JMenuItem htmlExportItem = new JMenuItem("Export to HTML");
JMenuItem svgExportItem = new JMenuItem("Export to SVG");
JMenuItem exitItem = new JMenuItem("Exit");
openItem.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_O, InputEvent.CTRL_DOWN_MASK));
saveItem.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_S, InputEvent.CTRL_DOWN_MASK));
openItem.addActionListener(evt -> {
JFileChooser chooser = new JFileChooser();
chooser.setFileFilter(new javax.swing.filechooser.FileNameExtensionFilter("JSON Files", "json"));
if (chooser.showOpenDialog(sview) == JFileChooser.APPROVE_OPTION) {
sview.getController().loadDrawing(chooser.getSelectedFile());
}
});
saveItem.addActionListener(evt -> {
JFileChooser chooser = new JFileChooser();
chooser.setFileFilter(new javax.swing.filechooser.FileNameExtensionFilter("JSON Files", "json"));
if (chooser.showSaveDialog(sview) == JFileChooser.APPROVE_OPTION) {
java.io.File file = chooser.getSelectedFile();
if (!file.getName().endsWith(".json")) {
file = new java.io.File(file.getAbsolutePath() + ".json");
}
sview.getController().saveDrawing(file);
}
});
addRectItem.addActionListener(new MenuAddListener("SRectangle", model, sview));
addCircleItem.addActionListener(new MenuAddListener("SCircle", model, sview));
addTextItem.addActionListener(evt -> sview.getController().enterTextMode());
@@ -125,10 +95,6 @@ public class App {
}
});
exitItem.addActionListener(evt -> System.exit(0));
menuFile.add(openItem);
menuFile.add(saveItem);
menuFile.addSeparator();
menuFile.add(addRectItem);
menuFile.add(addCircleItem);
menuFile.add(addTextItem);
@@ -142,62 +108,32 @@ public class App {
private JMenu buildEditMenu(ShapesView sview) {
MenuEditListener editListener = new MenuEditListener(model, sview, sview.getController());
JMenu menuEdit = new JMenu("Edit");
JMenuItem cutItem = new JMenuItem("Cut");
JMenuItem copyItem = new JMenuItem("Copy");
JMenuItem pasteItem = new JMenuItem("Paste");
JMenuItem editColor = new JMenuItem("Change color");
JMenuItem editBorderColor = new JMenuItem("Change border color");
JMenuItem deleteItem = new JMenuItem("Delete");
editGroup = new JMenuItem("Group");
editUngroup = new JMenuItem("Ungroup");
editFill = new JCheckBoxMenuItem("Fill Shape");
editBorder = new JCheckBoxMenuItem("Draw border");
cutItem.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_X, InputEvent.CTRL_DOWN_MASK));
copyItem.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_C, InputEvent.CTRL_DOWN_MASK));
pasteItem.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_V, InputEvent.CTRL_DOWN_MASK));
editGroup.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_G, InputEvent.CTRL_DOWN_MASK));
editUngroup.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_G, InputEvent.CTRL_DOWN_MASK | InputEvent.SHIFT_DOWN_MASK));
cutItem.addActionListener(evt -> sview.getController().cutSelection());
copyItem.addActionListener(evt -> sview.getController().copySelection());
pasteItem.addActionListener(evt -> sview.getController().pasteClipboard());
editColor.addActionListener(editListener);
editBorderColor.addActionListener(editListener);
deleteItem.addActionListener(editListener);
editGroup.addActionListener(evt -> sview.getController().group());
editUngroup.addActionListener(evt -> sview.getController().ungroup());
editFill.addActionListener(editListener);
editBorder.addActionListener(editListener);
editGroup.setEnabled(false);
editUngroup.setEnabled(false);
menuEdit.add(cutItem);
menuEdit.add(copyItem);
menuEdit.add(pasteItem);
menuEdit.addSeparator();
menuEdit.add(editColor);
menuEdit.add(editBorderColor);
menuEdit.add(deleteItem);
menuEdit.addSeparator();
menuEdit.add(editGroup);
menuEdit.add(editUngroup);
menuEdit.addSeparator();
menuEdit.add(editBorder);
menuEdit.add(editFill);
return menuEdit;
}
private void updateMenuState(Iterable<Shape> selectedShapes) {
int selectionCount = 0;
boolean singleCollectionSelected = false;
boolean hasToggleableShapes = false;
boolean allFilled = true;
boolean allStroked = true;
for (Shape s : selectedShapes) {
selectionCount++;
singleCollectionSelected = selectionCount == 1 && s instanceof SCollection;
if (s instanceof SText) {
continue;
}
@@ -209,8 +145,6 @@ public class App {
}
}
editGroup.setEnabled(selectionCount > 1);
editUngroup.setEnabled(selectionCount == 1 && singleCollectionSelected);
updateMenuItem(editFill, hasToggleableShapes, allFilled);
updateMenuItem(editBorder, hasToggleableShapes, allStroked);
}

View File

@@ -57,7 +57,7 @@ public class SText extends AbstractShape {
}
public void updateMeasuredBounds(int width, int height) {
getBounds().setSize(Math.max(width, 0), Math.max(height, 0));
bounds.setSize(Math.max(width, 0), Math.max(height, 0));
}
@Override

View File

@@ -5,15 +5,6 @@ import org.slf4j.LoggerFactory;
import ovh.gasser.newshapes.HTMLExporter;
import ovh.gasser.newshapes.Selection;
import ovh.gasser.newshapes.attributes.ColorAttributes;
import ovh.gasser.newshapes.persistence.DrawingSerializer;
import ovh.gasser.newshapes.command.AddShapeCommand;
import ovh.gasser.newshapes.command.ChangeColorCommand;
import ovh.gasser.newshapes.command.Command;
import ovh.gasser.newshapes.command.CommandHistory;
import ovh.gasser.newshapes.command.CommandHistoryListener;
import ovh.gasser.newshapes.command.MoveShapeCommand;
import ovh.gasser.newshapes.command.RemoveShapeCommand;
import ovh.gasser.newshapes.command.ResizeShapeCommand;
import ovh.gasser.newshapes.shapes.ResizeHandle;
import ovh.gasser.newshapes.shapes.SCollection;
import ovh.gasser.newshapes.shapes.SText;
@@ -22,28 +13,18 @@ import ovh.gasser.newshapes.ui.listeners.SelectionListener;
import javax.swing.*;
import java.awt.*;
import java.awt.event.InputEvent;
import java.awt.event.KeyAdapter;
import java.awt.event.KeyEvent;
import java.awt.event.MouseAdapter;
import java.awt.event.MouseEvent;
import java.io.FileNotFoundException;
import java.util.ArrayList;
import java.util.Collection;
import java.util.LinkedHashMap;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.function.Function;
public class Controller {
private static final Logger logger = LoggerFactory.getLogger(Controller.class);
private final static Logger logger = LoggerFactory.getLogger(Controller.class);
private final ShapesView view;
private final SCollection model;
private final Selection selection;
private final CommandHistory commandHistory;
private Point lastMousePos;
private boolean addingText;
@@ -54,24 +35,11 @@ public class Controller {
private Point selectionBoxStart;
private Point selectionBoxEnd;
private boolean boxSelecting;
private Point dragStartMousePos;
private Map<Shape, Rectangle> dragStartBounds = Map.of();
private final Runnable onModelChanged;
private java.util.List<Shape> clipboard = java.util.List.of();
private int pasteCount = 0;
private static final int PASTE_OFFSET = 20;
private boolean additiveBoxSelection;
Controller(ShapesView view, SCollection model) {
this(view, model, () -> { });
}
Controller(ShapesView view, SCollection model, Runnable onModelChanged) {
this.view = view;
this.model = model;
this.onModelChanged = onModelChanged;
this.selection = new Selection();
this.commandHistory = new CommandHistory();
var adapter = new MouseAdapter() {
@Override
@@ -86,7 +54,14 @@ public class Controller {
@Override
public void mouseReleased(MouseEvent evt) {
handleMouseReleased(evt);
resizing = false;
activeHandle = null;
resizeOrigin = null;
boxSelecting = false;
selectionBoxStart = null;
selectionBoxEnd = null;
view.setCurrentSelectionBox(null);
view.repaint();
}
};
this.view.addMouseMotionListener(adapter);
@@ -99,249 +74,6 @@ public class Controller {
});
}
public void addShape(Shape shape) {
executeAndRefresh(new AddShapeCommand(model, shape));
}
public void addSelectionChangeListener(SelectionListener listener) {
selection.addListener(listener);
}
public void addHistoryChangeListener(CommandHistoryListener listener) {
commandHistory.addListener(listener);
}
public boolean canUndo() {
return commandHistory.canUndo();
}
public boolean canRedo() {
return commandHistory.canRedo();
}
public void undo() {
if (!commandHistory.canUndo()) {
return;
}
resetSelection();
commandHistory.undo();
view.repaint();
}
public void redo() {
if (!commandHistory.canRedo()) {
return;
}
resetSelection();
commandHistory.redo();
view.repaint();
}
public void saveDrawing(java.io.File file) {
try {
new DrawingSerializer().save(model, file);
logger.info("Saved drawing to {}", file.getAbsolutePath());
} catch (java.io.IOException e) {
logger.error("Failed to save drawing: {}", e.getMessage());
JOptionPane.showMessageDialog(view, "Failed to save: " + e.getMessage(), "Save Error", JOptionPane.ERROR_MESSAGE);
}
}
public void loadDrawing(java.io.File file) {
try {
SCollection loaded = new DrawingSerializer().load(file);
model.stream().toList().forEach(model::remove);
loaded.forEach(model::add);
resetSelection();
view.repaint();
logger.info("Loaded drawing from {}", file.getAbsolutePath());
} catch (java.io.IOException e) {
logger.error("Failed to load drawing: {}", e.getMessage());
JOptionPane.showMessageDialog(view, "Failed to load: " + e.getMessage(), "Load Error", JOptionPane.ERROR_MESSAGE);
}
}
public void enterTextMode() {
addingText = true;
}
public void deleteSelected() {
List<Shape> selectedShapes = selection.getSelectedShapes();
if (selectedShapes.isEmpty()) {
return;
}
logger.debug("Deleting selected shape(s)");
executeAndRefresh(new RemoveShapeCommand(model, selectedShapes));
resetSelection();
}
public void copySelection() {
List<Shape> selectedShapes = selection.getSelectedShapes();
if (selectedShapes.isEmpty()) {
logger.debug("No selection to copy");
return;
}
clipboard = selectedShapes.stream()
.map(Shape::clone)
.toList();
pasteCount = 0;
}
public void cutSelection() {
List<Shape> selectedShapes = selection.getSelectedShapes();
if (selectedShapes.isEmpty()) {
logger.debug("No selection to cut");
return;
}
clipboard = selectedShapes.stream()
.map(Shape::clone)
.toList();
pasteCount = 0;
for (Shape shape : selectedShapes) {
model.remove(shape);
}
resetSelection();
onModelChanged.run();
view.repaint();
}
public void pasteClipboard() {
if (clipboard.isEmpty()) {
logger.debug("Clipboard is empty");
return;
}
pasteCount++;
int offset = PASTE_OFFSET * pasteCount;
resetSelection();
for (Shape original : clipboard) {
Shape clone = original.clone();
clone.translate(offset, offset);
model.add(clone);
selection.add(clone);
}
onModelChanged.run();
view.repaint();
}
public void group() {
List<Shape> selectedShapes = selection.getSelectedShapes();
if (selectedShapes.size() < 2) {
logger.debug("Need at least 2 shapes to group");
return;
}
int minIndex = selectedShapes.stream()
.mapToInt(model::indexOf)
.min()
.orElse(0);
for (Shape shape : selectedShapes) {
model.remove(shape);
shape.addAttributes(new ovh.gasser.newshapes.attributes.SelectionAttributes(false));
}
Shape[] shapesArray = selectedShapes.toArray(new Shape[0]);
SCollection group = SCollection.of(shapesArray);
model.insert(minIndex, group);
resetSelection();
selection.add(group);
onModelChanged.run();
view.repaint();
}
public void ungroup() {
List<Shape> selectedShapes = selection.getSelectedShapes();
if (selectedShapes.size() != 1) {
logger.debug("Can only ungroup a single selected group");
return;
}
Shape selected = selectedShapes.get(0);
if (!(selected instanceof SCollection group)) {
logger.debug("Selected shape is not a group");
return;
}
List<Shape> children = new ArrayList<>();
group.forEach(children::add);
model.remove(group);
for (Shape child : children) {
model.add(child);
}
resetSelection();
for (Shape child : children) {
selection.add(child);
}
onModelChanged.run();
view.repaint();
}
public void changeSelectionColor() {
changeColors(shape -> new ColorAttributes(false, true, Color.BLACK, randomColor()));
}
public void changeSelectionFillColor(Color filledColor) {
if (filledColor == null) {
return;
}
changeColors(shape -> {
ColorAttributes current = currentColor(shape);
if (shape instanceof SText) {
return new ColorAttributes(current.filled, current.stroked, filledColor, filledColor);
}
return new ColorAttributes(true, current.stroked, filledColor, current.strokedColor);
});
}
public void changeSelectionBorderColor(Color strokedColor) {
if (strokedColor == null) {
return;
}
changeColors(shape -> {
ColorAttributes current = currentColor(shape);
if (shape instanceof SText) {
return new ColorAttributes(current.filled, current.stroked, strokedColor, strokedColor);
}
return new ColorAttributes(current.filled, true, current.filledColor, strokedColor);
});
}
public void setSelectionBorder(boolean state) {
changeColors(shape -> {
if (shape instanceof SText) {
return null;
}
ColorAttributes current = currentColor(shape);
return new ColorAttributes(current.filled, state, current.filledColor, current.strokedColor);
});
}
public void setSelectionFilled(boolean state) {
changeColors(shape -> {
if (shape instanceof SText) {
return null;
}
ColorAttributes current = currentColor(shape);
return new ColorAttributes(state, current.stroked, current.filledColor, current.strokedColor);
});
}
private void handleMouseDragged(MouseEvent evt) {
if (boxSelecting) {
selectionBoxEnd = evt.getPoint();
@@ -352,19 +84,35 @@ public class Controller {
return;
}
boxSelecting = false;
if (resizeMode && resizing && activeHandle != null) {
logger.debug("RESIZING with handle {} at ({}, {})", activeHandle, evt.getX(), evt.getY());
int dx = evt.getX() - resizeOrigin.x;
int dy = evt.getY() - resizeOrigin.y;
logger.debug("About to resize {} shapes, dx={}, dy={}", selection.getSelectedShapes().size(), dx, dy);
for (Shape shape : selection) {
logger.debug("Calling resize on shape: {}", shape);
shape.resize(activeHandle, dx, dy);
}
resizeOrigin = evt.getPoint();
} else if (!selection.isEmpty()) {
} else if (resizeMode && !selection.isEmpty()) {
lastMousePos = evt.getPoint();
ResizeHandle handle = getHandleAt(evt.getPoint());
if (handle != null) {
resizing = true;
activeHandle = handle;
resizeOrigin = evt.getPoint();
}
} else {
resizing = false;
activeHandle = null;
if (lastMousePos == null) {
lastMousePos = evt.getPoint();
}
int dx = evt.getX() - lastMousePos.x;
int dy = evt.getY() - lastMousePos.y;
logger.debug("MOVING shapes with delta ({}, {})", dx, dy);
for (Shape shape : selection) {
shape.translate(dx, dy);
}
@@ -379,17 +127,18 @@ public class Controller {
return;
}
resizeDragState();
boxSelecting = false;
view.setCurrentSelectionBox(null);
resizing = false;
activeHandle = null;
resizeOrigin = null;
boxSelecting = false; // Clear box selection mode when clicking
if (resizeMode && !selection.isEmpty()) {
ResizeHandle handle = getHandleAt(evt.getPoint());
logger.debug("In resize mode, checking handle at ({}, {}): {}", evt.getX(), evt.getY(), handle);
if (handle != null) {
resizing = true;
activeHandle = handle;
resizeOrigin = evt.getPoint();
beginDrag(evt.getPoint());
view.repaint();
return;
}
@@ -402,86 +151,96 @@ public class Controller {
resetSelection();
}
if (!selection.getSelectedShapes().contains(s)) {
lastMousePos = evt.getPoint();
selection.add(s);
logger.debug("Selecting {}", s);
}
beginDrag(evt.getPoint());
},
() -> {
additiveBoxSelection = evt.isShiftDown();
if (!additiveBoxSelection) {
// Clicked on empty space - start box selection
resetSelection();
}
selectionBoxStart = evt.getPoint();
selectionBoxEnd = evt.getPoint();
boxSelecting = true;
dragStartMousePos = null;
dragStartBounds = Map.of();
}
);
}
private void handleMouseReleased(MouseEvent evt) {
finishDragCommand();
resizeDragState();
boxSelecting = false;
selectionBoxStart = null;
selectionBoxEnd = null;
dragStartMousePos = null;
dragStartBounds = Map.of();
view.setCurrentSelectionBox(null);
private void placeTextAt(Point point) {
String input = JOptionPane.showInputDialog(view, "Enter text:", "Add text", JOptionPane.PLAIN_MESSAGE);
addingText = false;
if (input == null) {
return;
}
model.add(SText.create(point.x, point.y, input));
resetSelection();
view.repaint();
}
public void enterTextMode() {
addingText = true;
}
private ResizeHandle getHandleAt(Point point) {
final int handleSize = 10;
for (Shape shape : selection) {
Rectangle bounds = shape.getBounds();
// Always-present SE corner handle
if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
return ResizeHandle.SE;
}
// Resize handles are only active in resize mode
if (resizeMode) {
// NW corner
if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
point.y >= bounds.y - handleSize && point.y <= bounds.y) {
return ResizeHandle.NW;
}
// NE corner
if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
point.y >= bounds.y - handleSize && point.y <= bounds.y) {
return ResizeHandle.NE;
}
// SW corner
if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
return ResizeHandle.SW;
}
// N edge
int edgeX = bounds.x + bounds.width / 2 - handleSize / 2;
if (point.x >= edgeX && point.x <= edgeX + handleSize &&
point.y >= bounds.y - handleSize && point.y <= bounds.y) {
return ResizeHandle.N;
}
// S edge
if (point.x >= edgeX && point.x <= edgeX + handleSize &&
point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
return ResizeHandle.S;
}
// W edge
int edgeY = bounds.y + bounds.height / 2 - handleSize / 2;
if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
point.y >= edgeY && point.y <= edgeY + handleSize) {
return ResizeHandle.W;
}
// E edge
if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
point.y >= edgeY && point.y <= edgeY + handleSize) {
return ResizeHandle.E;
}
}
}
return null;
}
private void handleKeyPressed(KeyEvent evt) {
int modifiers = evt.getModifiersEx();
if ((modifiers & InputEvent.CTRL_DOWN_MASK) != 0) {
switch (evt.getKeyCode()) {
case KeyEvent.VK_Z -> {
if ((modifiers & InputEvent.SHIFT_DOWN_MASK) != 0) {
redo();
} else {
undo();
}
evt.consume();
return;
}
case KeyEvent.VK_Y -> {
redo();
evt.consume();
return;
}
case KeyEvent.VK_C -> {
copySelection();
evt.consume();
return;
}
case KeyEvent.VK_X -> {
cutSelection();
evt.consume();
return;
}
case KeyEvent.VK_V -> {
pasteClipboard();
evt.consume();
return;
}
case KeyEvent.VK_G -> {
group();
evt.consume();
return;
}
case KeyEvent.VK_U -> {
ungroup();
evt.consume();
return;
}
}
}
switch (evt.getKeyCode()) {
case KeyEvent.VK_R -> toggleResizeMode();
case KeyEvent.VK_DELETE -> deleteSelected();
case KeyEvent.VK_C -> copySelection();
case KeyEvent.VK_A -> changeSelectionColor();
case KeyEvent.VK_H -> exportHtml();
default -> logger.warn("Pressed unhandled key: {}", evt.getKeyChar());
@@ -505,134 +264,55 @@ public class Controller {
}
}
private void placeTextAt(Point point) {
String input = JOptionPane.showInputDialog(view, "Enter text:", "Add text", JOptionPane.PLAIN_MESSAGE);
addingText = false;
if (input == null) {
private void changeSelectionColor(){
if (selection == null) {
logger.debug("No selection to change color of");
return;
}
addShape(SText.create(point.x, point.y, input));
resetSelection();
for (Shape s : selection) {
if (s instanceof SCollection collection) {
collection.forEach(shape -> shape.addAttributes(new ColorAttributes(false, true, Color.BLACK, new Color((int) (Math.random() * 0x1000000)))));
} else {
s.addAttributes(new ColorAttributes(false, true, Color.BLACK, new Color((int) (Math.random() * 0x1000000))));
}
}
view.repaint();
}
private void copySelection() {
if (selection == null) {
logger.debug("No selection to copy");
return;
}
private ResizeHandle getHandleAt(Point point) {
final int handleSize = 10;
for (Shape shape : selection) {
Rectangle bounds = shape.getBounds();
if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
return ResizeHandle.SE;
this.model.add(shape.clone());
}
if (resizeMode) {
if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
point.y >= bounds.y - handleSize && point.y <= bounds.y) {
return ResizeHandle.NW;
}
if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
point.y >= bounds.y - handleSize && point.y <= bounds.y) {
return ResizeHandle.NE;
}
if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
return ResizeHandle.SW;
}
int edgeX = bounds.x + bounds.width / 2 - handleSize / 2;
if (point.x >= edgeX && point.x <= edgeX + handleSize &&
point.y >= bounds.y - handleSize && point.y <= bounds.y) {
return ResizeHandle.N;
}
if (point.x >= edgeX && point.x <= edgeX + handleSize &&
point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
return ResizeHandle.S;
}
int edgeY = bounds.y + bounds.height / 2 - handleSize / 2;
if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
point.y >= edgeY && point.y <= edgeY + handleSize) {
return ResizeHandle.W;
}
if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
point.y >= edgeY && point.y <= edgeY + handleSize) {
return ResizeHandle.E;
}
}
}
return null;
view.repaint();
}
private void changeColors(Function<Shape, ColorAttributes> updater) {
Map<Shape, ColorAttributes> before = new LinkedHashMap<>();
Map<Shape, ColorAttributes> after = new LinkedHashMap<>();
List<Shape> targets = flattenSelection(selection.getSelectedShapes());
for (Shape shape : targets) {
ColorAttributes current = currentColor(shape);
if (current == null) {
continue;
public void deleteSelected() {
if (selection == null) return;
logger.debug("Deleting selected shape(s)");
for (Shape s : selection) {
this.model.remove(s);
}
ColorAttributes updated = updater.apply(shape);
if (updated == null || sameColor(current, updated)) {
continue;
}
before.put(shape, copy(current));
after.put(shape, copy(updated));
}
if (before.isEmpty()) {
return;
}
executeAndRefresh(new ChangeColorCommand(before.keySet(), before, after));
}
private void beginDrag(Point point) {
lastMousePos = point;
dragStartMousePos = point;
dragStartBounds = captureBounds(selection.getSelectedShapes());
}
private void finishDragCommand() {
if (boxSelecting || dragStartBounds.isEmpty()) {
return;
}
List<Shape> selectedShapes = selection.getSelectedShapes();
if (selectedShapes.isEmpty()) {
return;
}
if (resizing && boundsChanged(selectedShapes, dragStartBounds)) {
Map<Shape, Rectangle> afterBounds = captureBounds(selectedShapes);
Command command = new ResizeShapeCommand(selectedShapes, dragStartBounds, afterBounds);
command.undo();
executeAndRefresh(command);
return;
}
if (boundsChanged(selectedShapes, dragStartBounds)) {
Shape reference = selectedShapes.get(0);
Rectangle before = dragStartBounds.get(reference);
Rectangle after = reference.getBounds();
Command command = new MoveShapeCommand(selectedShapes, after.x - before.x, after.y - before.y);
command.undo();
executeAndRefresh(command);
}
}
private void executeAndRefresh(Command command) {
commandHistory.execute(command);
onModelChanged.run();
resetSelection();
view.repaint();
}
private void resetSelection() {
logger.debug("Resetting selection");
selection.clear();
}
public void addSelectionChangeListener(SelectionListener listener) {
selection.addListener(listener);
}
private Optional<Shape> getTarget(MouseEvent evt, SCollection sc) {
return sc.stream()
.filter(s -> s.getBounds().contains(evt.getPoint()))
@@ -648,71 +328,9 @@ public class Controller {
}
private void updateSelectionFromBox(Rectangle box) {
if (!additiveBoxSelection) {
resetSelection();
}
model.stream()
.filter(s -> s.getBounds().intersects(box))
.forEach(selection::add);
}
private void resizeDragState() {
resizing = false;
activeHandle = null;
resizeOrigin = null;
lastMousePos = null;
}
private Map<Shape, Rectangle> captureBounds(Collection<Shape> shapes) {
Map<Shape, Rectangle> bounds = new LinkedHashMap<>();
for (Shape shape : shapes) {
bounds.put(shape, shape.getBounds());
}
return bounds;
}
private boolean boundsChanged(Collection<Shape> shapes, Map<Shape, Rectangle> before) {
for (Shape shape : shapes) {
Rectangle previous = before.get(shape);
if (previous != null && !previous.equals(shape.getBounds())) {
return true;
}
}
return false;
}
private List<Shape> flattenSelection(Collection<Shape> selectedShapes) {
LinkedHashSet<Shape> flattened = new LinkedHashSet<>();
for (Shape shape : selectedShapes) {
flattenShape(shape, flattened);
}
return new ArrayList<>(flattened);
}
private void flattenShape(Shape shape, Collection<Shape> flattened) {
if (shape instanceof SCollection collection) {
collection.forEach(child -> flattenShape(child, flattened));
return;
}
flattened.add(shape);
}
private ColorAttributes currentColor(Shape shape) {
return (ColorAttributes) shape.getAttributes(ColorAttributes.ID);
}
private ColorAttributes copy(ColorAttributes attrs) {
return new ColorAttributes(attrs.filled, attrs.stroked, attrs.filledColor, attrs.strokedColor);
}
private boolean sameColor(ColorAttributes left, ColorAttributes right) {
return left.filled == right.filled
&& left.stroked == right.stroked
&& left.filledColor.equals(right.filledColor)
&& left.strokedColor.equals(right.strokedColor);
}
private Color randomColor() {
return new Color((int) (Math.random() * 0x1000000));
}
}

View File

@@ -0,0 +1,387 @@
package ovh.gasser.newshapes.shapes;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import java.awt.Color;
import java.awt.Point;
import static org.junit.jupiter.api.Assertions.*;
/**
* Tests bounds-based hit-testing for all shape types.
* Hit-testing is performed via {@code shape.getBounds().contains(Point)},
* delegating to {@link java.awt.Rectangle#contains(Point)}.
*
* <p>Note on {@link java.awt.Rectangle#contains} boundary semantics:
* A rectangle {@code (x, y, w, h)} contains a point {@code (px, py)} when:
* {@code x <= px < x+w} and {@code y <= py < y+h}.
* The top-left corner is <em>inclusive</em>; the bottom-right corner is <em>exclusive</em>.
*/
class ContainsPointTest {
// -----------------------------------------------------------------------
// SRectangle — bounds = (x, y, width, height)
// -----------------------------------------------------------------------
@Nested
class SRectangleContainsPoint {
// Shape: origin (10, 20), size 80×60 → right-exclusive: x=90, y=80
private final SRectangle rect = SRectangle.create(10, 20, 80, 60);
@Test
void pointInsideShouldBeContained() {
Point inside = new Point(50, 50);
assertTrue(rect.getBounds().contains(inside),
"A point clearly inside the rectangle should be contained");
}
@Test
void pointOutsideShouldNotBeContained() {
Point outside = new Point(5, 5);
assertFalse(rect.getBounds().contains(outside),
"A point outside the rectangle should not be contained");
}
@Test
void pointFarOutsideShouldNotBeContained() {
Point farOutside = new Point(200, 300);
assertFalse(rect.getBounds().contains(farOutside),
"A point far outside the rectangle should not be contained");
}
@Test
void topLeftCornerShouldBeContained() {
// Rectangle.contains is inclusive of the top-left corner
Point topLeft = new Point(10, 20);
assertTrue(rect.getBounds().contains(topLeft),
"The top-left corner (inclusive boundary) should be contained");
}
@Test
void bottomRightCornerShouldNotBeContained() {
// Rectangle.contains is exclusive of the bottom-right corner
Point bottomRight = new Point(90, 80); // x + width, y + height
assertFalse(rect.getBounds().contains(bottomRight),
"The bottom-right corner (exclusive boundary) should not be contained");
}
@Test
void pointJustInsideBottomRightShouldBeContained() {
Point justInside = new Point(89, 79); // one pixel before exclusive boundary
assertTrue(rect.getBounds().contains(justInside),
"A point one pixel before the bottom-right boundary should be contained");
}
@Test
void pointAfterTranslateShouldBeAtNewPosition() {
SRectangle moved = SRectangle.create(10, 20, 80, 60);
moved.translate(30, 40); // new bounds: (40, 60, 80, 60)
Point oldCenter = new Point(50, 50);
assertFalse(moved.getBounds().contains(oldCenter),
"After translate, old center should no longer be contained");
Point newCenter = new Point(80, 90);
assertTrue(moved.getBounds().contains(newCenter),
"After translate, a point at the new center should be contained");
}
@Test
void pointOnTopEdgeShouldBeContained() {
Point topEdge = new Point(50, 20); // y == rect.y, inside x range
assertTrue(rect.getBounds().contains(topEdge),
"A point on the top edge should be contained");
}
@Test
void pointOnLeftEdgeShouldBeContained() {
Point leftEdge = new Point(10, 50); // x == rect.x, inside y range
assertTrue(rect.getBounds().contains(leftEdge),
"A point on the left edge should be contained");
}
@Test
void pointOnRightEdgeShouldNotBeContained() {
Point rightEdge = new Point(90, 50); // x == rect.x + rect.width (exclusive)
assertFalse(rect.getBounds().contains(rightEdge),
"A point exactly on the right edge (exclusive) should not be contained");
}
@Test
void pointOnBottomEdgeShouldNotBeContained() {
Point bottomEdge = new Point(50, 80); // y == rect.y + rect.height (exclusive)
assertFalse(rect.getBounds().contains(bottomEdge),
"A point exactly on the bottom edge (exclusive) should not be contained");
}
}
// -----------------------------------------------------------------------
// SCircle — bounds = (x, y, radius*2, radius*2)
// -----------------------------------------------------------------------
@Nested
class SCircleContainsPoint {
// Shape: origin (20, 30), radius=40 → bounds (20, 30, 80, 80)
// right-exclusive corner: (100, 110)
private final SCircle circle = SCircle.create(20, 30, 40);
@Test
void pointInsideBoundsShouldBeContained() {
Point inside = new Point(60, 70);
assertTrue(circle.getBounds().contains(inside),
"A point inside the bounding box should be contained");
}
@Test
void pointOutsideBoundsShouldNotBeContained() {
Point outside = new Point(10, 10);
assertFalse(circle.getBounds().contains(outside),
"A point outside the bounding box should not be contained");
}
@Test
void topLeftCornerShouldBeContained() {
Point topLeft = new Point(20, 30);
assertTrue(circle.getBounds().contains(topLeft),
"The top-left corner of the bounding box (inclusive) should be contained");
}
@Test
void bottomRightCornerShouldNotBeContained() {
Point bottomRight = new Point(100, 110); // x + 2r, y + 2r
assertFalse(circle.getBounds().contains(bottomRight),
"The bottom-right corner of the bounding box (exclusive) should not be contained");
}
@Test
void pointAfterTranslateShouldBeAtNewPosition() {
SCircle moved = SCircle.create(20, 30, 40);
moved.translate(50, 50); // new bounds: (70, 80, 80, 80)
Point oldCenter = new Point(60, 70);
assertFalse(moved.getBounds().contains(oldCenter),
"After translate, old center should no longer be contained");
Point newCenter = new Point(110, 120);
assertTrue(moved.getBounds().contains(newCenter),
"After translate, a point at the new center should be contained");
}
}
// -----------------------------------------------------------------------
// STriangle — bounds = (x, y, size, size)
// -----------------------------------------------------------------------
@Nested
class STriangleContainsPoint {
// Shape: origin (5, 15), size=60 → bounds (5, 15, 60, 60)
// right-exclusive corner: (65, 75)
private final STriangle triangle = STriangle.create(5, 15, 60, Color.RED, Color.BLACK);
@Test
void pointInsideBoundsShouldBeContained() {
Point inside = new Point(35, 45);
assertTrue(triangle.getBounds().contains(inside),
"A point inside the bounding box should be contained");
}
@Test
void pointOutsideBoundsShouldNotBeContained() {
Point outside = new Point(0, 0);
assertFalse(triangle.getBounds().contains(outside),
"A point outside the bounding box should not be contained");
}
@Test
void topLeftCornerShouldBeContained() {
Point topLeft = new Point(5, 15);
assertTrue(triangle.getBounds().contains(topLeft),
"The top-left corner of the bounding box (inclusive) should be contained");
}
@Test
void bottomRightCornerShouldNotBeContained() {
Point bottomRight = new Point(65, 75); // x + size, y + size
assertFalse(triangle.getBounds().contains(bottomRight),
"The bottom-right corner of the bounding box (exclusive) should not be contained");
}
@Test
void pointAfterTranslateShouldBeAtNewPosition() {
STriangle moved = STriangle.create(5, 15, 60, Color.RED, Color.BLACK);
moved.translate(100, 100); // new bounds: (105, 115, 60, 60)
Point oldCenter = new Point(35, 45);
assertFalse(moved.getBounds().contains(oldCenter),
"After translate, old center should no longer be contained");
Point newCenter = new Point(135, 145);
assertTrue(moved.getBounds().contains(newCenter),
"After translate, a point at the new center should be contained");
}
}
// -----------------------------------------------------------------------
// SText — bounds = (x, y, 100, 20)
// -----------------------------------------------------------------------
@Nested
class STextContainsPoint {
// Shape: origin (50, 100) → bounds (50, 100, 100, 20)
// right-exclusive corner: (150, 120)
private final SText text = SText.create(50, 100, "Hello");
@Test
void pointInsideBoundsShouldBeContained() {
Point inside = new Point(100, 110);
assertTrue(text.getBounds().contains(inside),
"A point inside the default text bounding box should be contained");
}
@Test
void pointOutsideBoundsShouldNotBeContained() {
Point outside = new Point(10, 10);
assertFalse(text.getBounds().contains(outside),
"A point outside the text bounding box should not be contained");
}
@Test
void topLeftCornerShouldBeContained() {
Point topLeft = new Point(50, 100);
assertTrue(text.getBounds().contains(topLeft),
"The top-left corner of the text bounding box (inclusive) should be contained");
}
@Test
void bottomRightCornerShouldNotBeContained() {
// Default bounds width=100, height=20 → exclusive corner at (150, 120)
Point bottomRight = new Point(150, 120);
assertFalse(text.getBounds().contains(bottomRight),
"The bottom-right corner of the text bounding box (exclusive) should not be contained");
}
@Test
void pointJustBeforeBottomRightShouldBeContained() {
Point justInside = new Point(149, 119);
assertTrue(text.getBounds().contains(justInside),
"A point one pixel before the exclusive bottom-right boundary should be contained");
}
@Test
void pointAfterTranslateShouldBeAtNewPosition() {
// Original bounds: (50, 100, 100, 20) — covers x∈[50,150), y∈[100,120)
SText moved = SText.create(50, 100, "Hello");
moved.translate(-40, 10); // new bounds: (10, 110, 100, 20) — covers x∈[10,110), y∈[110,130)
// (130, 105) was inside original bounds but is now outside (x=130 >= 110, y=105 < 110)
Point oldPosition = new Point(130, 105);
assertFalse(moved.getBounds().contains(oldPosition),
"After translate, a point that was in the old bounds should no longer be contained");
// (50, 115) is inside new bounds: x∈[10,110), y∈[110,130) ✓
Point newPosition = new Point(50, 115);
assertTrue(moved.getBounds().contains(newPosition),
"After translate, a point in the new bounds should be contained");
}
@Test
void blankTextUsesDefaultPlaceholderAndSameBounds() {
// Even blank/null text falls back to the placeholder — bounds remain (x, y, 100, 20)
SText blankText = SText.create(0, 0, "");
Point inside = new Point(50, 10);
assertTrue(blankText.getBounds().contains(inside),
"Blank text still uses default bounds; interior point should be contained");
}
}
// -----------------------------------------------------------------------
// SCollection — bounds = union of children bounds
// -----------------------------------------------------------------------
@Nested
class SCollectionContainsPoint {
// Two non-overlapping children:
// rect1: (10, 10, 50, 50) → covers x∈[10,60), y∈[10,60)
// rect2: (100, 100, 40, 40) → covers x∈[100,140), y∈[100,140)
// Union bounds: (10, 10, 130, 130) → exclusive corner: (140, 140)
private final SRectangle child1 = SRectangle.create(10, 10, 50, 50);
private final SRectangle child2 = SRectangle.create(100, 100, 40, 40);
private final SCollection collection = SCollection.of(child1, child2);
@Test
void pointInsideFirstChildBoundsShouldBeContained() {
Point insideChild1 = new Point(30, 30);
assertTrue(collection.getBounds().contains(insideChild1),
"A point inside the first child's bounds is within the union and should be contained");
}
@Test
void pointInsideSecondChildBoundsShouldBeContained() {
Point insideChild2 = new Point(120, 120);
assertTrue(collection.getBounds().contains(insideChild2),
"A point inside the second child's bounds is within the union and should be contained");
}
@Test
void pointInGapBetweenChildrenShouldBeContained() {
// The union rectangle spans the gap between the two children
Point inGap = new Point(70, 70);
assertTrue(collection.getBounds().contains(inGap),
"A point in the gap between children is still inside the union bounds and should be contained");
}
@Test
void pointOutsideUnionShouldNotBeContained() {
Point outside = new Point(0, 0);
assertFalse(collection.getBounds().contains(outside),
"A point outside the union bounds should not be contained");
}
@Test
void topLeftCornerOfUnionShouldBeContained() {
// Union top-left = (10, 10) — inclusive
Point topLeft = new Point(10, 10);
assertTrue(collection.getBounds().contains(topLeft),
"The top-left corner of the union bounds (inclusive) should be contained");
}
@Test
void bottomRightCornerOfUnionShouldNotBeContained() {
// Union: x=10, y=10, w=130, h=130 → exclusive corner (140, 140)
Point bottomRight = new Point(140, 140);
assertFalse(collection.getBounds().contains(bottomRight),
"The bottom-right corner of the union bounds (exclusive) should not be contained");
}
@Test
void pointAfterTranslatingChildrenShouldBeAtNewPosition() {
SRectangle movableChild = SRectangle.create(0, 0, 30, 30);
SCollection movable = SCollection.of(movableChild);
movable.translate(50, 50); // child now at (50, 50, 30, 30)
Point oldPoint = new Point(15, 15);
assertFalse(movable.getBounds().contains(oldPoint),
"After translate, a point at the old location should not be contained");
Point newPoint = new Point(65, 65);
assertTrue(movable.getBounds().contains(newPoint),
"After translate, a point at the new location should be contained");
}
@Test
void singleChildCollectionBoundsMatchChildBounds() {
SRectangle only = SRectangle.create(5, 5, 20, 20);
SCollection single = SCollection.of(only);
assertEquals(only.getBounds(), single.getBounds(),
"A single-child collection's bounds should equal the child's own bounds");
}
}
}

View File

@@ -44,4 +44,40 @@ class STextTest {
SText text = SText.create(0, 0, null);
assertEquals(SText.PLACEHOLDER_TEXT, text.getText());
}
@Test
void testUpdateMeasuredBoundsActuallyUpdatesBounds() {
SText text = SText.create(10, 20, "Hello");
text.updateMeasuredBounds(200, 30);
Rectangle bounds = text.getBounds();
assertEquals(200, bounds.width, "updateMeasuredBounds must update width");
assertEquals(30, bounds.height, "updateMeasuredBounds must update height");
}
@Test
void testUpdateMeasuredBoundsDoesNotChangePosition() {
SText text = SText.create(10, 20, "Hello");
text.updateMeasuredBounds(200, 30);
Rectangle bounds = text.getBounds();
assertEquals(10, bounds.x, "updateMeasuredBounds must not change x");
assertEquals(20, bounds.y, "updateMeasuredBounds must not change y");
}
@Test
void testUpdateMeasuredBoundsNegativeClampedToZero() {
SText text = SText.create(0, 0, "Hello");
text.updateMeasuredBounds(-5, -10);
Rectangle bounds = text.getBounds();
assertEquals(0, bounds.width, "negative width must be clamped to 0");
assertEquals(0, bounds.height, "negative height must be clamped to 0");
}
@Test
void testUpdateMeasuredBoundsZeroIsAllowed() {
SText text = SText.create(0, 0, "Hello");
text.updateMeasuredBounds(0, 0);
Rectangle bounds = text.getBounds();
assertEquals(0, bounds.width);
assertEquals(0, bounds.height);
}
}

View File

@@ -1,198 +0,0 @@
package ovh.gasser.newshapes.ui;
import org.junit.jupiter.api.Test;
import ovh.gasser.newshapes.attributes.SelectionAttributes;
import ovh.gasser.newshapes.shapes.SCollection;
import ovh.gasser.newshapes.shapes.SRectangle;
import ovh.gasser.newshapes.shapes.Shape;
import java.awt.*;
import java.awt.event.InputEvent;
import java.awt.event.KeyEvent;
import java.awt.event.MouseEvent;
import java.awt.event.MouseListener;
import java.util.List;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertInstanceOf;
import static org.junit.jupiter.api.Assertions.assertTrue;
class ControllerTest {
@Test
void copyDoesNotMutateModelAndPasteSelectsOffsetClone() {
SCollection model = SCollection.of(SRectangle.create(10, 15, 30, 40, Color.BLUE));
ShapesView view = new ShapesView(model);
Controller controller = view.getController();
click(view, 15, 20, 0);
controller.copySelection();
assertEquals(1, model.stream().count());
controller.pasteClipboard();
List<Shape> shapes = model.stream().toList();
assertEquals(2, shapes.size());
assertEquals(new Rectangle(10, 15, 30, 40), shapes.get(0).getBounds());
assertEquals(new Rectangle(30, 35, 30, 40), shapes.get(1).getBounds());
assertFalse(isSelected(shapes.get(0)));
assertTrue(isSelected(shapes.get(1)));
}
@Test
void repeatedPasteKeepsIncreasingOffset() {
SCollection model = SCollection.of(SRectangle.create(5, 10, 20, 25, Color.RED));
ShapesView view = new ShapesView(model);
Controller controller = view.getController();
click(view, 10, 15, 0);
controller.copySelection();
controller.pasteClipboard();
controller.pasteClipboard();
List<Shape> shapes = model.stream().toList();
assertEquals(3, shapes.size());
assertEquals(new Rectangle(25, 30, 20, 25), shapes.get(1).getBounds());
assertEquals(new Rectangle(45, 50, 20, 25), shapes.get(2).getBounds());
assertFalse(isSelected(shapes.get(1)));
assertTrue(isSelected(shapes.get(2)));
}
@Test
void controlShortcutsCutAndPasteMultipleShapes() {
SCollection model = SCollection.of(
SRectangle.create(10, 10, 15, 20, Color.BLACK),
SRectangle.create(80, 25, 25, 30, Color.GREEN)
);
ShapesView view = new ShapesView(model);
click(view, 15, 15, 0);
click(view, 85, 30, InputEvent.SHIFT_DOWN_MASK);
pressShortcut(view, KeyEvent.VK_X);
assertEquals(0, model.stream().count());
pressShortcut(view, KeyEvent.VK_V);
List<Shape> shapes = model.stream().toList();
assertEquals(2, shapes.size());
assertEquals(new Rectangle(30, 30, 15, 20), shapes.get(0).getBounds());
assertEquals(new Rectangle(100, 45, 25, 30), shapes.get(1).getBounds());
assertTrue(isSelected(shapes.get(0)));
assertTrue(isSelected(shapes.get(1)));
}
@Test
void groupReplacesSelectedShapesWithCollectionAndSelectsIt() {
SRectangle rect1 = SRectangle.create(10, 10, 15, 20, Color.BLACK);
SRectangle rect2 = SRectangle.create(80, 25, 25, 30, Color.GREEN);
SRectangle rect3 = SRectangle.create(140, 40, 10, 10, Color.BLUE);
SCollection model = SCollection.of(rect1, rect2, rect3);
ShapesView view = new ShapesView(model);
Controller controller = view.getController();
click(view, 15, 15, 0);
click(view, 85, 30, InputEvent.SHIFT_DOWN_MASK);
controller.group();
List<Shape> shapes = model.stream().toList();
assertEquals(2, shapes.size());
SCollection group = assertInstanceOf(SCollection.class, shapes.get(0));
assertEquals(List.of(rect1, rect2), group.stream().toList());
assertEquals(new Rectangle(10, 10, 95, 45), group.getBounds());
assertTrue(isSelected(group));
assertFalse(isSelected(rect1));
assertFalse(isSelected(rect2));
assertFalse(isSelected(rect3));
}
@Test
void ungroupOnlyBreaksApartOneLevelAndSelectsChildren() {
SRectangle rect1 = SRectangle.create(10, 10, 15, 20, Color.BLACK);
SRectangle rect2 = SRectangle.create(80, 25, 25, 30, Color.GREEN);
SCollection innerGroup = SCollection.of(rect1, rect2);
SRectangle rect3 = SRectangle.create(140, 40, 10, 10, Color.BLUE);
SCollection outerGroup = SCollection.of(innerGroup, rect3);
SCollection model = SCollection.of(outerGroup);
ShapesView view = new ShapesView(model);
Controller controller = view.getController();
click(view, 15, 15, 0);
controller.ungroup();
List<Shape> shapes = model.stream().toList();
assertEquals(List.of(innerGroup, rect3), shapes);
assertTrue(isSelected(innerGroup));
assertTrue(isSelected(rect3));
assertFalse(isSelected(rect1));
assertFalse(isSelected(rect2));
}
@Test
void controlShortcutsGroupAndUngroupShapes() {
SCollection model = SCollection.of(
SRectangle.create(10, 10, 15, 20, Color.BLACK),
SRectangle.create(80, 25, 25, 30, Color.GREEN)
);
ShapesView view = new ShapesView(model);
click(view, 15, 15, 0);
click(view, 85, 30, InputEvent.SHIFT_DOWN_MASK);
pressShortcut(view, KeyEvent.VK_G, InputEvent.CTRL_DOWN_MASK);
Shape groupedShape = model.stream().toList().get(0);
assertTrue(groupedShape instanceof SCollection);
assertTrue(isSelected(groupedShape));
pressShortcut(view, KeyEvent.VK_U, InputEvent.CTRL_DOWN_MASK);
List<Shape> shapes = model.stream().toList();
assertEquals(2, shapes.size());
assertTrue(isSelected(shapes.get(0)));
assertTrue(isSelected(shapes.get(1)));
}
private static void click(ShapesView view, int x, int y, int modifiers) {
MouseEvent event = new MouseEvent(
view,
MouseEvent.MOUSE_PRESSED,
System.currentTimeMillis(),
modifiers,
x,
y,
1,
false,
MouseEvent.BUTTON1
);
for (MouseListener listener : view.getMouseListeners()) {
listener.mousePressed(event);
}
}
private static void pressShortcut(ShapesView view, int keyCode) {
pressShortcut(view, keyCode, InputEvent.CTRL_DOWN_MASK);
}
private static void pressShortcut(ShapesView view, int keyCode, int modifiers) {
KeyEvent event = new KeyEvent(
view,
KeyEvent.KEY_PRESSED,
System.currentTimeMillis(),
modifiers,
keyCode,
KeyEvent.CHAR_UNDEFINED
);
for (var listener : view.getKeyListeners()) {
listener.keyPressed(event);
}
}
private static boolean isSelected(Shape shape) {
SelectionAttributes attributes = (SelectionAttributes) shape.getAttributes(SelectionAttributes.ID);
return attributes != null && attributes.selected;
}
}