Implement #37: Save/Load Functionality for Drawings

Reviewed-on: #22

.gitea/workflows/ci.yaml

@@ -20,11 +20,11 @@ jobs:
           distribution: 'temurin'
 
       - name: Build and test with coverage
-        run: mvn verify --batch-mode
+        run: ./mvnw verify --batch-mode
 
       - name: Upload coverage report
         if: always()
-        uses: actions/upload-artifact@v4
+        uses: https://gitea.com/actions/gitea-upload-artifact@v4
         with:
           name: jacoco-report
           path: target/site/jacoco/

.mvn/wrapper/maven-wrapper.properties

@@ -0,0 +1,3 @@
+wrapperVersion=3.3.4
+distributionType=only-script
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.12/apache-maven-3.9.12-bin.zip

TODO.md

@@ -1,6 +1,6 @@
 # TODO
 
-- [ ] Box selection (drag to select multiple shapes)
+- [X] Box selection (drag to select multiple shapes)
 - [ ] Undo/redo stack
 - [ ] Copy/paste functionality
 - [ ] Group/Ungroup shapes

mvnw

@@ -0,0 +1,295 @@
+#!/bin/sh
+# ----------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# ----------------------------------------------------------------------------
+
+# ----------------------------------------------------------------------------
+# Apache Maven Wrapper startup batch script, version 3.3.4
+#
+# Optional ENV vars
+# -----------------
+#   JAVA_HOME - location of a JDK home dir, required when download maven via java source
+#   MVNW_REPOURL - repo url base for downloading maven distribution
+#   MVNW_USERNAME/MVNW_PASSWORD - user and password for downloading maven
+#   MVNW_VERBOSE - true: enable verbose log; debug: trace the mvnw script; others: silence the output
+# ----------------------------------------------------------------------------
+
+set -euf
+[ "${MVNW_VERBOSE-}" != debug ] || set -x
+
+# OS specific support.
+native_path() { printf %s\\n "$1"; }
+case "$(uname)" in
+CYGWIN* | MINGW*)
+  [ -z "${JAVA_HOME-}" ] || JAVA_HOME="$(cygpath --unix "$JAVA_HOME")"
+  native_path() { cygpath --path --windows "$1"; }
+  ;;
+esac
+
+# set JAVACMD and JAVACCMD
+set_java_home() {
+  # For Cygwin and MinGW, ensure paths are in Unix format before anything is touched
+  if [ -n "${JAVA_HOME-}" ]; then
+    if [ -x "$JAVA_HOME/jre/sh/java" ]; then
+      # IBM's JDK on AIX uses strange locations for the executables
+      JAVACMD="$JAVA_HOME/jre/sh/java"
+      JAVACCMD="$JAVA_HOME/jre/sh/javac"
+    else
+      JAVACMD="$JAVA_HOME/bin/java"
+      JAVACCMD="$JAVA_HOME/bin/javac"
+
+      if [ ! -x "$JAVACMD" ] || [ ! -x "$JAVACCMD" ]; then
+        echo "The JAVA_HOME environment variable is not defined correctly, so mvnw cannot run." >&2
+        echo "JAVA_HOME is set to \"$JAVA_HOME\", but \"\$JAVA_HOME/bin/java\" or \"\$JAVA_HOME/bin/javac\" does not exist." >&2
+        return 1
+      fi
+    fi
+  else
+    JAVACMD="$(
+      'set' +e
+      'unset' -f command 2>/dev/null
+      'command' -v java
+    )" || :
+    JAVACCMD="$(
+      'set' +e
+      'unset' -f command 2>/dev/null
+      'command' -v javac
+    )" || :
+
+    if [ ! -x "${JAVACMD-}" ] || [ ! -x "${JAVACCMD-}" ]; then
+      echo "The java/javac command does not exist in PATH nor is JAVA_HOME set, so mvnw cannot run." >&2
+      return 1
+    fi
+  fi
+}
+
+# hash string like Java String::hashCode
+hash_string() {
+  str="${1:-}" h=0
+  while [ -n "$str" ]; do
+    char="${str%"${str#?}"}"
+    h=$(((h * 31 + $(LC_CTYPE=C printf %d "'$char")) % 4294967296))
+    str="${str#?}"
+  done
+  printf %x\\n $h
+}
+
+verbose() { :; }
+[ "${MVNW_VERBOSE-}" != true ] || verbose() { printf %s\\n "${1-}"; }
+
+die() {
+  printf %s\\n "$1" >&2
+  exit 1
+}
+
+trim() {
+  # MWRAPPER-139:
+  #   Trims trailing and leading whitespace, carriage returns, tabs, and linefeeds.
+  #   Needed for removing poorly interpreted newline sequences when running in more
+  #   exotic environments such as mingw bash on Windows.
+  printf "%s" "${1}" | tr -d '[:space:]'
+}
+
+scriptDir="$(dirname "$0")"
+scriptName="$(basename "$0")"
+
+# parse distributionUrl and optional distributionSha256Sum, requires .mvn/wrapper/maven-wrapper.properties
+while IFS="=" read -r key value; do
+  case "${key-}" in
+  distributionUrl) distributionUrl=$(trim "${value-}") ;;
+  distributionSha256Sum) distributionSha256Sum=$(trim "${value-}") ;;
+  esac
+done <"$scriptDir/.mvn/wrapper/maven-wrapper.properties"
+[ -n "${distributionUrl-}" ] || die "cannot read distributionUrl property in $scriptDir/.mvn/wrapper/maven-wrapper.properties"
+
+case "${distributionUrl##*/}" in
+maven-mvnd-*bin.*)
+  MVN_CMD=mvnd.sh _MVNW_REPO_PATTERN=/maven/mvnd/
+  case "${PROCESSOR_ARCHITECTURE-}${PROCESSOR_ARCHITEW6432-}:$(uname -a)" in
+  *AMD64:CYGWIN* | *AMD64:MINGW*) distributionPlatform=windows-amd64 ;;
+  :Darwin*x86_64) distributionPlatform=darwin-amd64 ;;
+  :Darwin*arm64) distributionPlatform=darwin-aarch64 ;;
+  :Linux*x86_64*) distributionPlatform=linux-amd64 ;;
+  *)
+    echo "Cannot detect native platform for mvnd on $(uname)-$(uname -m), use pure java version" >&2
+    distributionPlatform=linux-amd64
+    ;;
+  esac
+  distributionUrl="${distributionUrl%-bin.*}-$distributionPlatform.zip"
+  ;;
+maven-mvnd-*) MVN_CMD=mvnd.sh _MVNW_REPO_PATTERN=/maven/mvnd/ ;;
+*) MVN_CMD="mvn${scriptName#mvnw}" _MVNW_REPO_PATTERN=/org/apache/maven/ ;;
+esac
+
+# apply MVNW_REPOURL and calculate MAVEN_HOME
+# maven home pattern: ~/.m2/wrapper/dists/{apache-maven-<version>,maven-mvnd-<version>-<platform>}/<hash>
+[ -z "${MVNW_REPOURL-}" ] || distributionUrl="$MVNW_REPOURL$_MVNW_REPO_PATTERN${distributionUrl#*"$_MVNW_REPO_PATTERN"}"
+distributionUrlName="${distributionUrl##*/}"
+distributionUrlNameMain="${distributionUrlName%.*}"
+distributionUrlNameMain="${distributionUrlNameMain%-bin}"
+MAVEN_USER_HOME="${MAVEN_USER_HOME:-${HOME}/.m2}"
+MAVEN_HOME="${MAVEN_USER_HOME}/wrapper/dists/${distributionUrlNameMain-}/$(hash_string "$distributionUrl")"
+
+exec_maven() {
+  unset MVNW_VERBOSE MVNW_USERNAME MVNW_PASSWORD MVNW_REPOURL || :
+  exec "$MAVEN_HOME/bin/$MVN_CMD" "$@" || die "cannot exec $MAVEN_HOME/bin/$MVN_CMD"
+}
+
+if [ -d "$MAVEN_HOME" ]; then
+  verbose "found existing MAVEN_HOME at $MAVEN_HOME"
+  exec_maven "$@"
+fi
+
+case "${distributionUrl-}" in
+*?-bin.zip | *?maven-mvnd-?*-?*.zip) ;;
+*) die "distributionUrl is not valid, must match *-bin.zip or maven-mvnd-*.zip, but found '${distributionUrl-}'" ;;
+esac
+
+# prepare tmp dir
+if TMP_DOWNLOAD_DIR="$(mktemp -d)" && [ -d "$TMP_DOWNLOAD_DIR" ]; then
+  clean() { rm -rf -- "$TMP_DOWNLOAD_DIR"; }
+  trap clean HUP INT TERM EXIT
+else
+  die "cannot create temp dir"
+fi
+
+mkdir -p -- "${MAVEN_HOME%/*}"
+
+# Download and Install Apache Maven
+verbose "Couldn't find MAVEN_HOME, downloading and installing it ..."
+verbose "Downloading from: $distributionUrl"
+verbose "Downloading to: $TMP_DOWNLOAD_DIR/$distributionUrlName"
+
+# select .zip or .tar.gz
+if ! command -v unzip >/dev/null; then
+  distributionUrl="${distributionUrl%.zip}.tar.gz"
+  distributionUrlName="${distributionUrl##*/}"
+fi
+
+# verbose opt
+__MVNW_QUIET_WGET=--quiet __MVNW_QUIET_CURL=--silent __MVNW_QUIET_UNZIP=-q __MVNW_QUIET_TAR=''
+[ "${MVNW_VERBOSE-}" != true ] || __MVNW_QUIET_WGET='' __MVNW_QUIET_CURL='' __MVNW_QUIET_UNZIP='' __MVNW_QUIET_TAR=v
+
+# normalize http auth
+case "${MVNW_PASSWORD:+has-password}" in
+'') MVNW_USERNAME='' MVNW_PASSWORD='' ;;
+has-password) [ -n "${MVNW_USERNAME-}" ] || MVNW_USERNAME='' MVNW_PASSWORD='' ;;
+esac
+
+if [ -z "${MVNW_USERNAME-}" ] && command -v wget >/dev/null; then
+  verbose "Found wget ... using wget"
+  wget ${__MVNW_QUIET_WGET:+"$__MVNW_QUIET_WGET"} "$distributionUrl" -O "$TMP_DOWNLOAD_DIR/$distributionUrlName" || die "wget: Failed to fetch $distributionUrl"
+elif [ -z "${MVNW_USERNAME-}" ] && command -v curl >/dev/null; then
+  verbose "Found curl ... using curl"
+  curl ${__MVNW_QUIET_CURL:+"$__MVNW_QUIET_CURL"} -f -L -o "$TMP_DOWNLOAD_DIR/$distributionUrlName" "$distributionUrl" || die "curl: Failed to fetch $distributionUrl"
+elif set_java_home; then
+  verbose "Falling back to use Java to download"
+  javaSource="$TMP_DOWNLOAD_DIR/Downloader.java"
+  targetZip="$TMP_DOWNLOAD_DIR/$distributionUrlName"
+  cat >"$javaSource" <<-END
+	public class Downloader extends java.net.Authenticator
+	{
+	  protected java.net.PasswordAuthentication getPasswordAuthentication()
+	  {
+	    return new java.net.PasswordAuthentication( System.getenv( "MVNW_USERNAME" ), System.getenv( "MVNW_PASSWORD" ).toCharArray() );
+	  }
+	  public static void main( String[] args ) throws Exception
+	  {
+	    setDefault( new Downloader() );
+	    java.nio.file.Files.copy( java.net.URI.create( args[0] ).toURL().openStream(), java.nio.file.Paths.get( args[1] ).toAbsolutePath().normalize() );
+	  }
+	}
+	END
+  # For Cygwin/MinGW, switch paths to Windows format before running javac and java
+  verbose " - Compiling Downloader.java ..."
+  "$(native_path "$JAVACCMD")" "$(native_path "$javaSource")" || die "Failed to compile Downloader.java"
+  verbose " - Running Downloader.java ..."
+  "$(native_path "$JAVACMD")" -cp "$(native_path "$TMP_DOWNLOAD_DIR")" Downloader "$distributionUrl" "$(native_path "$targetZip")"
+fi
+
+# If specified, validate the SHA-256 sum of the Maven distribution zip file
+if [ -n "${distributionSha256Sum-}" ]; then
+  distributionSha256Result=false
+  if [ "$MVN_CMD" = mvnd.sh ]; then
+    echo "Checksum validation is not supported for maven-mvnd." >&2
+    echo "Please disable validation by removing 'distributionSha256Sum' from your maven-wrapper.properties." >&2
+    exit 1
+  elif command -v sha256sum >/dev/null; then
+    if echo "$distributionSha256Sum  $TMP_DOWNLOAD_DIR/$distributionUrlName" | sha256sum -c - >/dev/null 2>&1; then
+      distributionSha256Result=true
+    fi
+  elif command -v shasum >/dev/null; then
+    if echo "$distributionSha256Sum  $TMP_DOWNLOAD_DIR/$distributionUrlName" | shasum -a 256 -c >/dev/null 2>&1; then
+      distributionSha256Result=true
+    fi
+  else
+    echo "Checksum validation was requested but neither 'sha256sum' or 'shasum' are available." >&2
+    echo "Please install either command, or disable validation by removing 'distributionSha256Sum' from your maven-wrapper.properties." >&2
+    exit 1
+  fi
+  if [ $distributionSha256Result = false ]; then
+    echo "Error: Failed to validate Maven distribution SHA-256, your Maven distribution might be compromised." >&2
+    echo "If you updated your Maven version, you need to update the specified distributionSha256Sum property." >&2
+    exit 1
+  fi
+fi
+
+# unzip and move
+if command -v unzip >/dev/null; then
+  unzip ${__MVNW_QUIET_UNZIP:+"$__MVNW_QUIET_UNZIP"} "$TMP_DOWNLOAD_DIR/$distributionUrlName" -d "$TMP_DOWNLOAD_DIR" || die "failed to unzip"
+else
+  tar xzf${__MVNW_QUIET_TAR:+"$__MVNW_QUIET_TAR"} "$TMP_DOWNLOAD_DIR/$distributionUrlName" -C "$TMP_DOWNLOAD_DIR" || die "failed to untar"
+fi
+
+# Find the actual extracted directory name (handles snapshots where filename != directory name)
+actualDistributionDir=""
+
+# First try the expected directory name (for regular distributions)
+if [ -d "$TMP_DOWNLOAD_DIR/$distributionUrlNameMain" ]; then
+  if [ -f "$TMP_DOWNLOAD_DIR/$distributionUrlNameMain/bin/$MVN_CMD" ]; then
+    actualDistributionDir="$distributionUrlNameMain"
+  fi
+fi
+
+# If not found, search for any directory with the Maven executable (for snapshots)
+if [ -z "$actualDistributionDir" ]; then
+  # enable globbing to iterate over items
+  set +f
+  for dir in "$TMP_DOWNLOAD_DIR"/*; do
+    if [ -d "$dir" ]; then
+      if [ -f "$dir/bin/$MVN_CMD" ]; then
+        actualDistributionDir="$(basename "$dir")"
+        break
+      fi
+    fi
+  done
+  set -f
+fi
+
+if [ -z "$actualDistributionDir" ]; then
+  verbose "Contents of $TMP_DOWNLOAD_DIR:"
+  verbose "$(ls -la "$TMP_DOWNLOAD_DIR")"
+  die "Could not find Maven distribution directory in extracted archive"
+fi
+
+verbose "Found extracted Maven distribution directory: $actualDistributionDir"
+printf %s\\n "$distributionUrl" >"$TMP_DOWNLOAD_DIR/$actualDistributionDir/mvnw.url"
+mv -- "$TMP_DOWNLOAD_DIR/$actualDistributionDir" "$MAVEN_HOME" || [ -d "$MAVEN_HOME" ] || die "fail to move MAVEN_HOME"
+
+clean || :
+exec_maven "$@"

pom.xml

@@ -15,6 +15,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
+                <version>3.13.0</version>
                 <configuration>
                     <source>16</source>
                     <target>16</target>
@@ -28,7 +29,7 @@
             <plugin>
                 <groupId>org.jacoco</groupId>
                 <artifactId>jacoco-maven-plugin</artifactId>
-                <version>0.8.11</version>
+                <version>0.8.13</version>
                 <executions>
                     <execution>
                         <goals>
@@ -67,16 +68,22 @@
     <version>1.0-SNAPSHOT</version>
 
     <dependencies>
+        <dependency>
+            <groupId>com.fasterxml.jackson.core</groupId>
+            <artifactId>jackson-databind</artifactId>
+            <version>2.18.3</version>
+        </dependency>
+
         <dependency>
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-api</artifactId>
-            <version>RELEASE</version>
+            <version>2.0.16</version>
         </dependency>
 
         <dependency>
             <groupId>ch.qos.logback</groupId>
             <artifactId>logback-classic</artifactId>
-            <version>RELEASE</version>
+            <version>1.5.12</version>
         </dependency>
 
         <dependency>

src/main/java/ovh/gasser/newshapes/App.java

@@ -11,6 +11,8 @@ import ovh.gasser.newshapes.ui.listeners.MenuEditListener;
 
 import javax.swing.*;
 import java.awt.*;
+import java.awt.event.InputEvent;
+import java.awt.event.KeyEvent;
 import java.io.FileNotFoundException;
 
 public class App {
@@ -19,6 +21,8 @@ public class App {
     private SCollection model;
     private JCheckBoxMenuItem editFill;
     private JCheckBoxMenuItem editBorder;
+    private JMenuItem editGroup;
+    private JMenuItem editUngroup;
 
     private App() throws HeadlessException {
         final JFrame frame = new JFrame("Reactive shapes");
@@ -71,12 +75,38 @@ public class App {
 
     private JMenu buildFileMenu(ShapesView sview) {
         JMenu menuFile = new JMenu("File");
+        JMenuItem openItem = new JMenuItem("Open");
+        JMenuItem saveItem = new JMenuItem("Save");
         JMenuItem addRectItem = new JMenuItem("Add SRectangle");
         JMenuItem addCircleItem = new JMenuItem("Add SCircle");
         JMenuItem addTextItem = new JMenuItem("Add Text");
         JMenuItem htmlExportItem = new JMenuItem("Export to HTML");
         JMenuItem svgExportItem = new JMenuItem("Export to SVG");
         JMenuItem exitItem = new JMenuItem("Exit");
+
+        openItem.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_O, InputEvent.CTRL_DOWN_MASK));
+        saveItem.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_S, InputEvent.CTRL_DOWN_MASK));
+
+        openItem.addActionListener(evt -> {
+            JFileChooser chooser = new JFileChooser();
+            chooser.setFileFilter(new javax.swing.filechooser.FileNameExtensionFilter("JSON Files", "json"));
+            if (chooser.showOpenDialog(sview) == JFileChooser.APPROVE_OPTION) {
+                sview.getController().loadDrawing(chooser.getSelectedFile());
+            }
+        });
+
+        saveItem.addActionListener(evt -> {
+            JFileChooser chooser = new JFileChooser();
+            chooser.setFileFilter(new javax.swing.filechooser.FileNameExtensionFilter("JSON Files", "json"));
+            if (chooser.showSaveDialog(sview) == JFileChooser.APPROVE_OPTION) {
+                java.io.File file = chooser.getSelectedFile();
+                if (!file.getName().endsWith(".json")) {
+                    file = new java.io.File(file.getAbsolutePath() + ".json");
+                }
+                sview.getController().saveDrawing(file);
+            }
+        });
+
         addRectItem.addActionListener(new MenuAddListener("SRectangle", model, sview));
         addCircleItem.addActionListener(new MenuAddListener("SCircle", model, sview));
         addTextItem.addActionListener(evt -> sview.getController().enterTextMode());
@@ -95,6 +125,10 @@ public class App {
             }
         });
         exitItem.addActionListener(evt -> System.exit(0));
+
+        menuFile.add(openItem);
+        menuFile.add(saveItem);
+        menuFile.addSeparator();
         menuFile.add(addRectItem);
         menuFile.add(addCircleItem);
         menuFile.add(addTextItem);
@@ -108,32 +142,62 @@ public class App {
     private JMenu buildEditMenu(ShapesView sview) {
         MenuEditListener editListener = new MenuEditListener(model, sview, sview.getController());
         JMenu menuEdit = new JMenu("Edit");
+        JMenuItem cutItem = new JMenuItem("Cut");
+        JMenuItem copyItem = new JMenuItem("Copy");
+        JMenuItem pasteItem = new JMenuItem("Paste");
         JMenuItem editColor = new JMenuItem("Change color");
         JMenuItem editBorderColor = new JMenuItem("Change border color");
         JMenuItem deleteItem = new JMenuItem("Delete");
+        editGroup = new JMenuItem("Group");
+        editUngroup = new JMenuItem("Ungroup");
         editFill = new JCheckBoxMenuItem("Fill Shape");
         editBorder = new JCheckBoxMenuItem("Draw border");
+
+        cutItem.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_X, InputEvent.CTRL_DOWN_MASK));
+        copyItem.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_C, InputEvent.CTRL_DOWN_MASK));
+        pasteItem.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_V, InputEvent.CTRL_DOWN_MASK));
+        editGroup.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_G, InputEvent.CTRL_DOWN_MASK));
+        editUngroup.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_G, InputEvent.CTRL_DOWN_MASK | InputEvent.SHIFT_DOWN_MASK));
+
+        cutItem.addActionListener(evt -> sview.getController().cutSelection());
+        copyItem.addActionListener(evt -> sview.getController().copySelection());
+        pasteItem.addActionListener(evt -> sview.getController().pasteClipboard());
         editColor.addActionListener(editListener);
         editBorderColor.addActionListener(editListener);
         deleteItem.addActionListener(editListener);
+        editGroup.addActionListener(evt -> sview.getController().group());
+        editUngroup.addActionListener(evt -> sview.getController().ungroup());
         editFill.addActionListener(editListener);
         editBorder.addActionListener(editListener);
+        editGroup.setEnabled(false);
+        editUngroup.setEnabled(false);
 
+        menuEdit.add(cutItem);
+        menuEdit.add(copyItem);
+        menuEdit.add(pasteItem);
+        menuEdit.addSeparator();
         menuEdit.add(editColor);
         menuEdit.add(editBorderColor);
         menuEdit.add(deleteItem);
         menuEdit.addSeparator();
+        menuEdit.add(editGroup);
+        menuEdit.add(editUngroup);
+        menuEdit.addSeparator();
         menuEdit.add(editBorder);
         menuEdit.add(editFill);
         return menuEdit;
     }
 
     private void updateMenuState(Iterable<Shape> selectedShapes) {
+        int selectionCount = 0;
+        boolean singleCollectionSelected = false;
         boolean hasToggleableShapes = false;
         boolean allFilled = true;
         boolean allStroked = true;
 
         for (Shape s : selectedShapes) {
+            selectionCount++;
+            singleCollectionSelected = selectionCount == 1 && s instanceof SCollection;
             if (s instanceof SText) {
                 continue;
             }
@@ -145,6 +209,8 @@ public class App {
             }
         }
 
+        editGroup.setEnabled(selectionCount > 1);
+        editUngroup.setEnabled(selectionCount == 1 && singleCollectionSelected);
         updateMenuItem(editFill, hasToggleableShapes, allFilled);
         updateMenuItem(editBorder, hasToggleableShapes, allStroked);
     }

src/main/java/ovh/gasser/newshapes/persistence/DrawingSerializer.java

@@ -0,0 +1,43 @@
+package ovh.gasser.newshapes.persistence;
+
+import com.fasterxml.jackson.core.Version;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.module.SimpleModule;
+import ovh.gasser.newshapes.shapes.SCollection;
+import ovh.gasser.newshapes.shapes.Shape;
+
+import java.io.File;
+import java.io.IOException;
+
+public class DrawingSerializer {
+    private static final String VERSION = "1.0";
+    private final ObjectMapper mapper;
+
+    public DrawingSerializer() {
+        this.mapper = new ObjectMapper();
+        SimpleModule module = new SimpleModule("ShapeModule", new Version(1, 0, 0, null, null, null));
+        module.addSerializer(Shape.class, new ShapeSerializer());
+        module.addDeserializer(Shape.class, new ShapeDeserializer());
+        this.mapper.registerModule(module);
+    }
+
+    public void save(SCollection model, File file) throws IOException {
+        DrawingData data = new DrawingData();
+        data.version = VERSION;
+        data.shapes = new java.util.ArrayList<>();
+        for (Shape shape : model) {
+            data.shapes.add(shape);
+        }
+        mapper.writerWithDefaultPrettyPrinter().writeValue(file, data);
+    }
+
+    public SCollection load(File file) throws IOException {
+        DrawingData data = mapper.readValue(file, DrawingData.class);
+        return SCollection.of(data.shapes.toArray(new Shape[0]));
+    }
+
+    public static class DrawingData {
+        public String version;
+        public java.util.List<Shape> shapes;
+    }
+}

src/main/java/ovh/gasser/newshapes/persistence/ShapeDeserializer.java

@@ -0,0 +1,159 @@
+package ovh.gasser.newshapes.persistence;
+
+import com.fasterxml.jackson.core.JsonParser;
+import com.fasterxml.jackson.databind.DeserializationContext;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
+import ovh.gasser.newshapes.shapes.SCircle;
+import ovh.gasser.newshapes.shapes.SCollection;
+import ovh.gasser.newshapes.shapes.SPolygon;
+import ovh.gasser.newshapes.shapes.SRectangle;
+import ovh.gasser.newshapes.shapes.SText;
+import ovh.gasser.newshapes.shapes.STriangle;
+import ovh.gasser.newshapes.shapes.Shape;
+
+import java.awt.*;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class ShapeDeserializer extends StdDeserializer<Shape> {
+
+    public ShapeDeserializer() {
+        super(Shape.class);
+    }
+
+    @Override
+    public Shape deserialize(JsonParser p, DeserializationContext ctxt) throws IOException {
+        JsonNode node = p.getCodec().readTree(p);
+        String type = node.get("type").asText();
+
+        return switch (type) {
+            case "rectangle" -> deserializeRectangle(node);
+            case "circle" -> deserializeCircle(node);
+            case "triangle" -> deserializeTriangle(node);
+            case "text" -> deserializeText(node);
+            case "polygon" -> deserializePolygon(node);
+            case "collection" -> deserializeCollection(node, p, ctxt);
+            default -> throw new IllegalArgumentException("Unknown shape type: " + type);
+        };
+    }
+
+    private SRectangle deserializeRectangle(JsonNode node) {
+        int x = node.get("x").asInt();
+        int y = node.get("y").asInt();
+        int width = node.get("width").asInt();
+        int height = node.get("height").asInt();
+
+        Color strokeColor = extractStrokeColor(node);
+        return SRectangle.create(x, y, width, height, strokeColor);
+    }
+
+    private SCircle deserializeCircle(JsonNode node) {
+        int x = node.get("x").asInt();
+        int y = node.get("y").asInt();
+        int radius = node.get("radius").asInt();
+
+        Color strokeColor = extractStrokeColor(node);
+        Color fillColor = extractFillColor(node);
+
+        SCircle circle = SCircle.create(x + radius, y + radius, radius);
+        circle.addAttributes(new ovh.gasser.newshapes.attributes.ColorAttributes(
+                fillColor != null, strokeColor != null, strokeColor, fillColor));
+        return circle;
+    }
+
+    private STriangle deserializeTriangle(JsonNode node) {
+        int x = node.get("x").asInt();
+        int y = node.get("y").asInt();
+        int size = node.get("size").asInt();
+
+        Color strokeColor = extractStrokeColor(node);
+        Color fillColor = extractFillColor(node);
+
+        return STriangle.create(x, y, size, fillColor != null ? fillColor : Color.YELLOW,
+                strokeColor != null ? strokeColor : Color.BLACK);
+    }
+
+    private SText deserializeText(JsonNode node) {
+        int x = node.get("x").asInt();
+        int y = node.get("y").asInt();
+        String text = node.get("text").asText();
+
+        Color strokeColor = extractStrokeColor(node);
+
+        SText sText = SText.create(x, y, text);
+        if (strokeColor != null) {
+            sText.addAttributes(new ovh.gasser.newshapes.attributes.ColorAttributes(
+                    true, true, strokeColor, strokeColor));
+        }
+        return sText;
+    }
+
+    private SPolygon deserializePolygon(JsonNode node) {
+        List<Point> points = new ArrayList<>();
+        JsonNode pointsNode = node.get("points");
+        for (JsonNode pointNode : pointsNode) {
+            int x = pointNode.get("x").asInt();
+            int y = pointNode.get("y").asInt();
+            points.add(new Point(x, y));
+        }
+
+        Color strokeColor = extractStrokeColor(node);
+        Color fillColor = extractFillColor(node);
+
+        SPolygon poly = SPolygon.create(points);
+        if (strokeColor != null || fillColor != null) {
+            poly.addAttributes(new ovh.gasser.newshapes.attributes.ColorAttributes(
+                    fillColor != null, strokeColor != null,
+                    strokeColor != null ? strokeColor : Color.BLACK,
+                    fillColor != null ? fillColor : Color.BLACK));
+        }
+        return poly;
+    }
+
+    private SCollection deserializeCollection(JsonNode node, JsonParser p, DeserializationContext ctxt) throws IOException {
+        List<Shape> children = new ArrayList<>();
+        JsonNode shapesNode = node.get("shapes");
+        if (shapesNode != null && shapesNode.isArray()) {
+            for (JsonNode childNode : shapesNode) {
+                JsonParser childParser = childNode.traverse(p.getCodec());
+                children.add(deserialize(childParser, ctxt));
+            }
+        }
+        return SCollection.of(children.toArray(new Shape[0]));
+    }
+
+    private Color extractStrokeColor(JsonNode node) {
+        if (node.has("color")) {
+            JsonNode colorNode = node.get("color");
+            if (colorNode.has("stroked") && colorNode.get("stroked").asBoolean()) {
+                return hexToColor(colorNode.get("strokedColor").asText());
+            }
+        }
+        return null;
+    }
+
+    private Color extractFillColor(JsonNode node) {
+        if (node.has("color")) {
+            JsonNode colorNode = node.get("color");
+            if (colorNode.has("filled") && colorNode.get("filled").asBoolean()) {
+                return hexToColor(colorNode.get("filledColor").asText());
+            }
+        }
+        return null;
+    }
+
+    private Color hexToColor(String hex) {
+        if (hex == null || hex.isEmpty()) return Color.BLACK;
+        try {
+            return new Color(
+                    Integer.parseInt(hex.substring(1, 3), 16),
+                    Integer.parseInt(hex.substring(3, 5), 16),
+                    Integer.parseInt(hex.substring(5, 7), 16)
+            );
+        } catch (Exception e) {
+            return Color.BLACK;
+        }
+    }
+}

src/main/java/ovh/gasser/newshapes/persistence/ShapeSerializer.java

@@ -0,0 +1,121 @@
+package ovh.gasser.newshapes.persistence;
+
+import com.fasterxml.jackson.core.JsonGenerator;
+import com.fasterxml.jackson.databind.JsonSerializer;
+import com.fasterxml.jackson.databind.SerializerProvider;
+import ovh.gasser.newshapes.attributes.ColorAttributes;
+import ovh.gasser.newshapes.shapes.SCircle;
+import ovh.gasser.newshapes.shapes.SCollection;
+import ovh.gasser.newshapes.shapes.SPolygon;
+import ovh.gasser.newshapes.shapes.SRectangle;
+import ovh.gasser.newshapes.shapes.SText;
+import ovh.gasser.newshapes.shapes.STriangle;
+import ovh.gasser.newshapes.shapes.Shape;
+
+import java.awt.*;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class ShapeSerializer extends JsonSerializer<Shape> {
+
+    @Override
+    public void serialize(Shape shape, JsonGenerator gen, SerializerProvider serializers) throws IOException {
+        gen.writeStartObject();
+
+        if (shape instanceof SRectangle rect) {
+            gen.writeStringField("type", "rectangle");
+            writeRectangle(rect, gen);
+        } else if (shape instanceof SCircle circle) {
+            gen.writeStringField("type", "circle");
+            writeCircle(circle, gen);
+        } else if (shape instanceof STriangle tri) {
+            gen.writeStringField("type", "triangle");
+            writeTriangle(tri, gen);
+        } else if (shape instanceof SText text) {
+            gen.writeStringField("type", "text");
+            writeText(text, gen);
+        } else if (shape instanceof SPolygon poly) {
+            gen.writeStringField("type", "polygon");
+            writePolygon(poly, gen);
+        } else if (shape instanceof SCollection coll) {
+            gen.writeStringField("type", "collection");
+            writeCollection(coll, gen);
+        }
+
+        gen.writeEndObject();
+    }
+
+    private void writeRectangle(SRectangle rect, JsonGenerator gen) throws IOException {
+        Rectangle bounds = rect.getBounds();
+        gen.writeNumberField("x", bounds.x);
+        gen.writeNumberField("y", bounds.y);
+        gen.writeNumberField("width", bounds.width);
+        gen.writeNumberField("height", bounds.height);
+        writeColorAttributes(rect, gen);
+    }
+
+    private void writeCircle(SCircle circle, JsonGenerator gen) throws IOException {
+        Rectangle bounds = circle.getBounds();
+        gen.writeNumberField("x", bounds.x);
+        gen.writeNumberField("y", bounds.y);
+        gen.writeNumberField("radius", circle.getRadius());
+        writeColorAttributes(circle, gen);
+    }
+
+    private void writeTriangle(STriangle tri, JsonGenerator gen) throws IOException {
+        Rectangle bounds = tri.getBounds();
+        gen.writeNumberField("x", bounds.x);
+        gen.writeNumberField("y", bounds.y);
+        gen.writeNumberField("size", bounds.width);
+        writeColorAttributes(tri, gen);
+    }
+
+    private void writeText(SText text, JsonGenerator gen) throws IOException {
+        Rectangle bounds = text.getBounds();
+        gen.writeNumberField("x", bounds.x);
+        gen.writeNumberField("y", bounds.y);
+        gen.writeStringField("text", text.getText());
+        gen.writeStringField("fontName", text.getFontName());
+        gen.writeNumberField("fontSize", text.getFontSize());
+        gen.writeNumberField("fontStyle", text.getFontStyle());
+        writeColorAttributes(text, gen);
+    }
+
+    private void writePolygon(SPolygon poly, JsonGenerator gen) throws IOException {
+        gen.writeArrayFieldStart("points");
+        for (Point p : poly.getPoints()) {
+            gen.writeStartObject();
+            gen.writeNumberField("x", p.x);
+            gen.writeNumberField("y", p.y);
+            gen.writeEndObject();
+        }
+        gen.writeEndArray();
+        writeColorAttributes(poly, gen);
+    }
+
+    private void writeCollection(SCollection coll, JsonGenerator gen) throws IOException {
+        gen.writeArrayFieldStart("shapes");
+        for (Shape child : coll) {
+            serialize(child, gen, null);
+        }
+        gen.writeEndArray();
+    }
+
+    private void writeColorAttributes(Shape shape, JsonGenerator gen) throws IOException {
+        ColorAttributes attrs = (ColorAttributes) shape.getAttributes(ColorAttributes.ID);
+        if (attrs != null) {
+            gen.writeObjectFieldStart("color");
+            gen.writeBooleanField("filled", attrs.filled);
+            gen.writeBooleanField("stroked", attrs.stroked);
+            gen.writeStringField("filledColor", colorToHex(attrs.filledColor));
+            gen.writeStringField("strokedColor", colorToHex(attrs.strokedColor));
+            gen.writeEndObject();
+        }
+    }
+
+    private String colorToHex(Color c) {
+        if (c == null) return "#000000";
+        return String.format("#%02x%02x%02x", c.getRed(), c.getGreen(), c.getBlue());
+    }
+}

src/main/java/ovh/gasser/newshapes/ui/Controller.java

@@ -5,6 +5,15 @@ import org.slf4j.LoggerFactory;
 import ovh.gasser.newshapes.HTMLExporter;
 import ovh.gasser.newshapes.Selection;
 import ovh.gasser.newshapes.attributes.ColorAttributes;
+import ovh.gasser.newshapes.persistence.DrawingSerializer;
+import ovh.gasser.newshapes.command.AddShapeCommand;
+import ovh.gasser.newshapes.command.ChangeColorCommand;
+import ovh.gasser.newshapes.command.Command;
+import ovh.gasser.newshapes.command.CommandHistory;
+import ovh.gasser.newshapes.command.CommandHistoryListener;
+import ovh.gasser.newshapes.command.MoveShapeCommand;
+import ovh.gasser.newshapes.command.RemoveShapeCommand;
+import ovh.gasser.newshapes.command.ResizeShapeCommand;
 import ovh.gasser.newshapes.shapes.ResizeHandle;
 import ovh.gasser.newshapes.shapes.SCollection;
 import ovh.gasser.newshapes.shapes.SText;
@@ -13,18 +22,28 @@ import ovh.gasser.newshapes.ui.listeners.SelectionListener;
 
 import javax.swing.*;
 import java.awt.*;
+import java.awt.event.InputEvent;
 import java.awt.event.KeyAdapter;
 import java.awt.event.KeyEvent;
 import java.awt.event.MouseAdapter;
 import java.awt.event.MouseEvent;
 import java.io.FileNotFoundException;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.LinkedHashMap;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Map;
 import java.util.Optional;
+import java.util.function.Function;
 
 public class Controller {
-    private final static Logger logger = LoggerFactory.getLogger(Controller.class);
+    private static final Logger logger = LoggerFactory.getLogger(Controller.class);
+
     private final ShapesView view;
     private final SCollection model;
     private final Selection selection;
+    private final CommandHistory commandHistory;
 
     private Point lastMousePos;
     private boolean addingText;
@@ -35,11 +54,24 @@ public class Controller {
     private Point selectionBoxStart;
     private Point selectionBoxEnd;
     private boolean boxSelecting;
+    private Point dragStartMousePos;
+    private Map<Shape, Rectangle> dragStartBounds = Map.of();
+    private final Runnable onModelChanged;
+    private java.util.List<Shape> clipboard = java.util.List.of();
+    private int pasteCount = 0;
+    private static final int PASTE_OFFSET = 20;
+    private boolean additiveBoxSelection;
 
     Controller(ShapesView view, SCollection model) {
+        this(view, model, () -> { });
+    }
+
+    Controller(ShapesView view, SCollection model, Runnable onModelChanged) {
         this.view = view;
         this.model = model;
+        this.onModelChanged = onModelChanged;
         this.selection = new Selection();
+        this.commandHistory = new CommandHistory();
 
         var adapter = new MouseAdapter() {
             @Override
@@ -54,14 +86,7 @@ public class Controller {
 
             @Override
             public void mouseReleased(MouseEvent evt) {
-                resizing = false;
+                handleMouseReleased(evt);
-                activeHandle = null;
-                resizeOrigin = null;
-                boxSelecting = false;
-                selectionBoxStart = null;
-                selectionBoxEnd = null;
-                view.setCurrentSelectionBox(null);
-                view.repaint();
             }
         };
         this.view.addMouseMotionListener(adapter);
@@ -74,6 +99,249 @@ public class Controller {
         });
     }
 
+    public void addShape(Shape shape) {
+        executeAndRefresh(new AddShapeCommand(model, shape));
+    }
+
+    public void addSelectionChangeListener(SelectionListener listener) {
+        selection.addListener(listener);
+    }
+
+    public void addHistoryChangeListener(CommandHistoryListener listener) {
+        commandHistory.addListener(listener);
+    }
+
+    public boolean canUndo() {
+        return commandHistory.canUndo();
+    }
+
+    public boolean canRedo() {
+        return commandHistory.canRedo();
+    }
+
+    public void undo() {
+        if (!commandHistory.canUndo()) {
+            return;
+        }
+
+        resetSelection();
+        commandHistory.undo();
+        view.repaint();
+    }
+
+    public void redo() {
+        if (!commandHistory.canRedo()) {
+            return;
+        }
+
+        resetSelection();
+        commandHistory.redo();
+        view.repaint();
+    }
+
+    public void saveDrawing(java.io.File file) {
+        try {
+            new DrawingSerializer().save(model, file);
+            logger.info("Saved drawing to {}", file.getAbsolutePath());
+        } catch (java.io.IOException e) {
+            logger.error("Failed to save drawing: {}", e.getMessage());
+            JOptionPane.showMessageDialog(view, "Failed to save: " + e.getMessage(), "Save Error", JOptionPane.ERROR_MESSAGE);
+        }
+    }
+
+    public void loadDrawing(java.io.File file) {
+        try {
+            SCollection loaded = new DrawingSerializer().load(file);
+            model.stream().toList().forEach(model::remove);
+            loaded.forEach(model::add);
+            resetSelection();
+            view.repaint();
+            logger.info("Loaded drawing from {}", file.getAbsolutePath());
+        } catch (java.io.IOException e) {
+            logger.error("Failed to load drawing: {}", e.getMessage());
+            JOptionPane.showMessageDialog(view, "Failed to load: " + e.getMessage(), "Load Error", JOptionPane.ERROR_MESSAGE);
+        }
+    }
+
+    public void enterTextMode() {
+        addingText = true;
+    }
+
+    public void deleteSelected() {
+        List<Shape> selectedShapes = selection.getSelectedShapes();
+        if (selectedShapes.isEmpty()) {
+            return;
+        }
+
+        logger.debug("Deleting selected shape(s)");
+        executeAndRefresh(new RemoveShapeCommand(model, selectedShapes));
+        resetSelection();
+    }
+
+    public void copySelection() {
+        List<Shape> selectedShapes = selection.getSelectedShapes();
+        if (selectedShapes.isEmpty()) {
+            logger.debug("No selection to copy");
+            return;
+        }
+
+        clipboard = selectedShapes.stream()
+                .map(Shape::clone)
+                .toList();
+        pasteCount = 0;
+    }
+
+    public void cutSelection() {
+        List<Shape> selectedShapes = selection.getSelectedShapes();
+        if (selectedShapes.isEmpty()) {
+            logger.debug("No selection to cut");
+            return;
+        }
+
+        clipboard = selectedShapes.stream()
+                .map(Shape::clone)
+                .toList();
+        pasteCount = 0;
+
+        for (Shape shape : selectedShapes) {
+            model.remove(shape);
+        }
+        resetSelection();
+        onModelChanged.run();
+        view.repaint();
+    }
+
+    public void pasteClipboard() {
+        if (clipboard.isEmpty()) {
+            logger.debug("Clipboard is empty");
+            return;
+        }
+
+        pasteCount++;
+        int offset = PASTE_OFFSET * pasteCount;
+
+        resetSelection();
+
+        for (Shape original : clipboard) {
+            Shape clone = original.clone();
+            clone.translate(offset, offset);
+            model.add(clone);
+            selection.add(clone);
+        }
+
+        onModelChanged.run();
+        view.repaint();
+    }
+
+    public void group() {
+        List<Shape> selectedShapes = selection.getSelectedShapes();
+        if (selectedShapes.size() < 2) {
+            logger.debug("Need at least 2 shapes to group");
+            return;
+        }
+
+        int minIndex = selectedShapes.stream()
+                .mapToInt(model::indexOf)
+                .min()
+                .orElse(0);
+
+        for (Shape shape : selectedShapes) {
+            model.remove(shape);
+            shape.addAttributes(new ovh.gasser.newshapes.attributes.SelectionAttributes(false));
+        }
+
+        Shape[] shapesArray = selectedShapes.toArray(new Shape[0]);
+        SCollection group = SCollection.of(shapesArray);
+
+        model.insert(minIndex, group);
+        resetSelection();
+        selection.add(group);
+        onModelChanged.run();
+        view.repaint();
+    }
+
+    public void ungroup() {
+        List<Shape> selectedShapes = selection.getSelectedShapes();
+        if (selectedShapes.size() != 1) {
+            logger.debug("Can only ungroup a single selected group");
+            return;
+        }
+
+        Shape selected = selectedShapes.get(0);
+        if (!(selected instanceof SCollection group)) {
+            logger.debug("Selected shape is not a group");
+            return;
+        }
+
+        List<Shape> children = new ArrayList<>();
+        group.forEach(children::add);
+
+        model.remove(group);
+
+        for (Shape child : children) {
+            model.add(child);
+        }
+
+        resetSelection();
+        for (Shape child : children) {
+            selection.add(child);
+        }
+        onModelChanged.run();
+        view.repaint();
+    }
+
+    public void changeSelectionColor() {
+        changeColors(shape -> new ColorAttributes(false, true, Color.BLACK, randomColor()));
+    }
+
+    public void changeSelectionFillColor(Color filledColor) {
+        if (filledColor == null) {
+            return;
+        }
+
+        changeColors(shape -> {
+            ColorAttributes current = currentColor(shape);
+            if (shape instanceof SText) {
+                return new ColorAttributes(current.filled, current.stroked, filledColor, filledColor);
+            }
+            return new ColorAttributes(true, current.stroked, filledColor, current.strokedColor);
+        });
+    }
+
+    public void changeSelectionBorderColor(Color strokedColor) {
+        if (strokedColor == null) {
+            return;
+        }
+
+        changeColors(shape -> {
+            ColorAttributes current = currentColor(shape);
+            if (shape instanceof SText) {
+                return new ColorAttributes(current.filled, current.stroked, strokedColor, strokedColor);
+            }
+            return new ColorAttributes(current.filled, true, current.filledColor, strokedColor);
+        });
+    }
+
+    public void setSelectionBorder(boolean state) {
+        changeColors(shape -> {
+            if (shape instanceof SText) {
+                return null;
+            }
+            ColorAttributes current = currentColor(shape);
+            return new ColorAttributes(current.filled, state, current.filledColor, current.strokedColor);
+        });
+    }
+
+    public void setSelectionFilled(boolean state) {
+        changeColors(shape -> {
+            if (shape instanceof SText) {
+                return null;
+            }
+            ColorAttributes current = currentColor(shape);
+            return new ColorAttributes(state, current.stroked, current.filledColor, current.strokedColor);
+        });
+    }
+
     private void handleMouseDragged(MouseEvent evt) {
         if (boxSelecting) {
             selectionBoxEnd = evt.getPoint();
@@ -84,35 +352,19 @@ public class Controller {
             return;
         }
 
-        boxSelecting = false;
-
         if (resizeMode && resizing && activeHandle != null) {
-            logger.debug("RESIZING with handle {} at ({}, {})", activeHandle, evt.getX(), evt.getY());
             int dx = evt.getX() - resizeOrigin.x;
             int dy = evt.getY() - resizeOrigin.y;
-            logger.debug("About to resize {} shapes, dx={}, dy={}", selection.getSelectedShapes().size(), dx, dy);
             for (Shape shape : selection) {
-                logger.debug("Calling resize on shape: {}", shape);
                 shape.resize(activeHandle, dx, dy);
             }
             resizeOrigin = evt.getPoint();
-        } else if (resizeMode && !selection.isEmpty()) {
+        } else if (!selection.isEmpty()) {
-            lastMousePos = evt.getPoint();
-            ResizeHandle handle = getHandleAt(evt.getPoint());
-            if (handle != null) {
-                resizing = true;
-                activeHandle = handle;
-                resizeOrigin = evt.getPoint();
-            }
-        } else {
-            resizing = false;
-            activeHandle = null;
             if (lastMousePos == null) {
                 lastMousePos = evt.getPoint();
             }
             int dx = evt.getX() - lastMousePos.x;
             int dy = evt.getY() - lastMousePos.y;
-            logger.debug("MOVING shapes with delta ({}, {})", dx, dy);
             for (Shape shape : selection) {
                 shape.translate(dx, dy);
             }
@@ -127,18 +379,17 @@ public class Controller {
             return;
         }
 
-        resizing = false;
+        resizeDragState();
-        activeHandle = null;
+        boxSelecting = false;
-        resizeOrigin = null;
+        view.setCurrentSelectionBox(null);
-        boxSelecting = false; // Clear box selection mode when clicking
 
         if (resizeMode && !selection.isEmpty()) {
             ResizeHandle handle = getHandleAt(evt.getPoint());
-            logger.debug("In resize mode, checking handle at ({}, {}): {}", evt.getX(), evt.getY(), handle);
             if (handle != null) {
                 resizing = true;
                 activeHandle = handle;
                 resizeOrigin = evt.getPoint();
+                beginDrag(evt.getPoint());
                 view.repaint();
                 return;
             }
@@ -151,96 +402,86 @@ public class Controller {
                                 resetSelection();
                             }
                             if (!selection.getSelectedShapes().contains(s)) {
-                                lastMousePos = evt.getPoint();
                                 selection.add(s);
-                                logger.debug("Selecting {}", s);
                             }
+                            beginDrag(evt.getPoint());
                         },
                         () -> {
-                            // Clicked on empty space - start box selection
+                            additiveBoxSelection = evt.isShiftDown();
+                            if (!additiveBoxSelection) {
                                 resetSelection();
+                            }
                             selectionBoxStart = evt.getPoint();
+                            selectionBoxEnd = evt.getPoint();
                             boxSelecting = true;
+                            dragStartMousePos = null;
+                            dragStartBounds = Map.of();
                         }
                 );
     }
 
-    private void placeTextAt(Point point) {
+    private void handleMouseReleased(MouseEvent evt) {
-        String input = JOptionPane.showInputDialog(view, "Enter text:", "Add text", JOptionPane.PLAIN_MESSAGE);
+        finishDragCommand();
-        addingText = false;
+        resizeDragState();
-        if (input == null) {
+        boxSelecting = false;
-            return;
+        selectionBoxStart = null;
-        }
+        selectionBoxEnd = null;
-
+        dragStartMousePos = null;
-        model.add(SText.create(point.x, point.y, input));
+        dragStartBounds = Map.of();
-        resetSelection();
+        view.setCurrentSelectionBox(null);
         view.repaint();
     }
 
-    public void enterTextMode() {
-        addingText = true;
-    }
-
-    private ResizeHandle getHandleAt(Point point) {
-        final int handleSize = 10;
-        for (Shape shape : selection) {
-            Rectangle bounds = shape.getBounds();
-            
-            // Always-present SE corner handle
-            if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
-                point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
-                return ResizeHandle.SE;
-            }
-
-            // Resize handles are only active in resize mode
-            if (resizeMode) {
-                // NW corner
-                if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
-                    point.y >= bounds.y - handleSize && point.y <= bounds.y) {
-                    return ResizeHandle.NW;
-                }
-                // NE corner
-                if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
-                    point.y >= bounds.y - handleSize && point.y <= bounds.y) {
-                    return ResizeHandle.NE;
-                }
-                // SW corner
-                if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
-                    point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
-                    return ResizeHandle.SW;
-                }
-                // N edge
-                int edgeX = bounds.x + bounds.width / 2 - handleSize / 2;
-                if (point.x >= edgeX && point.x <= edgeX + handleSize &&
-                    point.y >= bounds.y - handleSize && point.y <= bounds.y) {
-                    return ResizeHandle.N;
-                }
-                // S edge
-                if (point.x >= edgeX && point.x <= edgeX + handleSize &&
-                    point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
-                    return ResizeHandle.S;
-                }
-                // W edge
-                int edgeY = bounds.y + bounds.height / 2 - handleSize / 2;
-                if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
-                    point.y >= edgeY && point.y <= edgeY + handleSize) {
-                    return ResizeHandle.W;
-                }
-                // E edge
-                if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
-                    point.y >= edgeY && point.y <= edgeY + handleSize) {
-                    return ResizeHandle.E;
-                }
-            }
-        }
-        return null;
-    }
-
     private void handleKeyPressed(KeyEvent evt) {
+        int modifiers = evt.getModifiersEx();
+
+        if ((modifiers & InputEvent.CTRL_DOWN_MASK) != 0) {
+            switch (evt.getKeyCode()) {
+                case KeyEvent.VK_Z -> {
+                    if ((modifiers & InputEvent.SHIFT_DOWN_MASK) != 0) {
+                        redo();
+                    } else {
+                        undo();
+                    }
+                    evt.consume();
+                    return;
+                }
+                case KeyEvent.VK_Y -> {
+                    redo();
+                    evt.consume();
+                    return;
+                }
+                case KeyEvent.VK_C -> {
+                    copySelection();
+                    evt.consume();
+                    return;
+                }
+                case KeyEvent.VK_X -> {
+                    cutSelection();
+                    evt.consume();
+                    return;
+                }
+                case KeyEvent.VK_V -> {
+                    pasteClipboard();
+                    evt.consume();
+                    return;
+                }
+                case KeyEvent.VK_G -> {
+                    group();
+                    evt.consume();
+                    return;
+                }
+                case KeyEvent.VK_U -> {
+                    ungroup();
+                    evt.consume();
+                    return;
+                }
+            }
+        }
+
         switch (evt.getKeyCode()) {
             case KeyEvent.VK_R -> toggleResizeMode();
             case KeyEvent.VK_DELETE -> deleteSelected();
-            case KeyEvent.VK_C -> copySelection();
             case KeyEvent.VK_A -> changeSelectionColor();
             case KeyEvent.VK_H -> exportHtml();
             default -> logger.warn("Pressed unhandled key: {}", evt.getKeyChar());
@@ -264,55 +505,134 @@ public class Controller {
         }
     }
 
-    private void changeSelectionColor(){
+    private void placeTextAt(Point point) {
-        if (selection == null) {
+        String input = JOptionPane.showInputDialog(view, "Enter text:", "Add text", JOptionPane.PLAIN_MESSAGE);
-            logger.debug("No selection to change color of");
+        addingText = false;
+        if (input == null) {
             return;
         }
 
-        for (Shape s : selection) {
+        addShape(SText.create(point.x, point.y, input));
-            if (s instanceof SCollection collection) {
-                collection.forEach(shape -> shape.addAttributes(new ColorAttributes(false, true, Color.BLACK, new Color((int) (Math.random() * 0x1000000)))));
-            } else {
-                s.addAttributes(new ColorAttributes(false, true, Color.BLACK, new Color((int) (Math.random() * 0x1000000))));
-            }
-        }
-
-        view.repaint();
-    }
-
-    private void copySelection() {
-        if (selection == null) {
-            logger.debug("No selection to copy");
-            return;
-        }
-
-        for (Shape shape : selection) {
-            this.model.add(shape.clone());
-        }
-
-        view.repaint();
-    }
-
-    public void deleteSelected() {
-        if (selection == null) return;
-        logger.debug("Deleting selected shape(s)");
-        for (Shape s : selection) {
-            this.model.remove(s);
-        }
         resetSelection();
+    }
+
+    private ResizeHandle getHandleAt(Point point) {
+        final int handleSize = 10;
+        for (Shape shape : selection) {
+            Rectangle bounds = shape.getBounds();
+
+            if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
+                    point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
+                return ResizeHandle.SE;
+            }
+
+            if (resizeMode) {
+                if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
+                        point.y >= bounds.y - handleSize && point.y <= bounds.y) {
+                    return ResizeHandle.NW;
+                }
+                if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
+                        point.y >= bounds.y - handleSize && point.y <= bounds.y) {
+                    return ResizeHandle.NE;
+                }
+                if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
+                        point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
+                    return ResizeHandle.SW;
+                }
+                int edgeX = bounds.x + bounds.width / 2 - handleSize / 2;
+                if (point.x >= edgeX && point.x <= edgeX + handleSize &&
+                        point.y >= bounds.y - handleSize && point.y <= bounds.y) {
+                    return ResizeHandle.N;
+                }
+                if (point.x >= edgeX && point.x <= edgeX + handleSize &&
+                        point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
+                    return ResizeHandle.S;
+                }
+                int edgeY = bounds.y + bounds.height / 2 - handleSize / 2;
+                if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
+                        point.y >= edgeY && point.y <= edgeY + handleSize) {
+                    return ResizeHandle.W;
+                }
+                if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
+                        point.y >= edgeY && point.y <= edgeY + handleSize) {
+                    return ResizeHandle.E;
+                }
+            }
+        }
+        return null;
+    }
+
+    private void changeColors(Function<Shape, ColorAttributes> updater) {
+        Map<Shape, ColorAttributes> before = new LinkedHashMap<>();
+        Map<Shape, ColorAttributes> after = new LinkedHashMap<>();
+        List<Shape> targets = flattenSelection(selection.getSelectedShapes());
+
+        for (Shape shape : targets) {
+            ColorAttributes current = currentColor(shape);
+            if (current == null) {
+                continue;
+            }
+
+            ColorAttributes updated = updater.apply(shape);
+            if (updated == null || sameColor(current, updated)) {
+                continue;
+            }
+
+            before.put(shape, copy(current));
+            after.put(shape, copy(updated));
+        }
+
+        if (before.isEmpty()) {
+            return;
+        }
+
+        executeAndRefresh(new ChangeColorCommand(before.keySet(), before, after));
+    }
+
+    private void beginDrag(Point point) {
+        lastMousePos = point;
+        dragStartMousePos = point;
+        dragStartBounds = captureBounds(selection.getSelectedShapes());
+    }
+
+    private void finishDragCommand() {
+        if (boxSelecting || dragStartBounds.isEmpty()) {
+            return;
+        }
+
+        List<Shape> selectedShapes = selection.getSelectedShapes();
+        if (selectedShapes.isEmpty()) {
+            return;
+        }
+
+        if (resizing && boundsChanged(selectedShapes, dragStartBounds)) {
+            Map<Shape, Rectangle> afterBounds = captureBounds(selectedShapes);
+            Command command = new ResizeShapeCommand(selectedShapes, dragStartBounds, afterBounds);
+            command.undo();
+            executeAndRefresh(command);
+            return;
+        }
+
+        if (boundsChanged(selectedShapes, dragStartBounds)) {
+            Shape reference = selectedShapes.get(0);
+            Rectangle before = dragStartBounds.get(reference);
+            Rectangle after = reference.getBounds();
+            Command command = new MoveShapeCommand(selectedShapes, after.x - before.x, after.y - before.y);
+            command.undo();
+            executeAndRefresh(command);
+        }
+    }
+
+    private void executeAndRefresh(Command command) {
+        commandHistory.execute(command);
+        onModelChanged.run();
         view.repaint();
     }
 
     private void resetSelection() {
-        logger.debug("Resetting selection");
         selection.clear();
     }
 
-    public void addSelectionChangeListener(SelectionListener listener) {
-        selection.addListener(listener);
-    }
-
     private Optional<Shape> getTarget(MouseEvent evt, SCollection sc) {
         return sc.stream()
                 .filter(s -> s.getBounds().contains(evt.getPoint()))
@@ -328,9 +648,71 @@ public class Controller {
     }
 
     private void updateSelectionFromBox(Rectangle box) {
+        if (!additiveBoxSelection) {
             resetSelection();
+        }
         model.stream()
                 .filter(s -> s.getBounds().intersects(box))
                 .forEach(selection::add);
     }
+
+    private void resizeDragState() {
+        resizing = false;
+        activeHandle = null;
+        resizeOrigin = null;
+        lastMousePos = null;
+    }
+
+    private Map<Shape, Rectangle> captureBounds(Collection<Shape> shapes) {
+        Map<Shape, Rectangle> bounds = new LinkedHashMap<>();
+        for (Shape shape : shapes) {
+            bounds.put(shape, shape.getBounds());
+        }
+        return bounds;
+    }
+
+    private boolean boundsChanged(Collection<Shape> shapes, Map<Shape, Rectangle> before) {
+        for (Shape shape : shapes) {
+            Rectangle previous = before.get(shape);
+            if (previous != null && !previous.equals(shape.getBounds())) {
+                return true;
+            }
+        }
+        return false;
+    }
+
+    private List<Shape> flattenSelection(Collection<Shape> selectedShapes) {
+        LinkedHashSet<Shape> flattened = new LinkedHashSet<>();
+        for (Shape shape : selectedShapes) {
+            flattenShape(shape, flattened);
+        }
+        return new ArrayList<>(flattened);
+    }
+
+    private void flattenShape(Shape shape, Collection<Shape> flattened) {
+        if (shape instanceof SCollection collection) {
+            collection.forEach(child -> flattenShape(child, flattened));
+            return;
+        }
+        flattened.add(shape);
+    }
+
+    private ColorAttributes currentColor(Shape shape) {
+        return (ColorAttributes) shape.getAttributes(ColorAttributes.ID);
+    }
+
+    private ColorAttributes copy(ColorAttributes attrs) {
+        return new ColorAttributes(attrs.filled, attrs.stroked, attrs.filledColor, attrs.strokedColor);
+    }
+
+    private boolean sameColor(ColorAttributes left, ColorAttributes right) {
+        return left.filled == right.filled
+                && left.stroked == right.stroked
+                && left.filledColor.equals(right.filledColor)
+                && left.strokedColor.equals(right.strokedColor);
+    }
+
+    private Color randomColor() {
+        return new Color((int) (Math.random() * 0x1000000));
+    }
 }

src/test/java/ovh/gasser/newshapes/attributes/ColorAttributesTest.java

@@ -0,0 +1,129 @@
+package ovh.gasser.newshapes.attributes;
+
+import org.junit.jupiter.api.Test;
+
+import java.awt.*;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class ColorAttributesTest {
+
+    @Test
+    void testConstructorStoresFilledFlag() {
+        ColorAttributes attrs = new ColorAttributes(true, false, Color.RED, Color.BLACK);
+        assertTrue(attrs.filled, "filled flag should be true when constructed with true");
+    }
+
+    @Test
+    void testConstructorStoresStrokedFlag() {
+        ColorAttributes attrs = new ColorAttributes(false, true, Color.RED, Color.BLACK);
+        assertTrue(attrs.stroked, "stroked flag should be true when constructed with true");
+    }
+
+    @Test
+    void testConstructorStoresFilledColor() {
+        ColorAttributes attrs = new ColorAttributes(true, false, Color.BLUE, Color.BLACK);
+        assertEquals(Color.BLUE, attrs.filledColor, "filledColor should match the constructor argument");
+    }
+
+    @Test
+    void testConstructorStoresStrokedColor() {
+        ColorAttributes attrs = new ColorAttributes(false, true, Color.RED, Color.GREEN);
+        assertEquals(Color.GREEN, attrs.strokedColor, "strokedColor should match the constructor argument");
+    }
+
+    @Test
+    void testFilledAndStrokedBothTrue() {
+        ColorAttributes attrs = new ColorAttributes(true, true, Color.RED, Color.BLUE);
+        assertTrue(attrs.filled);
+        assertTrue(attrs.stroked);
+    }
+
+    @Test
+    void testFilledAndStrokedBothFalse() {
+        ColorAttributes attrs = new ColorAttributes(false, false, Color.RED, Color.BLUE);
+        assertFalse(attrs.filled);
+        assertFalse(attrs.stroked);
+    }
+
+    @Test
+    void testNullFilledColor() {
+        ColorAttributes attrs = new ColorAttributes(true, false, null, Color.BLACK);
+        assertNull(attrs.filledColor, "filledColor should accept null");
+    }
+
+    @Test
+    void testNullStrokedColor() {
+        ColorAttributes attrs = new ColorAttributes(false, true, Color.RED, null);
+        assertNull(attrs.strokedColor, "strokedColor should accept null");
+    }
+
+    @Test
+    void testBothColorsNull() {
+        ColorAttributes attrs = new ColorAttributes(false, false, null, null);
+        assertNull(attrs.filledColor);
+        assertNull(attrs.strokedColor);
+    }
+
+    @Test
+    void testGetIDReturnsCorrectValue() {
+        ColorAttributes attrs = new ColorAttributes(false, false, Color.RED, Color.BLACK);
+        assertEquals(ColorAttributes.ID, attrs.getID());
+    }
+
+    @Test
+    void testIDConstant() {
+        assertEquals("COLOR_ATTRS", ColorAttributes.ID);
+    }
+
+    @Test
+    void testImplementsAttributes() {
+        ColorAttributes attrs = new ColorAttributes(false, false, Color.RED, Color.BLACK);
+        assertInstanceOf(Attributes.class, attrs);
+    }
+
+    @Test
+    void testToStringContainsAllFields() {
+        ColorAttributes attrs = new ColorAttributes(true, false, Color.RED, Color.BLUE);
+        String str = attrs.toString();
+        assertTrue(str.contains("filled=true"), "toString should contain filled value");
+        assertTrue(str.contains("stroked=false"), "toString should contain stroked value");
+        assertTrue(str.contains("filledColor"), "toString should contain filledColor");
+        assertTrue(str.contains("strokedColor"), "toString should contain strokedColor");
+    }
+
+    @Test
+    void testToStringWithNullColors() {
+        ColorAttributes attrs = new ColorAttributes(false, false, null, null);
+        String str = attrs.toString();
+        assertNotNull(str, "toString should not throw with null colors");
+        assertTrue(str.contains("filledColor=null"), "toString should show null filledColor");
+        assertTrue(str.contains("strokedColor=null"), "toString should show null strokedColor");
+    }
+
+    @Test
+    void testTwoInstancesAreIndependent() {
+        ColorAttributes attrs1 = new ColorAttributes(true, false, Color.RED, Color.BLACK);
+        ColorAttributes attrs2 = new ColorAttributes(false, true, Color.BLUE, Color.GREEN);
+
+        assertTrue(attrs1.filled);
+        assertFalse(attrs2.filled);
+        assertFalse(attrs1.stroked);
+        assertTrue(attrs2.stroked);
+        assertEquals(Color.RED, attrs1.filledColor);
+        assertEquals(Color.BLUE, attrs2.filledColor);
+    }
+
+    @Test
+    void testFieldsAreImmutable() {
+        Color fillColor = Color.RED;
+        Color strokeColor = Color.BLACK;
+        ColorAttributes attrs = new ColorAttributes(true, true, fillColor, strokeColor);
+
+        // Since fields are final, verify they retain their values
+        assertEquals(Color.RED, attrs.filledColor);
+        assertEquals(Color.BLACK, attrs.strokedColor);
+        assertTrue(attrs.filled);
+        assertTrue(attrs.stroked);
+    }
+}

src/test/java/ovh/gasser/newshapes/attributes/SelectionAttributesTest.java

@@ -0,0 +1,72 @@
+package ovh.gasser.newshapes.attributes;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class SelectionAttributesTest {
+
+    @Test
+    void testDefaultConstructorIsUnselected() {
+        SelectionAttributes attrs = new SelectionAttributes();
+        assertFalse(attrs.selected, "Default constructor should create unselected state");
+    }
+
+    @Test
+    void testConstructorWithTrue() {
+        SelectionAttributes attrs = new SelectionAttributes(true);
+        assertTrue(attrs.selected, "Constructor with true should create selected state");
+    }
+
+    @Test
+    void testConstructorWithFalse() {
+        SelectionAttributes attrs = new SelectionAttributes(false);
+        assertFalse(attrs.selected, "Constructor with false should create unselected state");
+    }
+
+    @Test
+    void testGetIDReturnsCorrectValue() {
+        SelectionAttributes attrs = new SelectionAttributes();
+        assertEquals(SelectionAttributes.ID, attrs.getID());
+    }
+
+    @Test
+    void testIDConstant() {
+        assertEquals("SELECTION_ATTRS", SelectionAttributes.ID);
+    }
+
+    @Test
+    void testImplementsAttributes() {
+        SelectionAttributes attrs = new SelectionAttributes();
+        assertInstanceOf(Attributes.class, attrs);
+    }
+
+    @Test
+    void testSelectedFieldCanBeToggled() {
+        SelectionAttributes attrs = new SelectionAttributes(false);
+        assertFalse(attrs.selected);
+
+        attrs.selected = true;
+        assertTrue(attrs.selected);
+
+        attrs.selected = false;
+        assertFalse(attrs.selected);
+    }
+
+    @Test
+    void testTwoInstancesAreIndependent() {
+        SelectionAttributes attrs1 = new SelectionAttributes(true);
+        SelectionAttributes attrs2 = new SelectionAttributes(false);
+
+        assertNotEquals(attrs1.selected, attrs2.selected);
+
+        attrs2.selected = true;
+        assertTrue(attrs1.selected);
+        assertTrue(attrs2.selected);
+
+        // Mutating one doesn't affect the other
+        attrs1.selected = false;
+        assertFalse(attrs1.selected);
+        assertTrue(attrs2.selected);
+    }
+}

src/test/java/ovh/gasser/newshapes/shapes/ResizeHandleTest.java

@@ -0,0 +1,94 @@
+package ovh.gasser.newshapes.shapes;
+
+import org.junit.jupiter.api.Test;
+import java.awt.Cursor;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class ResizeHandleTest {
+
+    @Test
+    void testEightHandlesExist() {
+        assertEquals(8, ResizeHandle.values().length,
+                "ResizeHandle enum should define exactly 8 handles");
+    }
+
+    @Test
+    void testAllHandleNamesExist() {
+        assertNotNull(ResizeHandle.valueOf("NW"), "Handle NW should exist");
+        assertNotNull(ResizeHandle.valueOf("N"),  "Handle N should exist");
+        assertNotNull(ResizeHandle.valueOf("NE"), "Handle NE should exist");
+        assertNotNull(ResizeHandle.valueOf("E"),  "Handle E should exist");
+        assertNotNull(ResizeHandle.valueOf("SE"), "Handle SE should exist");
+        assertNotNull(ResizeHandle.valueOf("S"),  "Handle S should exist");
+        assertNotNull(ResizeHandle.valueOf("SW"), "Handle SW should exist");
+        assertNotNull(ResizeHandle.valueOf("W"),  "Handle W should exist");
+    }
+
+    @Test
+    void testNwMapsToCorrectCursorType() {
+        assertEquals(Cursor.NW_RESIZE_CURSOR, ResizeHandle.NW.getCursorType(),
+                "NW handle should map to Cursor.NW_RESIZE_CURSOR");
+    }
+
+    @Test
+    void testNMapsToCorrectCursorType() {
+        assertEquals(Cursor.N_RESIZE_CURSOR, ResizeHandle.N.getCursorType(),
+                "N handle should map to Cursor.N_RESIZE_CURSOR");
+    }
+
+    @Test
+    void testNeMapsToCorrectCursorType() {
+        assertEquals(Cursor.NE_RESIZE_CURSOR, ResizeHandle.NE.getCursorType(),
+                "NE handle should map to Cursor.NE_RESIZE_CURSOR");
+    }
+
+    @Test
+    void testEMapsToCorrectCursorType() {
+        assertEquals(Cursor.E_RESIZE_CURSOR, ResizeHandle.E.getCursorType(),
+                "E handle should map to Cursor.E_RESIZE_CURSOR");
+    }
+
+    @Test
+    void testSeMapsToCorrectCursorType() {
+        assertEquals(Cursor.SE_RESIZE_CURSOR, ResizeHandle.SE.getCursorType(),
+                "SE handle should map to Cursor.SE_RESIZE_CURSOR");
+    }
+
+    @Test
+    void testSMapsToCorrectCursorType() {
+        assertEquals(Cursor.S_RESIZE_CURSOR, ResizeHandle.S.getCursorType(),
+                "S handle should map to Cursor.S_RESIZE_CURSOR");
+    }
+
+    @Test
+    void testSwMapsToCorrectCursorType() {
+        assertEquals(Cursor.SW_RESIZE_CURSOR, ResizeHandle.SW.getCursorType(),
+                "SW handle should map to Cursor.SW_RESIZE_CURSOR");
+    }
+
+    @Test
+    void testWMapsToCorrectCursorType() {
+        assertEquals(Cursor.W_RESIZE_CURSOR, ResizeHandle.W.getCursorType(),
+                "W handle should map to Cursor.W_RESIZE_CURSOR");
+    }
+
+    @Test
+    void testValueOfReturnsCorrectConstant() {
+        assertSame(ResizeHandle.NW, ResizeHandle.valueOf("NW"), "valueOf(\"NW\") should return ResizeHandle.NW");
+        assertSame(ResizeHandle.N,  ResizeHandle.valueOf("N"),  "valueOf(\"N\") should return ResizeHandle.N");
+        assertSame(ResizeHandle.NE, ResizeHandle.valueOf("NE"), "valueOf(\"NE\") should return ResizeHandle.NE");
+        assertSame(ResizeHandle.E,  ResizeHandle.valueOf("E"),  "valueOf(\"E\") should return ResizeHandle.E");
+        assertSame(ResizeHandle.SE, ResizeHandle.valueOf("SE"), "valueOf(\"SE\") should return ResizeHandle.SE");
+        assertSame(ResizeHandle.S,  ResizeHandle.valueOf("S"),  "valueOf(\"S\") should return ResizeHandle.S");
+        assertSame(ResizeHandle.SW, ResizeHandle.valueOf("SW"), "valueOf(\"SW\") should return ResizeHandle.SW");
+        assertSame(ResizeHandle.W,  ResizeHandle.valueOf("W"),  "valueOf(\"W\") should return ResizeHandle.W");
+    }
+
+    @Test
+    void testValueOfWithInvalidNameThrowsIllegalArgumentException() {
+        assertThrows(IllegalArgumentException.class,
+                () -> ResizeHandle.valueOf("INVALID"),
+                "valueOf() with an unknown name should throw IllegalArgumentException");
+    }
+}

src/test/java/ovh/gasser/newshapes/ui/visitors/HTMLDraftmanTest.java

@@ -0,0 +1,409 @@
+package ovh.gasser.newshapes.ui.visitors;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Nested;
+import org.junit.jupiter.api.Test;
+import ovh.gasser.newshapes.attributes.ColorAttributes;
+import ovh.gasser.newshapes.shapes.*;
+
+import java.awt.*;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class HTMLDraftmanTest {
+
+    private StringWriter htmlBuffer;
+    private StringWriter cssBuffer;
+    private PrintWriter htmlWriter;
+    private PrintWriter cssWriter;
+    private HTMLDraftman draftman;
+
+    @BeforeEach
+    void setUp() {
+        htmlBuffer = new StringWriter();
+        cssBuffer = new StringWriter();
+        htmlWriter = new PrintWriter(htmlBuffer);
+        cssWriter = new PrintWriter(cssBuffer);
+        draftman = new HTMLDraftman(htmlWriter, cssWriter);
+    }
+
+    private String html() {
+        htmlWriter.flush();
+        return htmlBuffer.toString();
+    }
+
+    private String css() {
+        cssWriter.flush();
+        return cssBuffer.toString();
+    }
+
+    // ── visitRectangle ──────────────────────────────────────────────
+
+    @Nested
+    class VisitRectangleTests {
+
+        @Test
+        void testRectangleProducesDivWithId() {
+            SRectangle rect = SRectangle.create(10, 20, 100, 50);
+            draftman.visitRectangle(rect);
+
+            assertTrue(html().contains("<div id=\"rec"), "Should produce a div with rec id");
+        }
+
+        @Test
+        void testRectangleCssContainsCorrectPosition() {
+            SRectangle rect = SRectangle.create(10, 20, 100, 50);
+            draftman.visitRectangle(rect);
+
+            String cssOut = css();
+            assertTrue(cssOut.contains("top:20px"), "CSS should contain correct top");
+            assertTrue(cssOut.contains("left:10px"), "CSS should contain correct left");
+        }
+
+        @Test
+        void testRectangleCssContainsCorrectDimensions() {
+            SRectangle rect = SRectangle.create(10, 20, 100, 50);
+            draftman.visitRectangle(rect);
+
+            String cssOut = css();
+            assertTrue(cssOut.contains("width:100px"), "CSS should contain correct width");
+            assertTrue(cssOut.contains("height:50px"), "CSS should contain correct height");
+        }
+
+        @Test
+        void testRectangleCssPositionIsAbsolute() {
+            SRectangle rect = SRectangle.create(0, 0, 30, 30);
+            draftman.visitRectangle(rect);
+
+            assertTrue(css().contains("position:absolute"), "CSS should use absolute positioning");
+        }
+
+        @Test
+        void testRectangleHtmlIdMatchesCssSelector() {
+            SRectangle rect = SRectangle.create(0, 0, 30, 30);
+            draftman.visitRectangle(rect);
+
+            String id = "rec" + rect.hashCode();
+            assertTrue(html().contains("id=\"" + id + "\""), "HTML should contain div with correct id");
+            assertTrue(css().contains("#" + id), "CSS should reference same id");
+        }
+
+        @Test
+        void testRectangleFilledAndStroked() {
+            SRectangle rect = SRectangle.create(0, 0, 30, 30);
+            rect.addAttributes(new ColorAttributes(true, true, Color.RED, Color.BLUE));
+            draftman.visitRectangle(rect);
+
+            String cssOut = css();
+            assertTrue(cssOut.contains("background:"), "CSS should contain background");
+            assertTrue(cssOut.contains("border:"), "CSS should contain border");
+        }
+
+        @Test
+        void testRectangleFilledOnly() {
+            SRectangle rect = SRectangle.create(0, 0, 30, 30);
+            rect.addAttributes(new ColorAttributes(true, false, Color.RED, Color.BLACK));
+            draftman.visitRectangle(rect);
+
+            String cssOut = css();
+            assertTrue(cssOut.contains("background:"), "CSS should contain background for filled");
+            assertFalse(cssOut.contains("border:"), "CSS should not contain border when not stroked");
+        }
+
+        @Test
+        void testRectangleStrokedOnly() {
+            SRectangle rect = SRectangle.create(0, 0, 30, 30);
+            rect.addAttributes(new ColorAttributes(false, true, Color.RED, Color.BLUE));
+            draftman.visitRectangle(rect);
+
+            String cssOut = css();
+            assertTrue(cssOut.contains("border:"), "CSS should contain border for stroked");
+            assertTrue(cssOut.contains("background:#ffffff"), "CSS should have white background when not filled");
+        }
+
+        @Test
+        void testRectangleNeitherFilledNorStroked() {
+            SRectangle rect = SRectangle.create(0, 0, 30, 30);
+            rect.addAttributes(new ColorAttributes(false, false, Color.RED, Color.BLUE));
+            draftman.visitRectangle(rect);
+
+            String cssOut = css();
+            assertFalse(cssOut.contains("background:"), "CSS should not contain background");
+            assertFalse(cssOut.contains("border:"), "CSS should not contain border");
+        }
+    }
+
+    // ── visitCircle ─────────────────────────────────────────────────
+
+    @Nested
+    class VisitCircleTests {
+
+        @Test
+        void testCircleProducesDivWithClass() {
+            SCircle circle = SCircle.create(50, 60, 30);
+            draftman.visitCircle(circle);
+
+            assertTrue(html().contains("circle"), "HTML should contain circle class div");
+        }
+
+        @Test
+        void testCircleCssContainsBorderRadius() {
+            SCircle circle = SCircle.create(50, 60, 30);
+            draftman.visitCircle(circle);
+
+            String cssOut = css();
+            assertTrue(cssOut.contains("border-radius:"), "CSS should contain border-radius");
+            assertTrue(cssOut.contains("-webkit-border-radius:"), "CSS should contain webkit prefix");
+            assertTrue(cssOut.contains("-moz-border-radius:"), "CSS should contain moz prefix");
+        }
+
+        @Test
+        void testCircleCssContainsCorrectPosition() {
+            SCircle circle = SCircle.create(50, 60, 30);
+            draftman.visitCircle(circle);
+
+            String cssOut = css();
+            assertTrue(cssOut.contains("top:60px"), "CSS should contain correct top");
+            assertTrue(cssOut.contains("left:50px"), "CSS should contain correct left");
+        }
+
+        @Test
+        void testCircleHtmlClassMatchesCssSelector() {
+            SCircle circle = SCircle.create(0, 0, 20);
+            draftman.visitCircle(circle);
+
+            String className = "circle" + circle.hashCode();
+            assertTrue(html().contains(className), "HTML should have circle class");
+            assertTrue(css().contains("." + className), "CSS should reference same class");
+        }
+    }
+
+    // ── visitTriangle ───────────────────────────────────────────────
+
+    @Nested
+    class VisitTriangleTests {
+
+        @Test
+        void testTriangleProducesDivWithClass() {
+            STriangle tri = STriangle.create(10, 20, 40, Color.RED, Color.BLACK);
+            draftman.visitTriangle(tri);
+
+            assertTrue(html().contains("triangle"), "HTML should contain triangle class div");
+        }
+
+        @Test
+        void testTriangleCssContainsBorderTrick() {
+            STriangle tri = STriangle.create(10, 20, 40, Color.RED, Color.BLACK);
+            draftman.visitTriangle(tri);
+
+            String cssOut = css();
+            assertTrue(cssOut.contains("border-left-width:"), "CSS should use border-left-width");
+            assertTrue(cssOut.contains("border-right-width:"), "CSS should use border-right-width");
+            assertTrue(cssOut.contains("border-bottom:"), "CSS should use border-bottom");
+            assertTrue(cssOut.contains("width: 0px"), "CSS should set width to 0");
+            assertTrue(cssOut.contains("height: 0px"), "CSS should set height to 0");
+        }
+
+        @Test
+        void testTriangleCssContainsCorrectPosition() {
+            STriangle tri = STriangle.create(10, 20, 40, Color.RED, Color.BLACK);
+            draftman.visitTriangle(tri);
+
+            String cssOut = css();
+            assertTrue(cssOut.contains("top: 20px"), "CSS should contain correct top");
+            assertTrue(cssOut.contains("left: 10px"), "CSS should contain correct left");
+        }
+
+        @Test
+        void testTriangleCssContainsFillColor() {
+            STriangle tri = STriangle.create(0, 0, 20, Color.BLUE, Color.BLACK);
+            tri.addAttributes(new ColorAttributes(true, false, Color.BLUE, Color.BLACK));
+            draftman.visitTriangle(tri);
+
+            assertTrue(css().contains("#0000ff"), "CSS should contain the triangle fill color");
+        }
+
+        @Test
+        void testTriangleHtmlClassMatchesCssSelector_regressionHashCode() {
+            // Regression test: visitTriangle previously used this.hashCode()
+            // instead of sTriangle.hashCode(), causing HTML class and CSS
+            // selector mismatch when rendered by a different draftman instance.
+            STriangle tri = STriangle.create(5, 5, 30, Color.RED, Color.BLACK);
+            draftman.visitTriangle(tri);
+
+            String htmlOut = html();
+            String cssOut = css();
+
+            // Extract the class name from HTML: class="triangleNNN"
+            int classStart = htmlOut.indexOf("triangle");
+            assertNotEquals(-1, classStart, "HTML should contain triangle class");
+            int classEnd = htmlOut.indexOf("\"", classStart);
+            String htmlClassName = htmlOut.substring(classStart, classEnd);
+
+            // CSS should use the same class name
+            assertTrue(cssOut.contains("." + htmlClassName),
+                    "CSS selector should match HTML class — " +
+                    "if this fails, visitTriangle may be using this.hashCode() instead of sTriangle.hashCode()");
+        }
+    }
+
+    // ── visitText ───────────────────────────────────────────────────
+
+    @Nested
+    class VisitTextTests {
+
+        @Test
+        void testTextProducesDivWithContent() {
+            SText text = SText.create(10, 20, "Hello");
+            draftman.visitText(text);
+
+            assertTrue(html().contains(">Hello</div>"), "HTML should contain text content in div");
+        }
+
+        @Test
+        void testTextHtmlIdMatchesCssSelector() {
+            SText text = SText.create(0, 0, "Test");
+            draftman.visitText(text);
+
+            String id = "txt" + text.hashCode();
+            assertTrue(html().contains("id=\"" + id + "\""), "HTML should contain text div with correct id");
+            assertTrue(css().contains("#" + id), "CSS should reference same text id");
+        }
+
+        @Test
+        void testTextCssContainsPosition() {
+            SText text = SText.create(15, 25, "Pos");
+            draftman.visitText(text);
+
+            String cssOut = css();
+            assertTrue(cssOut.contains("top:25px"), "CSS should contain correct top");
+            assertTrue(cssOut.contains("left:15px"), "CSS should contain correct left");
+        }
+
+        @Test
+        void testTextCssContainsDefaultFontAttributes() {
+            SText text = SText.create(0, 0, "Font");
+            draftman.visitText(text);
+
+            String cssOut = css();
+            assertTrue(cssOut.contains("font-family:"), "CSS should contain font-family");
+            assertTrue(cssOut.contains("font-size:16px"), "CSS should contain default font size");
+            assertTrue(cssOut.contains("font-style:normal"), "CSS should contain normal font style");
+            assertTrue(cssOut.contains("font-weight:normal"), "CSS should contain normal font weight");
+        }
+
+        @Test
+        void testTextCssContainsColor() {
+            SText text = SText.create(0, 0, "Colored");
+            text.addAttributes(new ColorAttributes(true, false, Color.RED, Color.BLACK));
+            draftman.visitText(text);
+
+            assertTrue(css().contains("color:#ff0000"), "CSS should contain fill color as text color");
+        }
+
+        @Test
+        void testTextCssWhiteSpaceNowrap() {
+            SText text = SText.create(0, 0, "NoWrap");
+            draftman.visitText(text);
+
+            assertTrue(css().contains("white-space: nowrap"), "CSS should prevent text wrapping");
+        }
+
+        @Test
+        void testTextWithNullColorAttributesFallsBackToBlack() {
+            SText text = SText.create(0, 0, "Fallback");
+            text.addAttributes(new ColorAttributes(false, false, null, null));
+            draftman.visitText(text);
+
+            assertTrue(css().contains("color:#000000"), "Should fall back to black with null colors");
+        }
+    }
+
+    // ── visitCollection ─────────────────────────────────────────────
+
+    @Nested
+    class VisitCollectionTests {
+
+        @Test
+        void testEmptyCollection() {
+            SCollection empty = SCollection.of();
+            draftman.visitCollection(empty);
+
+            assertEquals("", html(), "Empty collection should produce no HTML");
+            assertEquals("", css(), "Empty collection should produce no CSS");
+        }
+
+        @Test
+        void testCollectionVisitsAllChildren() {
+            SCollection coll = SCollection.of(
+                    SRectangle.create(0, 0, 10, 10),
+                    SCircle.create(20, 20, 5)
+            );
+            draftman.visitCollection(coll);
+
+            assertTrue(html().contains("rec"), "Should visit rectangle");
+            assertTrue(html().contains("circle"), "Should visit circle");
+        }
+
+        @Test
+        void testNestedCollectionVisitsAllDescendants() {
+            SCollection inner = SCollection.of(
+                    SRectangle.create(0, 0, 5, 5)
+            );
+            SCollection outer = SCollection.of(
+                    inner,
+                    SCircle.create(10, 10, 3)
+            );
+            draftman.visitCollection(outer);
+
+            assertTrue(html().contains("rec"), "Should visit nested rectangle");
+            assertTrue(html().contains("circle"), "Should visit circle at outer level");
+        }
+    }
+
+    // ── generateHTML ────────────────────────────────────────────────
+
+    @Nested
+    class GenerateHTMLTests {
+
+        @Test
+        void testGenerateHTMLIncludesDoctype() {
+            SCollection model = SCollection.of();
+            draftman.generateHTML(model);
+
+            assertTrue(html().contains("<!DOCTYPE html>"), "Should include DOCTYPE");
+        }
+
+        @Test
+        void testGenerateHTMLIncludesHtmlStructure() {
+            SCollection model = SCollection.of();
+            draftman.generateHTML(model);
+
+            String htmlOut = html();
+            assertTrue(htmlOut.contains("<html"), "Should include html tag");
+            assertTrue(htmlOut.contains("<head>"), "Should include head tag");
+            assertTrue(htmlOut.contains("<body>"), "Should include body tag");
+            assertTrue(htmlOut.contains("</body>"), "Should close body tag");
+        }
+
+        @Test
+        void testGenerateHTMLReferencesStylesheet() {
+            SCollection model = SCollection.of();
+            draftman.generateHTML(model);
+
+            assertTrue(html().contains("style.css"), "Should reference CSS stylesheet");
+        }
+
+        @Test
+        void testGenerateHTMLIncludesShapeContent() {
+            SCollection model = SCollection.of(
+                    SRectangle.create(1, 2, 3, 4)
+            );
+            draftman.generateHTML(model);
+
+            assertTrue(html().contains("<div id=\"rec"), "Should include shape elements");
+        }
+    }
+}

src/test/java/ovh/gasser/newshapes/ui/visitors/SVGDraftmanTest.java

@@ -0,0 +1,370 @@
+package ovh.gasser.newshapes.ui.visitors;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Nested;
+import org.junit.jupiter.api.Test;
+import ovh.gasser.newshapes.attributes.ColorAttributes;
+import ovh.gasser.newshapes.shapes.*;
+
+import java.awt.*;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class SVGDraftmanTest {
+
+    private StringWriter buffer;
+    private PrintWriter writer;
+    private SVGDraftman draftman;
+
+    @BeforeEach
+    void setUp() {
+        buffer = new StringWriter();
+        writer = new PrintWriter(buffer);
+        draftman = new SVGDraftman(writer);
+    }
+
+    private String output() {
+        writer.flush();
+        return buffer.toString();
+    }
+
+    // ── visitRectangle ──────────────────────────────────────────────
+
+    @Nested
+    class VisitRectangleTests {
+
+        @Test
+        void testRectangleElementWithCorrectDimensions() {
+            SRectangle rect = SRectangle.create(10, 20, 100, 50);
+            draftman.visitRectangle(rect);
+
+            String svg = output();
+            assertTrue(svg.contains("<rect"), "Should produce a <rect> element");
+            assertTrue(svg.contains("width=\"100\""), "Should have correct width");
+            assertTrue(svg.contains("height=\"50\""), "Should have correct height");
+            assertTrue(svg.contains("x=\"10\""), "Should have correct x");
+            assertTrue(svg.contains("y=\"20\""), "Should have correct y");
+        }
+
+        @Test
+        void testRectangleFilledOnly() {
+            SRectangle rect = SRectangle.create(0, 0, 30, 30);
+            rect.addAttributes(new ColorAttributes(true, false, Color.RED, Color.BLACK));
+            draftman.visitRectangle(rect);
+
+            String svg = output();
+            assertTrue(svg.contains("fill=\"#ff0000\""), "Should contain fill color");
+            assertFalse(svg.contains("stroke="), "Should not contain stroke when stroked=false");
+        }
+
+        @Test
+        void testRectangleStrokedOnly() {
+            SRectangle rect = SRectangle.create(0, 0, 30, 30);
+            rect.addAttributes(new ColorAttributes(false, true, Color.RED, Color.BLUE));
+            draftman.visitRectangle(rect);
+
+            String svg = output();
+            assertTrue(svg.contains("stroke=\"#0000ff\""), "Should contain stroke color");
+            assertTrue(svg.contains("stroke-width=\"1\""), "Should contain stroke-width");
+            assertTrue(svg.contains("fill=\"none\""), "Should have fill=none when not filled");
+        }
+
+        @Test
+        void testRectangleFilledAndStroked() {
+            SRectangle rect = SRectangle.create(0, 0, 30, 30);
+            rect.addAttributes(new ColorAttributes(true, true, Color.RED, Color.BLUE));
+            draftman.visitRectangle(rect);
+
+            String svg = output();
+            assertTrue(svg.contains("fill=\"#ff0000\""), "Should contain fill color");
+            assertTrue(svg.contains("stroke=\"#0000ff\""), "Should contain stroke color");
+        }
+
+        @Test
+        void testRectangleNeitherFilledNorStroked() {
+            SRectangle rect = SRectangle.create(0, 0, 30, 30);
+            rect.addAttributes(new ColorAttributes(false, false, Color.RED, Color.BLUE));
+            draftman.visitRectangle(rect);
+
+            String svg = output();
+            assertTrue(svg.contains("fill=\"none\""), "Should have fill=none");
+            assertFalse(svg.contains("stroke="), "Should not have stroke attribute");
+        }
+    }
+
+    // ── visitCircle ─────────────────────────────────────────────────
+
+    @Nested
+    class VisitCircleTests {
+
+        @Test
+        void testCircleElementWithCorrectAttributes() {
+            SCircle circle = SCircle.create(50, 60, 30);
+            draftman.visitCircle(circle);
+
+            String svg = output();
+            assertTrue(svg.contains("<circle"), "Should produce a <circle> element");
+            // cx = x + r = 50 + 30 = 80, cy = y + r = 60 + 30 = 90
+            assertTrue(svg.contains("cx=\"80\""), "cx should be x + radius");
+            assertTrue(svg.contains("cy=\"90\""), "cy should be y + radius");
+            assertTrue(svg.contains("r=\"30\""), "Should have correct radius");
+        }
+
+        @Test
+        void testCircleFilledOnly() {
+            SCircle circle = SCircle.create(0, 0, 20);
+            circle.addAttributes(new ColorAttributes(true, false, Color.GREEN, Color.BLACK));
+            draftman.visitCircle(circle);
+
+            String svg = output();
+            assertTrue(svg.contains("fill=\"#00ff00\""), "Should contain fill color");
+            assertFalse(svg.contains("stroke="), "Should not contain stroke");
+        }
+
+        @Test
+        void testCircleStrokedOnly() {
+            SCircle circle = SCircle.create(0, 0, 20);
+            circle.addAttributes(new ColorAttributes(false, true, Color.RED, Color.MAGENTA));
+            draftman.visitCircle(circle);
+
+            String svg = output();
+            assertTrue(svg.contains("stroke=\"#ff00ff\""), "Should contain stroke color");
+            assertTrue(svg.contains("fill=\"none\""), "Should have fill=none");
+        }
+
+        @Test
+        void testCircleFilledAndStroked() {
+            SCircle circle = SCircle.create(0, 0, 15);
+            circle.addAttributes(new ColorAttributes(true, true, Color.YELLOW, Color.BLACK));
+            draftman.visitCircle(circle);
+
+            String svg = output();
+            assertTrue(svg.contains("fill=\"#ffff00\""), "Should contain fill color");
+            assertTrue(svg.contains("stroke=\"#000000\""), "Should contain stroke color");
+        }
+    }
+
+    // ── visitTriangle ───────────────────────────────────────────────
+
+    @Nested
+    class VisitTriangleTests {
+
+        @Test
+        void testTriangleProducesPolygonElement() {
+            STriangle tri = STriangle.create(10, 20, 40, Color.RED, Color.BLACK);
+            draftman.visitTriangle(tri);
+
+            String svg = output();
+            assertTrue(svg.contains("<polygon"), "Should produce a <polygon> element");
+            assertTrue(svg.contains("points="), "Should have points attribute");
+        }
+
+        @Test
+        void testTrianglePointsAreCorrect() {
+            STriangle tri = STriangle.create(10, 20, 40, Color.RED, Color.BLACK);
+            draftman.visitTriangle(tri);
+
+            String svg = output();
+            // bottom-left: (x, y+size) = (10, 60)
+            assertTrue(svg.contains("10,60"), "Should contain bottom-left point");
+            // top-center: (x + size/2, y) = (30, 20)
+            assertTrue(svg.contains("30,20"), "Should contain top-center point");
+            // bottom-right: (x + size, y + size) = (50, 60)
+            assertTrue(svg.contains("50,60"), "Should contain bottom-right point");
+        }
+
+        @Test
+        void testTriangleFilledOnly() {
+            STriangle tri = STriangle.create(0, 0, 20, Color.BLUE, Color.BLACK);
+            tri.addAttributes(new ColorAttributes(true, false, Color.BLUE, Color.BLACK));
+            draftman.visitTriangle(tri);
+
+            String svg = output();
+            assertTrue(svg.contains("fill:#0000ff"), "Should contain fill style");
+            assertFalse(svg.contains("stroke:"), "Should not contain stroke style when not stroked");
+        }
+
+        @Test
+        void testTriangleStrokedAndFilled() {
+            STriangle tri = STriangle.create(0, 0, 20, Color.RED, Color.GREEN);
+            tri.addAttributes(new ColorAttributes(true, true, Color.RED, Color.GREEN));
+            draftman.visitTriangle(tri);
+
+            String svg = output();
+            assertTrue(svg.contains("fill:#ff0000"), "Should contain fill style");
+            assertTrue(svg.contains("stroke:#00ff00"), "Should contain stroke style");
+        }
+
+        @Test
+        void testTriangleNotFilled() {
+            STriangle tri = STriangle.create(0, 0, 20, Color.RED, Color.BLACK);
+            tri.addAttributes(new ColorAttributes(false, true, Color.RED, Color.BLACK));
+            draftman.visitTriangle(tri);
+
+            String svg = output();
+            assertTrue(svg.contains("fill:none"), "Should have fill:none when not filled");
+        }
+    }
+
+    // ── visitText ───────────────────────────────────────────────────
+
+    @Nested
+    class VisitTextTests {
+
+        @Test
+        void testTextElementWithCorrectContent() {
+            SText text = SText.create(10, 20, "Hello");
+            draftman.visitText(text);
+
+            String svg = output();
+            assertTrue(svg.contains("<text"), "Should produce a <text> element");
+            assertTrue(svg.contains(">Hello</text>"), "Should contain the text content");
+        }
+
+        @Test
+        void testTextPositionIncludesFontSizeOffset() {
+            SText text = SText.create(10, 20, "Hi");
+            draftman.visitText(text);
+
+            String svg = output();
+            assertTrue(svg.contains("x=\"10\""), "x should match bounds.x");
+            // y = bounds.y + fontSize = 20 + 16 = 36
+            assertTrue(svg.contains("y=\"36\""), "y should be bounds.y + fontSize");
+        }
+
+        @Test
+        void testTextDefaultFontAttributes() {
+            SText text = SText.create(0, 0, "Test");
+            draftman.visitText(text);
+
+            String svg = output();
+            assertTrue(svg.contains("font-family=\"SansSerif\""), "Should use default font family");
+            assertTrue(svg.contains("font-size=\"16\""), "Should use default font size");
+            assertTrue(svg.contains("font-style=\"normal\""), "Default style should be normal");
+            assertTrue(svg.contains("font-weight=\"normal\""), "Default weight should be normal");
+        }
+
+        @Test
+        void testTextDefaultColorIsBlack() {
+            SText text = SText.create(0, 0, "Test");
+            // default ColorAttributes: filled=true, filledColor=BLACK
+            draftman.visitText(text);
+
+            String svg = output();
+            assertTrue(svg.contains("fill=\"#000000\""), "Default text color should be black");
+        }
+
+        @Test
+        void testTextWithCustomFillColor() {
+            SText text = SText.create(0, 0, "Colored");
+            text.addAttributes(new ColorAttributes(true, false, Color.RED, Color.BLACK));
+            draftman.visitText(text);
+
+            String svg = output();
+            assertTrue(svg.contains("fill=\"#ff0000\""), "Text should use filledColor");
+        }
+
+        @Test
+        void testTextWithNullColorAttributesFallsBackToBlack() {
+            SText text = SText.create(0, 0, "NoColor");
+            text.addAttributes(new ColorAttributes(false, false, null, null));
+            draftman.visitText(text);
+
+            String svg = output();
+            assertTrue(svg.contains("fill=\"#000000\""), "Should fall back to black with null colors");
+        }
+    }
+
+    // ── visitCollection ─────────────────────────────────────────────
+
+    @Nested
+    class VisitCollectionTests {
+
+        @Test
+        void testEmptyCollection() {
+            SCollection empty = SCollection.of();
+            draftman.visitCollection(empty);
+
+            String svg = output();
+            assertEquals("", svg, "Empty collection should produce no output");
+        }
+
+        @Test
+        void testCollectionVisitsAllChildren() {
+            SCollection coll = SCollection.of(
+                    SRectangle.create(0, 0, 10, 10),
+                    SCircle.create(20, 20, 5)
+            );
+            draftman.visitCollection(coll);
+
+            String svg = output();
+            assertTrue(svg.contains("<rect"), "Should visit rectangle");
+            assertTrue(svg.contains("<circle"), "Should visit circle");
+        }
+
+        @Test
+        void testNestedCollectionVisitsAllDescendants() {
+            SCollection inner = SCollection.of(
+                    SRectangle.create(0, 0, 5, 5)
+            );
+            SCollection outer = SCollection.of(
+                    inner,
+                    SCircle.create(10, 10, 3)
+            );
+            draftman.visitCollection(outer);
+
+            String svg = output();
+            assertTrue(svg.contains("<rect"), "Should visit nested rectangle");
+            assertTrue(svg.contains("<circle"), "Should visit circle at outer level");
+        }
+    }
+
+    // ── generateSVG ─────────────────────────────────────────────────
+
+    @Nested
+    class GenerateSVGTests {
+
+        @Test
+        void testGenerateSVGIncludesXmlDeclaration() {
+            SCollection model = SCollection.of();
+            draftman.generateSVG(model);
+
+            String svg = output();
+            assertTrue(svg.contains("<?xml version=\"1.0\" encoding=\"utf-8\"?>"),
+                    "Should include XML declaration");
+        }
+
+        @Test
+        void testGenerateSVGIncludesSvgNamespace() {
+            SCollection model = SCollection.of();
+            draftman.generateSVG(model);
+
+            String svg = output();
+            assertTrue(svg.contains("xmlns=\"http://www.w3.org/2000/svg\""),
+                    "Should include SVG namespace");
+        }
+
+        @Test
+        void testGenerateSVGClosesSvgTag() {
+            SCollection model = SCollection.of();
+            draftman.generateSVG(model);
+
+            String svg = output();
+            assertTrue(svg.contains("</svg>"), "Should close <svg> tag");
+        }
+
+        @Test
+        void testGenerateSVGIncludesShapeContent() {
+            SCollection model = SCollection.of(
+                    SRectangle.create(1, 2, 3, 4)
+            );
+            draftman.generateSVG(model);
+
+            String svg = output();
+            assertTrue(svg.contains("<rect"), "Should include shape elements");
+            assertTrue(svg.contains("</svg>"), "Should close SVG after shapes");
+        }
+    }
+}