Compare commits
5 Commits
feature/is
...
740572bfb7
| Author | SHA1 | Date | |
|---|---|---|---|
| 740572bfb7 | |||
| e8cb0810de | |||
| 6cc6fbbfe8 | |||
| 5415c10c26 | |||
| 873f5d2711 |
Submodule new-shapes.wiki deleted from 731a57b080
@@ -57,7 +57,7 @@ public class SText extends AbstractShape {
|
|||||||
}
|
}
|
||||||
|
|
||||||
public void updateMeasuredBounds(int width, int height) {
|
public void updateMeasuredBounds(int width, int height) {
|
||||||
getBounds().setSize(Math.max(width, 0), Math.max(height, 0));
|
bounds.setSize(Math.max(width, 0), Math.max(height, 0));
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
|||||||
@@ -5,15 +5,6 @@ import org.slf4j.LoggerFactory;
|
|||||||
import ovh.gasser.newshapes.HTMLExporter;
|
import ovh.gasser.newshapes.HTMLExporter;
|
||||||
import ovh.gasser.newshapes.Selection;
|
import ovh.gasser.newshapes.Selection;
|
||||||
import ovh.gasser.newshapes.attributes.ColorAttributes;
|
import ovh.gasser.newshapes.attributes.ColorAttributes;
|
||||||
import ovh.gasser.newshapes.persistence.DrawingSerializer;
|
|
||||||
import ovh.gasser.newshapes.command.AddShapeCommand;
|
|
||||||
import ovh.gasser.newshapes.command.ChangeColorCommand;
|
|
||||||
import ovh.gasser.newshapes.command.Command;
|
|
||||||
import ovh.gasser.newshapes.command.CommandHistory;
|
|
||||||
import ovh.gasser.newshapes.command.CommandHistoryListener;
|
|
||||||
import ovh.gasser.newshapes.command.MoveShapeCommand;
|
|
||||||
import ovh.gasser.newshapes.command.RemoveShapeCommand;
|
|
||||||
import ovh.gasser.newshapes.command.ResizeShapeCommand;
|
|
||||||
import ovh.gasser.newshapes.shapes.ResizeHandle;
|
import ovh.gasser.newshapes.shapes.ResizeHandle;
|
||||||
import ovh.gasser.newshapes.shapes.SCollection;
|
import ovh.gasser.newshapes.shapes.SCollection;
|
||||||
import ovh.gasser.newshapes.shapes.SText;
|
import ovh.gasser.newshapes.shapes.SText;
|
||||||
@@ -22,28 +13,18 @@ import ovh.gasser.newshapes.ui.listeners.SelectionListener;
|
|||||||
|
|
||||||
import javax.swing.*;
|
import javax.swing.*;
|
||||||
import java.awt.*;
|
import java.awt.*;
|
||||||
import java.awt.event.InputEvent;
|
|
||||||
import java.awt.event.KeyAdapter;
|
import java.awt.event.KeyAdapter;
|
||||||
import java.awt.event.KeyEvent;
|
import java.awt.event.KeyEvent;
|
||||||
import java.awt.event.MouseAdapter;
|
import java.awt.event.MouseAdapter;
|
||||||
import java.awt.event.MouseEvent;
|
import java.awt.event.MouseEvent;
|
||||||
import java.io.FileNotFoundException;
|
import java.io.FileNotFoundException;
|
||||||
import java.util.ArrayList;
|
|
||||||
import java.util.Collection;
|
|
||||||
import java.util.LinkedHashMap;
|
|
||||||
import java.util.LinkedHashSet;
|
|
||||||
import java.util.List;
|
|
||||||
import java.util.Map;
|
|
||||||
import java.util.Optional;
|
import java.util.Optional;
|
||||||
import java.util.function.Function;
|
|
||||||
|
|
||||||
public class Controller {
|
public class Controller {
|
||||||
private static final Logger logger = LoggerFactory.getLogger(Controller.class);
|
private final static Logger logger = LoggerFactory.getLogger(Controller.class);
|
||||||
|
|
||||||
private final ShapesView view;
|
private final ShapesView view;
|
||||||
private final SCollection model;
|
private final SCollection model;
|
||||||
private final Selection selection;
|
private final Selection selection;
|
||||||
private final CommandHistory commandHistory;
|
|
||||||
|
|
||||||
private Point lastMousePos;
|
private Point lastMousePos;
|
||||||
private boolean addingText;
|
private boolean addingText;
|
||||||
@@ -54,24 +35,11 @@ public class Controller {
|
|||||||
private Point selectionBoxStart;
|
private Point selectionBoxStart;
|
||||||
private Point selectionBoxEnd;
|
private Point selectionBoxEnd;
|
||||||
private boolean boxSelecting;
|
private boolean boxSelecting;
|
||||||
private Point dragStartMousePos;
|
|
||||||
private Map<Shape, Rectangle> dragStartBounds = Map.of();
|
|
||||||
private final Runnable onModelChanged;
|
|
||||||
private java.util.List<Shape> clipboard = java.util.List.of();
|
|
||||||
private int pasteCount = 0;
|
|
||||||
private static final int PASTE_OFFSET = 20;
|
|
||||||
private boolean additiveBoxSelection;
|
|
||||||
|
|
||||||
Controller(ShapesView view, SCollection model) {
|
Controller(ShapesView view, SCollection model) {
|
||||||
this(view, model, () -> { });
|
|
||||||
}
|
|
||||||
|
|
||||||
Controller(ShapesView view, SCollection model, Runnable onModelChanged) {
|
|
||||||
this.view = view;
|
this.view = view;
|
||||||
this.model = model;
|
this.model = model;
|
||||||
this.onModelChanged = onModelChanged;
|
|
||||||
this.selection = new Selection();
|
this.selection = new Selection();
|
||||||
this.commandHistory = new CommandHistory();
|
|
||||||
|
|
||||||
var adapter = new MouseAdapter() {
|
var adapter = new MouseAdapter() {
|
||||||
@Override
|
@Override
|
||||||
@@ -86,7 +54,14 @@ public class Controller {
|
|||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void mouseReleased(MouseEvent evt) {
|
public void mouseReleased(MouseEvent evt) {
|
||||||
handleMouseReleased(evt);
|
resizing = false;
|
||||||
|
activeHandle = null;
|
||||||
|
resizeOrigin = null;
|
||||||
|
boxSelecting = false;
|
||||||
|
selectionBoxStart = null;
|
||||||
|
selectionBoxEnd = null;
|
||||||
|
view.setCurrentSelectionBox(null);
|
||||||
|
view.repaint();
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
this.view.addMouseMotionListener(adapter);
|
this.view.addMouseMotionListener(adapter);
|
||||||
@@ -99,249 +74,6 @@ public class Controller {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
public void addShape(Shape shape) {
|
|
||||||
executeAndRefresh(new AddShapeCommand(model, shape));
|
|
||||||
}
|
|
||||||
|
|
||||||
public void addSelectionChangeListener(SelectionListener listener) {
|
|
||||||
selection.addListener(listener);
|
|
||||||
}
|
|
||||||
|
|
||||||
public void addHistoryChangeListener(CommandHistoryListener listener) {
|
|
||||||
commandHistory.addListener(listener);
|
|
||||||
}
|
|
||||||
|
|
||||||
public boolean canUndo() {
|
|
||||||
return commandHistory.canUndo();
|
|
||||||
}
|
|
||||||
|
|
||||||
public boolean canRedo() {
|
|
||||||
return commandHistory.canRedo();
|
|
||||||
}
|
|
||||||
|
|
||||||
public void undo() {
|
|
||||||
if (!commandHistory.canUndo()) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
resetSelection();
|
|
||||||
commandHistory.undo();
|
|
||||||
view.repaint();
|
|
||||||
}
|
|
||||||
|
|
||||||
public void redo() {
|
|
||||||
if (!commandHistory.canRedo()) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
resetSelection();
|
|
||||||
commandHistory.redo();
|
|
||||||
view.repaint();
|
|
||||||
}
|
|
||||||
|
|
||||||
public void saveDrawing(java.io.File file) {
|
|
||||||
try {
|
|
||||||
new DrawingSerializer().save(model, file);
|
|
||||||
logger.info("Saved drawing to {}", file.getAbsolutePath());
|
|
||||||
} catch (java.io.IOException e) {
|
|
||||||
logger.error("Failed to save drawing: {}", e.getMessage());
|
|
||||||
JOptionPane.showMessageDialog(view, "Failed to save: " + e.getMessage(), "Save Error", JOptionPane.ERROR_MESSAGE);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
public void loadDrawing(java.io.File file) {
|
|
||||||
try {
|
|
||||||
SCollection loaded = new DrawingSerializer().load(file);
|
|
||||||
model.stream().toList().forEach(model::remove);
|
|
||||||
loaded.forEach(model::add);
|
|
||||||
resetSelection();
|
|
||||||
view.repaint();
|
|
||||||
logger.info("Loaded drawing from {}", file.getAbsolutePath());
|
|
||||||
} catch (java.io.IOException e) {
|
|
||||||
logger.error("Failed to load drawing: {}", e.getMessage());
|
|
||||||
JOptionPane.showMessageDialog(view, "Failed to load: " + e.getMessage(), "Load Error", JOptionPane.ERROR_MESSAGE);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
public void enterTextMode() {
|
|
||||||
addingText = true;
|
|
||||||
}
|
|
||||||
|
|
||||||
public void deleteSelected() {
|
|
||||||
List<Shape> selectedShapes = selection.getSelectedShapes();
|
|
||||||
if (selectedShapes.isEmpty()) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
logger.debug("Deleting selected shape(s)");
|
|
||||||
executeAndRefresh(new RemoveShapeCommand(model, selectedShapes));
|
|
||||||
resetSelection();
|
|
||||||
}
|
|
||||||
|
|
||||||
public void copySelection() {
|
|
||||||
List<Shape> selectedShapes = selection.getSelectedShapes();
|
|
||||||
if (selectedShapes.isEmpty()) {
|
|
||||||
logger.debug("No selection to copy");
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
clipboard = selectedShapes.stream()
|
|
||||||
.map(Shape::clone)
|
|
||||||
.toList();
|
|
||||||
pasteCount = 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
public void cutSelection() {
|
|
||||||
List<Shape> selectedShapes = selection.getSelectedShapes();
|
|
||||||
if (selectedShapes.isEmpty()) {
|
|
||||||
logger.debug("No selection to cut");
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
clipboard = selectedShapes.stream()
|
|
||||||
.map(Shape::clone)
|
|
||||||
.toList();
|
|
||||||
pasteCount = 0;
|
|
||||||
|
|
||||||
for (Shape shape : selectedShapes) {
|
|
||||||
model.remove(shape);
|
|
||||||
}
|
|
||||||
resetSelection();
|
|
||||||
onModelChanged.run();
|
|
||||||
view.repaint();
|
|
||||||
}
|
|
||||||
|
|
||||||
public void pasteClipboard() {
|
|
||||||
if (clipboard.isEmpty()) {
|
|
||||||
logger.debug("Clipboard is empty");
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
pasteCount++;
|
|
||||||
int offset = PASTE_OFFSET * pasteCount;
|
|
||||||
|
|
||||||
resetSelection();
|
|
||||||
|
|
||||||
for (Shape original : clipboard) {
|
|
||||||
Shape clone = original.clone();
|
|
||||||
clone.translate(offset, offset);
|
|
||||||
model.add(clone);
|
|
||||||
selection.add(clone);
|
|
||||||
}
|
|
||||||
|
|
||||||
onModelChanged.run();
|
|
||||||
view.repaint();
|
|
||||||
}
|
|
||||||
|
|
||||||
public void group() {
|
|
||||||
List<Shape> selectedShapes = selection.getSelectedShapes();
|
|
||||||
if (selectedShapes.size() < 2) {
|
|
||||||
logger.debug("Need at least 2 shapes to group");
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
int minIndex = selectedShapes.stream()
|
|
||||||
.mapToInt(model::indexOf)
|
|
||||||
.min()
|
|
||||||
.orElse(0);
|
|
||||||
|
|
||||||
for (Shape shape : selectedShapes) {
|
|
||||||
model.remove(shape);
|
|
||||||
shape.addAttributes(new ovh.gasser.newshapes.attributes.SelectionAttributes(false));
|
|
||||||
}
|
|
||||||
|
|
||||||
Shape[] shapesArray = selectedShapes.toArray(new Shape[0]);
|
|
||||||
SCollection group = SCollection.of(shapesArray);
|
|
||||||
|
|
||||||
model.insert(minIndex, group);
|
|
||||||
resetSelection();
|
|
||||||
selection.add(group);
|
|
||||||
onModelChanged.run();
|
|
||||||
view.repaint();
|
|
||||||
}
|
|
||||||
|
|
||||||
public void ungroup() {
|
|
||||||
List<Shape> selectedShapes = selection.getSelectedShapes();
|
|
||||||
if (selectedShapes.size() != 1) {
|
|
||||||
logger.debug("Can only ungroup a single selected group");
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
Shape selected = selectedShapes.get(0);
|
|
||||||
if (!(selected instanceof SCollection group)) {
|
|
||||||
logger.debug("Selected shape is not a group");
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
List<Shape> children = new ArrayList<>();
|
|
||||||
group.forEach(children::add);
|
|
||||||
|
|
||||||
model.remove(group);
|
|
||||||
|
|
||||||
for (Shape child : children) {
|
|
||||||
model.add(child);
|
|
||||||
}
|
|
||||||
|
|
||||||
resetSelection();
|
|
||||||
for (Shape child : children) {
|
|
||||||
selection.add(child);
|
|
||||||
}
|
|
||||||
onModelChanged.run();
|
|
||||||
view.repaint();
|
|
||||||
}
|
|
||||||
|
|
||||||
public void changeSelectionColor() {
|
|
||||||
changeColors(shape -> new ColorAttributes(false, true, Color.BLACK, randomColor()));
|
|
||||||
}
|
|
||||||
|
|
||||||
public void changeSelectionFillColor(Color filledColor) {
|
|
||||||
if (filledColor == null) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
changeColors(shape -> {
|
|
||||||
ColorAttributes current = currentColor(shape);
|
|
||||||
if (shape instanceof SText) {
|
|
||||||
return new ColorAttributes(current.filled, current.stroked, filledColor, filledColor);
|
|
||||||
}
|
|
||||||
return new ColorAttributes(true, current.stroked, filledColor, current.strokedColor);
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
public void changeSelectionBorderColor(Color strokedColor) {
|
|
||||||
if (strokedColor == null) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
changeColors(shape -> {
|
|
||||||
ColorAttributes current = currentColor(shape);
|
|
||||||
if (shape instanceof SText) {
|
|
||||||
return new ColorAttributes(current.filled, current.stroked, strokedColor, strokedColor);
|
|
||||||
}
|
|
||||||
return new ColorAttributes(current.filled, true, current.filledColor, strokedColor);
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
public void setSelectionBorder(boolean state) {
|
|
||||||
changeColors(shape -> {
|
|
||||||
if (shape instanceof SText) {
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
ColorAttributes current = currentColor(shape);
|
|
||||||
return new ColorAttributes(current.filled, state, current.filledColor, current.strokedColor);
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
public void setSelectionFilled(boolean state) {
|
|
||||||
changeColors(shape -> {
|
|
||||||
if (shape instanceof SText) {
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
ColorAttributes current = currentColor(shape);
|
|
||||||
return new ColorAttributes(state, current.stroked, current.filledColor, current.strokedColor);
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
private void handleMouseDragged(MouseEvent evt) {
|
private void handleMouseDragged(MouseEvent evt) {
|
||||||
if (boxSelecting) {
|
if (boxSelecting) {
|
||||||
selectionBoxEnd = evt.getPoint();
|
selectionBoxEnd = evt.getPoint();
|
||||||
@@ -352,19 +84,35 @@ public class Controller {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
boxSelecting = false;
|
||||||
|
|
||||||
if (resizeMode && resizing && activeHandle != null) {
|
if (resizeMode && resizing && activeHandle != null) {
|
||||||
|
logger.debug("RESIZING with handle {} at ({}, {})", activeHandle, evt.getX(), evt.getY());
|
||||||
int dx = evt.getX() - resizeOrigin.x;
|
int dx = evt.getX() - resizeOrigin.x;
|
||||||
int dy = evt.getY() - resizeOrigin.y;
|
int dy = evt.getY() - resizeOrigin.y;
|
||||||
|
logger.debug("About to resize {} shapes, dx={}, dy={}", selection.getSelectedShapes().size(), dx, dy);
|
||||||
for (Shape shape : selection) {
|
for (Shape shape : selection) {
|
||||||
|
logger.debug("Calling resize on shape: {}", shape);
|
||||||
shape.resize(activeHandle, dx, dy);
|
shape.resize(activeHandle, dx, dy);
|
||||||
}
|
}
|
||||||
resizeOrigin = evt.getPoint();
|
resizeOrigin = evt.getPoint();
|
||||||
} else if (!selection.isEmpty()) {
|
} else if (resizeMode && !selection.isEmpty()) {
|
||||||
|
lastMousePos = evt.getPoint();
|
||||||
|
ResizeHandle handle = getHandleAt(evt.getPoint());
|
||||||
|
if (handle != null) {
|
||||||
|
resizing = true;
|
||||||
|
activeHandle = handle;
|
||||||
|
resizeOrigin = evt.getPoint();
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
resizing = false;
|
||||||
|
activeHandle = null;
|
||||||
if (lastMousePos == null) {
|
if (lastMousePos == null) {
|
||||||
lastMousePos = evt.getPoint();
|
lastMousePos = evt.getPoint();
|
||||||
}
|
}
|
||||||
int dx = evt.getX() - lastMousePos.x;
|
int dx = evt.getX() - lastMousePos.x;
|
||||||
int dy = evt.getY() - lastMousePos.y;
|
int dy = evt.getY() - lastMousePos.y;
|
||||||
|
logger.debug("MOVING shapes with delta ({}, {})", dx, dy);
|
||||||
for (Shape shape : selection) {
|
for (Shape shape : selection) {
|
||||||
shape.translate(dx, dy);
|
shape.translate(dx, dy);
|
||||||
}
|
}
|
||||||
@@ -379,17 +127,18 @@ public class Controller {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
resizeDragState();
|
resizing = false;
|
||||||
boxSelecting = false;
|
activeHandle = null;
|
||||||
view.setCurrentSelectionBox(null);
|
resizeOrigin = null;
|
||||||
|
boxSelecting = false; // Clear box selection mode when clicking
|
||||||
|
|
||||||
if (resizeMode && !selection.isEmpty()) {
|
if (resizeMode && !selection.isEmpty()) {
|
||||||
ResizeHandle handle = getHandleAt(evt.getPoint());
|
ResizeHandle handle = getHandleAt(evt.getPoint());
|
||||||
|
logger.debug("In resize mode, checking handle at ({}, {}): {}", evt.getX(), evt.getY(), handle);
|
||||||
if (handle != null) {
|
if (handle != null) {
|
||||||
resizing = true;
|
resizing = true;
|
||||||
activeHandle = handle;
|
activeHandle = handle;
|
||||||
resizeOrigin = evt.getPoint();
|
resizeOrigin = evt.getPoint();
|
||||||
beginDrag(evt.getPoint());
|
|
||||||
view.repaint();
|
view.repaint();
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
@@ -402,86 +151,96 @@ public class Controller {
|
|||||||
resetSelection();
|
resetSelection();
|
||||||
}
|
}
|
||||||
if (!selection.getSelectedShapes().contains(s)) {
|
if (!selection.getSelectedShapes().contains(s)) {
|
||||||
|
lastMousePos = evt.getPoint();
|
||||||
selection.add(s);
|
selection.add(s);
|
||||||
|
logger.debug("Selecting {}", s);
|
||||||
}
|
}
|
||||||
beginDrag(evt.getPoint());
|
|
||||||
},
|
},
|
||||||
() -> {
|
() -> {
|
||||||
additiveBoxSelection = evt.isShiftDown();
|
// Clicked on empty space - start box selection
|
||||||
if (!additiveBoxSelection) {
|
resetSelection();
|
||||||
resetSelection();
|
|
||||||
}
|
|
||||||
selectionBoxStart = evt.getPoint();
|
selectionBoxStart = evt.getPoint();
|
||||||
selectionBoxEnd = evt.getPoint();
|
|
||||||
boxSelecting = true;
|
boxSelecting = true;
|
||||||
dragStartMousePos = null;
|
|
||||||
dragStartBounds = Map.of();
|
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
private void handleMouseReleased(MouseEvent evt) {
|
private void placeTextAt(Point point) {
|
||||||
finishDragCommand();
|
String input = JOptionPane.showInputDialog(view, "Enter text:", "Add text", JOptionPane.PLAIN_MESSAGE);
|
||||||
resizeDragState();
|
addingText = false;
|
||||||
boxSelecting = false;
|
if (input == null) {
|
||||||
selectionBoxStart = null;
|
return;
|
||||||
selectionBoxEnd = null;
|
}
|
||||||
dragStartMousePos = null;
|
|
||||||
dragStartBounds = Map.of();
|
model.add(SText.create(point.x, point.y, input));
|
||||||
view.setCurrentSelectionBox(null);
|
resetSelection();
|
||||||
view.repaint();
|
view.repaint();
|
||||||
}
|
}
|
||||||
|
|
||||||
private void handleKeyPressed(KeyEvent evt) {
|
public void enterTextMode() {
|
||||||
int modifiers = evt.getModifiersEx();
|
addingText = true;
|
||||||
|
}
|
||||||
|
|
||||||
if ((modifiers & InputEvent.CTRL_DOWN_MASK) != 0) {
|
private ResizeHandle getHandleAt(Point point) {
|
||||||
switch (evt.getKeyCode()) {
|
final int handleSize = 10;
|
||||||
case KeyEvent.VK_Z -> {
|
for (Shape shape : selection) {
|
||||||
if ((modifiers & InputEvent.SHIFT_DOWN_MASK) != 0) {
|
Rectangle bounds = shape.getBounds();
|
||||||
redo();
|
|
||||||
} else {
|
// Always-present SE corner handle
|
||||||
undo();
|
if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
|
||||||
}
|
point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
|
||||||
evt.consume();
|
return ResizeHandle.SE;
|
||||||
return;
|
}
|
||||||
|
|
||||||
|
// Resize handles are only active in resize mode
|
||||||
|
if (resizeMode) {
|
||||||
|
// NW corner
|
||||||
|
if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
|
||||||
|
point.y >= bounds.y - handleSize && point.y <= bounds.y) {
|
||||||
|
return ResizeHandle.NW;
|
||||||
}
|
}
|
||||||
case KeyEvent.VK_Y -> {
|
// NE corner
|
||||||
redo();
|
if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
|
||||||
evt.consume();
|
point.y >= bounds.y - handleSize && point.y <= bounds.y) {
|
||||||
return;
|
return ResizeHandle.NE;
|
||||||
}
|
}
|
||||||
case KeyEvent.VK_C -> {
|
// SW corner
|
||||||
copySelection();
|
if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
|
||||||
evt.consume();
|
point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
|
||||||
return;
|
return ResizeHandle.SW;
|
||||||
}
|
}
|
||||||
case KeyEvent.VK_X -> {
|
// N edge
|
||||||
cutSelection();
|
int edgeX = bounds.x + bounds.width / 2 - handleSize / 2;
|
||||||
evt.consume();
|
if (point.x >= edgeX && point.x <= edgeX + handleSize &&
|
||||||
return;
|
point.y >= bounds.y - handleSize && point.y <= bounds.y) {
|
||||||
|
return ResizeHandle.N;
|
||||||
}
|
}
|
||||||
case KeyEvent.VK_V -> {
|
// S edge
|
||||||
pasteClipboard();
|
if (point.x >= edgeX && point.x <= edgeX + handleSize &&
|
||||||
evt.consume();
|
point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
|
||||||
return;
|
return ResizeHandle.S;
|
||||||
}
|
}
|
||||||
case KeyEvent.VK_G -> {
|
// W edge
|
||||||
group();
|
int edgeY = bounds.y + bounds.height / 2 - handleSize / 2;
|
||||||
evt.consume();
|
if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
|
||||||
return;
|
point.y >= edgeY && point.y <= edgeY + handleSize) {
|
||||||
|
return ResizeHandle.W;
|
||||||
}
|
}
|
||||||
case KeyEvent.VK_U -> {
|
// E edge
|
||||||
ungroup();
|
if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
|
||||||
evt.consume();
|
point.y >= edgeY && point.y <= edgeY + handleSize) {
|
||||||
return;
|
return ResizeHandle.E;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
private void handleKeyPressed(KeyEvent evt) {
|
||||||
switch (evt.getKeyCode()) {
|
switch (evt.getKeyCode()) {
|
||||||
case KeyEvent.VK_R -> toggleResizeMode();
|
case KeyEvent.VK_R -> toggleResizeMode();
|
||||||
case KeyEvent.VK_DELETE -> deleteSelected();
|
case KeyEvent.VK_DELETE -> deleteSelected();
|
||||||
|
case KeyEvent.VK_C -> copySelection();
|
||||||
case KeyEvent.VK_A -> changeSelectionColor();
|
case KeyEvent.VK_A -> changeSelectionColor();
|
||||||
case KeyEvent.VK_H -> exportHtml();
|
case KeyEvent.VK_H -> exportHtml();
|
||||||
default -> logger.warn("Pressed unhandled key: {}", evt.getKeyChar());
|
default -> logger.warn("Pressed unhandled key: {}", evt.getKeyChar());
|
||||||
@@ -505,134 +264,55 @@ public class Controller {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
private void placeTextAt(Point point) {
|
private void changeSelectionColor(){
|
||||||
String input = JOptionPane.showInputDialog(view, "Enter text:", "Add text", JOptionPane.PLAIN_MESSAGE);
|
if (selection == null) {
|
||||||
addingText = false;
|
logger.debug("No selection to change color of");
|
||||||
if (input == null) {
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
addShape(SText.create(point.x, point.y, input));
|
for (Shape s : selection) {
|
||||||
resetSelection();
|
if (s instanceof SCollection collection) {
|
||||||
|
collection.forEach(shape -> shape.addAttributes(new ColorAttributes(false, true, Color.BLACK, new Color((int) (Math.random() * 0x1000000)))));
|
||||||
|
} else {
|
||||||
|
s.addAttributes(new ColorAttributes(false, true, Color.BLACK, new Color((int) (Math.random() * 0x1000000))));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
view.repaint();
|
||||||
}
|
}
|
||||||
|
|
||||||
private ResizeHandle getHandleAt(Point point) {
|
private void copySelection() {
|
||||||
final int handleSize = 10;
|
if (selection == null) {
|
||||||
|
logger.debug("No selection to copy");
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
for (Shape shape : selection) {
|
for (Shape shape : selection) {
|
||||||
Rectangle bounds = shape.getBounds();
|
this.model.add(shape.clone());
|
||||||
|
|
||||||
if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
|
|
||||||
point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
|
|
||||||
return ResizeHandle.SE;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (resizeMode) {
|
|
||||||
if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
|
|
||||||
point.y >= bounds.y - handleSize && point.y <= bounds.y) {
|
|
||||||
return ResizeHandle.NW;
|
|
||||||
}
|
|
||||||
if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
|
|
||||||
point.y >= bounds.y - handleSize && point.y <= bounds.y) {
|
|
||||||
return ResizeHandle.NE;
|
|
||||||
}
|
|
||||||
if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
|
|
||||||
point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
|
|
||||||
return ResizeHandle.SW;
|
|
||||||
}
|
|
||||||
int edgeX = bounds.x + bounds.width / 2 - handleSize / 2;
|
|
||||||
if (point.x >= edgeX && point.x <= edgeX + handleSize &&
|
|
||||||
point.y >= bounds.y - handleSize && point.y <= bounds.y) {
|
|
||||||
return ResizeHandle.N;
|
|
||||||
}
|
|
||||||
if (point.x >= edgeX && point.x <= edgeX + handleSize &&
|
|
||||||
point.y >= bounds.y + bounds.height && point.y <= bounds.y + bounds.height + handleSize) {
|
|
||||||
return ResizeHandle.S;
|
|
||||||
}
|
|
||||||
int edgeY = bounds.y + bounds.height / 2 - handleSize / 2;
|
|
||||||
if (point.x >= bounds.x - handleSize && point.x <= bounds.x &&
|
|
||||||
point.y >= edgeY && point.y <= edgeY + handleSize) {
|
|
||||||
return ResizeHandle.W;
|
|
||||||
}
|
|
||||||
if (point.x >= bounds.x + bounds.width && point.x <= bounds.x + bounds.width + handleSize &&
|
|
||||||
point.y >= edgeY && point.y <= edgeY + handleSize) {
|
|
||||||
return ResizeHandle.E;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
return null;
|
|
||||||
|
view.repaint();
|
||||||
}
|
}
|
||||||
|
|
||||||
private void changeColors(Function<Shape, ColorAttributes> updater) {
|
public void deleteSelected() {
|
||||||
Map<Shape, ColorAttributes> before = new LinkedHashMap<>();
|
if (selection == null) return;
|
||||||
Map<Shape, ColorAttributes> after = new LinkedHashMap<>();
|
logger.debug("Deleting selected shape(s)");
|
||||||
List<Shape> targets = flattenSelection(selection.getSelectedShapes());
|
for (Shape s : selection) {
|
||||||
|
this.model.remove(s);
|
||||||
for (Shape shape : targets) {
|
|
||||||
ColorAttributes current = currentColor(shape);
|
|
||||||
if (current == null) {
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
ColorAttributes updated = updater.apply(shape);
|
|
||||||
if (updated == null || sameColor(current, updated)) {
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
before.put(shape, copy(current));
|
|
||||||
after.put(shape, copy(updated));
|
|
||||||
}
|
}
|
||||||
|
resetSelection();
|
||||||
if (before.isEmpty()) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
executeAndRefresh(new ChangeColorCommand(before.keySet(), before, after));
|
|
||||||
}
|
|
||||||
|
|
||||||
private void beginDrag(Point point) {
|
|
||||||
lastMousePos = point;
|
|
||||||
dragStartMousePos = point;
|
|
||||||
dragStartBounds = captureBounds(selection.getSelectedShapes());
|
|
||||||
}
|
|
||||||
|
|
||||||
private void finishDragCommand() {
|
|
||||||
if (boxSelecting || dragStartBounds.isEmpty()) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
List<Shape> selectedShapes = selection.getSelectedShapes();
|
|
||||||
if (selectedShapes.isEmpty()) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (resizing && boundsChanged(selectedShapes, dragStartBounds)) {
|
|
||||||
Map<Shape, Rectangle> afterBounds = captureBounds(selectedShapes);
|
|
||||||
Command command = new ResizeShapeCommand(selectedShapes, dragStartBounds, afterBounds);
|
|
||||||
command.undo();
|
|
||||||
executeAndRefresh(command);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (boundsChanged(selectedShapes, dragStartBounds)) {
|
|
||||||
Shape reference = selectedShapes.get(0);
|
|
||||||
Rectangle before = dragStartBounds.get(reference);
|
|
||||||
Rectangle after = reference.getBounds();
|
|
||||||
Command command = new MoveShapeCommand(selectedShapes, after.x - before.x, after.y - before.y);
|
|
||||||
command.undo();
|
|
||||||
executeAndRefresh(command);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
private void executeAndRefresh(Command command) {
|
|
||||||
commandHistory.execute(command);
|
|
||||||
onModelChanged.run();
|
|
||||||
view.repaint();
|
view.repaint();
|
||||||
}
|
}
|
||||||
|
|
||||||
private void resetSelection() {
|
private void resetSelection() {
|
||||||
|
logger.debug("Resetting selection");
|
||||||
selection.clear();
|
selection.clear();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public void addSelectionChangeListener(SelectionListener listener) {
|
||||||
|
selection.addListener(listener);
|
||||||
|
}
|
||||||
|
|
||||||
private Optional<Shape> getTarget(MouseEvent evt, SCollection sc) {
|
private Optional<Shape> getTarget(MouseEvent evt, SCollection sc) {
|
||||||
return sc.stream()
|
return sc.stream()
|
||||||
.filter(s -> s.getBounds().contains(evt.getPoint()))
|
.filter(s -> s.getBounds().contains(evt.getPoint()))
|
||||||
@@ -648,71 +328,9 @@ public class Controller {
|
|||||||
}
|
}
|
||||||
|
|
||||||
private void updateSelectionFromBox(Rectangle box) {
|
private void updateSelectionFromBox(Rectangle box) {
|
||||||
if (!additiveBoxSelection) {
|
resetSelection();
|
||||||
resetSelection();
|
|
||||||
}
|
|
||||||
model.stream()
|
model.stream()
|
||||||
.filter(s -> s.getBounds().intersects(box))
|
.filter(s -> s.getBounds().intersects(box))
|
||||||
.forEach(selection::add);
|
.forEach(selection::add);
|
||||||
}
|
}
|
||||||
|
|
||||||
private void resizeDragState() {
|
|
||||||
resizing = false;
|
|
||||||
activeHandle = null;
|
|
||||||
resizeOrigin = null;
|
|
||||||
lastMousePos = null;
|
|
||||||
}
|
|
||||||
|
|
||||||
private Map<Shape, Rectangle> captureBounds(Collection<Shape> shapes) {
|
|
||||||
Map<Shape, Rectangle> bounds = new LinkedHashMap<>();
|
|
||||||
for (Shape shape : shapes) {
|
|
||||||
bounds.put(shape, shape.getBounds());
|
|
||||||
}
|
|
||||||
return bounds;
|
|
||||||
}
|
|
||||||
|
|
||||||
private boolean boundsChanged(Collection<Shape> shapes, Map<Shape, Rectangle> before) {
|
|
||||||
for (Shape shape : shapes) {
|
|
||||||
Rectangle previous = before.get(shape);
|
|
||||||
if (previous != null && !previous.equals(shape.getBounds())) {
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
private List<Shape> flattenSelection(Collection<Shape> selectedShapes) {
|
|
||||||
LinkedHashSet<Shape> flattened = new LinkedHashSet<>();
|
|
||||||
for (Shape shape : selectedShapes) {
|
|
||||||
flattenShape(shape, flattened);
|
|
||||||
}
|
|
||||||
return new ArrayList<>(flattened);
|
|
||||||
}
|
|
||||||
|
|
||||||
private void flattenShape(Shape shape, Collection<Shape> flattened) {
|
|
||||||
if (shape instanceof SCollection collection) {
|
|
||||||
collection.forEach(child -> flattenShape(child, flattened));
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
flattened.add(shape);
|
|
||||||
}
|
|
||||||
|
|
||||||
private ColorAttributes currentColor(Shape shape) {
|
|
||||||
return (ColorAttributes) shape.getAttributes(ColorAttributes.ID);
|
|
||||||
}
|
|
||||||
|
|
||||||
private ColorAttributes copy(ColorAttributes attrs) {
|
|
||||||
return new ColorAttributes(attrs.filled, attrs.stroked, attrs.filledColor, attrs.strokedColor);
|
|
||||||
}
|
|
||||||
|
|
||||||
private boolean sameColor(ColorAttributes left, ColorAttributes right) {
|
|
||||||
return left.filled == right.filled
|
|
||||||
&& left.stroked == right.stroked
|
|
||||||
&& left.filledColor.equals(right.filledColor)
|
|
||||||
&& left.strokedColor.equals(right.strokedColor);
|
|
||||||
}
|
|
||||||
|
|
||||||
private Color randomColor() {
|
|
||||||
return new Color((int) (Math.random() * 0x1000000));
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -117,30 +117,6 @@ public class ShapeDraftman implements ShapeVisitor {
|
|||||||
drawHandlerIfSelected(text);
|
drawHandlerIfSelected(text);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
|
||||||
public void visitPolygon(SPolygon polygon) {
|
|
||||||
ColorAttributes colAttrs = (ColorAttributes) polygon.getAttributes(ColorAttributes.ID);
|
|
||||||
if (colAttrs == null) {
|
|
||||||
colAttrs = DEFAULT_COLOR_ATTRIBUTES;
|
|
||||||
}
|
|
||||||
|
|
||||||
java.util.List<Point> points = polygon.getPoints();
|
|
||||||
int[] xPoints = points.stream().mapToInt(p -> p.x).toArray();
|
|
||||||
int[] yPoints = points.stream().mapToInt(p -> p.y).toArray();
|
|
||||||
int nPoints = points.size();
|
|
||||||
|
|
||||||
if (colAttrs.filled) {
|
|
||||||
this.g2d.setColor(colAttrs.filledColor);
|
|
||||||
this.g2d.fillPolygon(xPoints, yPoints, nPoints);
|
|
||||||
}
|
|
||||||
if (colAttrs.stroked) {
|
|
||||||
this.g2d.setColor(colAttrs.strokedColor);
|
|
||||||
this.g2d.drawPolygon(xPoints, yPoints, nPoints);
|
|
||||||
}
|
|
||||||
|
|
||||||
drawHandlerIfSelected(polygon);
|
|
||||||
}
|
|
||||||
|
|
||||||
private Color resolveTextColor(ColorAttributes attrs) {
|
private Color resolveTextColor(ColorAttributes attrs) {
|
||||||
if (attrs == null) {
|
if (attrs == null) {
|
||||||
return Color.BLACK;
|
return Color.BLACK;
|
||||||
|
|||||||
@@ -16,12 +16,8 @@ public class ShapesView extends JPanel {
|
|||||||
private Rectangle currentSelectionBox;
|
private Rectangle currentSelectionBox;
|
||||||
|
|
||||||
public ShapesView(SCollection model) {
|
public ShapesView(SCollection model) {
|
||||||
this(model, () -> { });
|
|
||||||
}
|
|
||||||
|
|
||||||
public ShapesView(SCollection model, Runnable onModelChanged) {
|
|
||||||
this.model = model;
|
this.model = model;
|
||||||
this.controller = new Controller(this, model, onModelChanged);
|
this.controller = new Controller(this, model);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
|||||||
387
src/test/java/ovh/gasser/newshapes/shapes/ContainsPointTest.java
Normal file
387
src/test/java/ovh/gasser/newshapes/shapes/ContainsPointTest.java
Normal file
@@ -0,0 +1,387 @@
|
|||||||
|
package ovh.gasser.newshapes.shapes;
|
||||||
|
|
||||||
|
import org.junit.jupiter.api.Nested;
|
||||||
|
import org.junit.jupiter.api.Test;
|
||||||
|
|
||||||
|
import java.awt.Color;
|
||||||
|
import java.awt.Point;
|
||||||
|
|
||||||
|
import static org.junit.jupiter.api.Assertions.*;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Tests bounds-based hit-testing for all shape types.
|
||||||
|
* Hit-testing is performed via {@code shape.getBounds().contains(Point)},
|
||||||
|
* delegating to {@link java.awt.Rectangle#contains(Point)}.
|
||||||
|
*
|
||||||
|
* <p>Note on {@link java.awt.Rectangle#contains} boundary semantics:
|
||||||
|
* A rectangle {@code (x, y, w, h)} contains a point {@code (px, py)} when:
|
||||||
|
* {@code x <= px < x+w} and {@code y <= py < y+h}.
|
||||||
|
* The top-left corner is <em>inclusive</em>; the bottom-right corner is <em>exclusive</em>.
|
||||||
|
*/
|
||||||
|
class ContainsPointTest {
|
||||||
|
|
||||||
|
// -----------------------------------------------------------------------
|
||||||
|
// SRectangle — bounds = (x, y, width, height)
|
||||||
|
// -----------------------------------------------------------------------
|
||||||
|
|
||||||
|
@Nested
|
||||||
|
class SRectangleContainsPoint {
|
||||||
|
|
||||||
|
// Shape: origin (10, 20), size 80×60 → right-exclusive: x=90, y=80
|
||||||
|
private final SRectangle rect = SRectangle.create(10, 20, 80, 60);
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointInsideShouldBeContained() {
|
||||||
|
Point inside = new Point(50, 50);
|
||||||
|
assertTrue(rect.getBounds().contains(inside),
|
||||||
|
"A point clearly inside the rectangle should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointOutsideShouldNotBeContained() {
|
||||||
|
Point outside = new Point(5, 5);
|
||||||
|
assertFalse(rect.getBounds().contains(outside),
|
||||||
|
"A point outside the rectangle should not be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointFarOutsideShouldNotBeContained() {
|
||||||
|
Point farOutside = new Point(200, 300);
|
||||||
|
assertFalse(rect.getBounds().contains(farOutside),
|
||||||
|
"A point far outside the rectangle should not be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void topLeftCornerShouldBeContained() {
|
||||||
|
// Rectangle.contains is inclusive of the top-left corner
|
||||||
|
Point topLeft = new Point(10, 20);
|
||||||
|
assertTrue(rect.getBounds().contains(topLeft),
|
||||||
|
"The top-left corner (inclusive boundary) should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void bottomRightCornerShouldNotBeContained() {
|
||||||
|
// Rectangle.contains is exclusive of the bottom-right corner
|
||||||
|
Point bottomRight = new Point(90, 80); // x + width, y + height
|
||||||
|
assertFalse(rect.getBounds().contains(bottomRight),
|
||||||
|
"The bottom-right corner (exclusive boundary) should not be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointJustInsideBottomRightShouldBeContained() {
|
||||||
|
Point justInside = new Point(89, 79); // one pixel before exclusive boundary
|
||||||
|
assertTrue(rect.getBounds().contains(justInside),
|
||||||
|
"A point one pixel before the bottom-right boundary should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointAfterTranslateShouldBeAtNewPosition() {
|
||||||
|
SRectangle moved = SRectangle.create(10, 20, 80, 60);
|
||||||
|
moved.translate(30, 40); // new bounds: (40, 60, 80, 60)
|
||||||
|
|
||||||
|
Point oldCenter = new Point(50, 50);
|
||||||
|
assertFalse(moved.getBounds().contains(oldCenter),
|
||||||
|
"After translate, old center should no longer be contained");
|
||||||
|
|
||||||
|
Point newCenter = new Point(80, 90);
|
||||||
|
assertTrue(moved.getBounds().contains(newCenter),
|
||||||
|
"After translate, a point at the new center should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointOnTopEdgeShouldBeContained() {
|
||||||
|
Point topEdge = new Point(50, 20); // y == rect.y, inside x range
|
||||||
|
assertTrue(rect.getBounds().contains(topEdge),
|
||||||
|
"A point on the top edge should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointOnLeftEdgeShouldBeContained() {
|
||||||
|
Point leftEdge = new Point(10, 50); // x == rect.x, inside y range
|
||||||
|
assertTrue(rect.getBounds().contains(leftEdge),
|
||||||
|
"A point on the left edge should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointOnRightEdgeShouldNotBeContained() {
|
||||||
|
Point rightEdge = new Point(90, 50); // x == rect.x + rect.width (exclusive)
|
||||||
|
assertFalse(rect.getBounds().contains(rightEdge),
|
||||||
|
"A point exactly on the right edge (exclusive) should not be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointOnBottomEdgeShouldNotBeContained() {
|
||||||
|
Point bottomEdge = new Point(50, 80); // y == rect.y + rect.height (exclusive)
|
||||||
|
assertFalse(rect.getBounds().contains(bottomEdge),
|
||||||
|
"A point exactly on the bottom edge (exclusive) should not be contained");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// -----------------------------------------------------------------------
|
||||||
|
// SCircle — bounds = (x, y, radius*2, radius*2)
|
||||||
|
// -----------------------------------------------------------------------
|
||||||
|
|
||||||
|
@Nested
|
||||||
|
class SCircleContainsPoint {
|
||||||
|
|
||||||
|
// Shape: origin (20, 30), radius=40 → bounds (20, 30, 80, 80)
|
||||||
|
// right-exclusive corner: (100, 110)
|
||||||
|
private final SCircle circle = SCircle.create(20, 30, 40);
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointInsideBoundsShouldBeContained() {
|
||||||
|
Point inside = new Point(60, 70);
|
||||||
|
assertTrue(circle.getBounds().contains(inside),
|
||||||
|
"A point inside the bounding box should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointOutsideBoundsShouldNotBeContained() {
|
||||||
|
Point outside = new Point(10, 10);
|
||||||
|
assertFalse(circle.getBounds().contains(outside),
|
||||||
|
"A point outside the bounding box should not be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void topLeftCornerShouldBeContained() {
|
||||||
|
Point topLeft = new Point(20, 30);
|
||||||
|
assertTrue(circle.getBounds().contains(topLeft),
|
||||||
|
"The top-left corner of the bounding box (inclusive) should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void bottomRightCornerShouldNotBeContained() {
|
||||||
|
Point bottomRight = new Point(100, 110); // x + 2r, y + 2r
|
||||||
|
assertFalse(circle.getBounds().contains(bottomRight),
|
||||||
|
"The bottom-right corner of the bounding box (exclusive) should not be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointAfterTranslateShouldBeAtNewPosition() {
|
||||||
|
SCircle moved = SCircle.create(20, 30, 40);
|
||||||
|
moved.translate(50, 50); // new bounds: (70, 80, 80, 80)
|
||||||
|
|
||||||
|
Point oldCenter = new Point(60, 70);
|
||||||
|
assertFalse(moved.getBounds().contains(oldCenter),
|
||||||
|
"After translate, old center should no longer be contained");
|
||||||
|
|
||||||
|
Point newCenter = new Point(110, 120);
|
||||||
|
assertTrue(moved.getBounds().contains(newCenter),
|
||||||
|
"After translate, a point at the new center should be contained");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// -----------------------------------------------------------------------
|
||||||
|
// STriangle — bounds = (x, y, size, size)
|
||||||
|
// -----------------------------------------------------------------------
|
||||||
|
|
||||||
|
@Nested
|
||||||
|
class STriangleContainsPoint {
|
||||||
|
|
||||||
|
// Shape: origin (5, 15), size=60 → bounds (5, 15, 60, 60)
|
||||||
|
// right-exclusive corner: (65, 75)
|
||||||
|
private final STriangle triangle = STriangle.create(5, 15, 60, Color.RED, Color.BLACK);
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointInsideBoundsShouldBeContained() {
|
||||||
|
Point inside = new Point(35, 45);
|
||||||
|
assertTrue(triangle.getBounds().contains(inside),
|
||||||
|
"A point inside the bounding box should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointOutsideBoundsShouldNotBeContained() {
|
||||||
|
Point outside = new Point(0, 0);
|
||||||
|
assertFalse(triangle.getBounds().contains(outside),
|
||||||
|
"A point outside the bounding box should not be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void topLeftCornerShouldBeContained() {
|
||||||
|
Point topLeft = new Point(5, 15);
|
||||||
|
assertTrue(triangle.getBounds().contains(topLeft),
|
||||||
|
"The top-left corner of the bounding box (inclusive) should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void bottomRightCornerShouldNotBeContained() {
|
||||||
|
Point bottomRight = new Point(65, 75); // x + size, y + size
|
||||||
|
assertFalse(triangle.getBounds().contains(bottomRight),
|
||||||
|
"The bottom-right corner of the bounding box (exclusive) should not be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointAfterTranslateShouldBeAtNewPosition() {
|
||||||
|
STriangle moved = STriangle.create(5, 15, 60, Color.RED, Color.BLACK);
|
||||||
|
moved.translate(100, 100); // new bounds: (105, 115, 60, 60)
|
||||||
|
|
||||||
|
Point oldCenter = new Point(35, 45);
|
||||||
|
assertFalse(moved.getBounds().contains(oldCenter),
|
||||||
|
"After translate, old center should no longer be contained");
|
||||||
|
|
||||||
|
Point newCenter = new Point(135, 145);
|
||||||
|
assertTrue(moved.getBounds().contains(newCenter),
|
||||||
|
"After translate, a point at the new center should be contained");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// -----------------------------------------------------------------------
|
||||||
|
// SText — bounds = (x, y, 100, 20)
|
||||||
|
// -----------------------------------------------------------------------
|
||||||
|
|
||||||
|
@Nested
|
||||||
|
class STextContainsPoint {
|
||||||
|
|
||||||
|
// Shape: origin (50, 100) → bounds (50, 100, 100, 20)
|
||||||
|
// right-exclusive corner: (150, 120)
|
||||||
|
private final SText text = SText.create(50, 100, "Hello");
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointInsideBoundsShouldBeContained() {
|
||||||
|
Point inside = new Point(100, 110);
|
||||||
|
assertTrue(text.getBounds().contains(inside),
|
||||||
|
"A point inside the default text bounding box should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointOutsideBoundsShouldNotBeContained() {
|
||||||
|
Point outside = new Point(10, 10);
|
||||||
|
assertFalse(text.getBounds().contains(outside),
|
||||||
|
"A point outside the text bounding box should not be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void topLeftCornerShouldBeContained() {
|
||||||
|
Point topLeft = new Point(50, 100);
|
||||||
|
assertTrue(text.getBounds().contains(topLeft),
|
||||||
|
"The top-left corner of the text bounding box (inclusive) should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void bottomRightCornerShouldNotBeContained() {
|
||||||
|
// Default bounds width=100, height=20 → exclusive corner at (150, 120)
|
||||||
|
Point bottomRight = new Point(150, 120);
|
||||||
|
assertFalse(text.getBounds().contains(bottomRight),
|
||||||
|
"The bottom-right corner of the text bounding box (exclusive) should not be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointJustBeforeBottomRightShouldBeContained() {
|
||||||
|
Point justInside = new Point(149, 119);
|
||||||
|
assertTrue(text.getBounds().contains(justInside),
|
||||||
|
"A point one pixel before the exclusive bottom-right boundary should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointAfterTranslateShouldBeAtNewPosition() {
|
||||||
|
// Original bounds: (50, 100, 100, 20) — covers x∈[50,150), y∈[100,120)
|
||||||
|
SText moved = SText.create(50, 100, "Hello");
|
||||||
|
moved.translate(-40, 10); // new bounds: (10, 110, 100, 20) — covers x∈[10,110), y∈[110,130)
|
||||||
|
|
||||||
|
// (130, 105) was inside original bounds but is now outside (x=130 >= 110, y=105 < 110)
|
||||||
|
Point oldPosition = new Point(130, 105);
|
||||||
|
assertFalse(moved.getBounds().contains(oldPosition),
|
||||||
|
"After translate, a point that was in the old bounds should no longer be contained");
|
||||||
|
|
||||||
|
// (50, 115) is inside new bounds: x∈[10,110), y∈[110,130) ✓
|
||||||
|
Point newPosition = new Point(50, 115);
|
||||||
|
assertTrue(moved.getBounds().contains(newPosition),
|
||||||
|
"After translate, a point in the new bounds should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void blankTextUsesDefaultPlaceholderAndSameBounds() {
|
||||||
|
// Even blank/null text falls back to the placeholder — bounds remain (x, y, 100, 20)
|
||||||
|
SText blankText = SText.create(0, 0, "");
|
||||||
|
Point inside = new Point(50, 10);
|
||||||
|
assertTrue(blankText.getBounds().contains(inside),
|
||||||
|
"Blank text still uses default bounds; interior point should be contained");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// -----------------------------------------------------------------------
|
||||||
|
// SCollection — bounds = union of children bounds
|
||||||
|
// -----------------------------------------------------------------------
|
||||||
|
|
||||||
|
@Nested
|
||||||
|
class SCollectionContainsPoint {
|
||||||
|
|
||||||
|
// Two non-overlapping children:
|
||||||
|
// rect1: (10, 10, 50, 50) → covers x∈[10,60), y∈[10,60)
|
||||||
|
// rect2: (100, 100, 40, 40) → covers x∈[100,140), y∈[100,140)
|
||||||
|
// Union bounds: (10, 10, 130, 130) → exclusive corner: (140, 140)
|
||||||
|
private final SRectangle child1 = SRectangle.create(10, 10, 50, 50);
|
||||||
|
private final SRectangle child2 = SRectangle.create(100, 100, 40, 40);
|
||||||
|
private final SCollection collection = SCollection.of(child1, child2);
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointInsideFirstChildBoundsShouldBeContained() {
|
||||||
|
Point insideChild1 = new Point(30, 30);
|
||||||
|
assertTrue(collection.getBounds().contains(insideChild1),
|
||||||
|
"A point inside the first child's bounds is within the union and should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointInsideSecondChildBoundsShouldBeContained() {
|
||||||
|
Point insideChild2 = new Point(120, 120);
|
||||||
|
assertTrue(collection.getBounds().contains(insideChild2),
|
||||||
|
"A point inside the second child's bounds is within the union and should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointInGapBetweenChildrenShouldBeContained() {
|
||||||
|
// The union rectangle spans the gap between the two children
|
||||||
|
Point inGap = new Point(70, 70);
|
||||||
|
assertTrue(collection.getBounds().contains(inGap),
|
||||||
|
"A point in the gap between children is still inside the union bounds and should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointOutsideUnionShouldNotBeContained() {
|
||||||
|
Point outside = new Point(0, 0);
|
||||||
|
assertFalse(collection.getBounds().contains(outside),
|
||||||
|
"A point outside the union bounds should not be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void topLeftCornerOfUnionShouldBeContained() {
|
||||||
|
// Union top-left = (10, 10) — inclusive
|
||||||
|
Point topLeft = new Point(10, 10);
|
||||||
|
assertTrue(collection.getBounds().contains(topLeft),
|
||||||
|
"The top-left corner of the union bounds (inclusive) should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void bottomRightCornerOfUnionShouldNotBeContained() {
|
||||||
|
// Union: x=10, y=10, w=130, h=130 → exclusive corner (140, 140)
|
||||||
|
Point bottomRight = new Point(140, 140);
|
||||||
|
assertFalse(collection.getBounds().contains(bottomRight),
|
||||||
|
"The bottom-right corner of the union bounds (exclusive) should not be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void pointAfterTranslatingChildrenShouldBeAtNewPosition() {
|
||||||
|
SRectangle movableChild = SRectangle.create(0, 0, 30, 30);
|
||||||
|
SCollection movable = SCollection.of(movableChild);
|
||||||
|
|
||||||
|
movable.translate(50, 50); // child now at (50, 50, 30, 30)
|
||||||
|
|
||||||
|
Point oldPoint = new Point(15, 15);
|
||||||
|
assertFalse(movable.getBounds().contains(oldPoint),
|
||||||
|
"After translate, a point at the old location should not be contained");
|
||||||
|
|
||||||
|
Point newPoint = new Point(65, 65);
|
||||||
|
assertTrue(movable.getBounds().contains(newPoint),
|
||||||
|
"After translate, a point at the new location should be contained");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void singleChildCollectionBoundsMatchChildBounds() {
|
||||||
|
SRectangle only = SRectangle.create(5, 5, 20, 20);
|
||||||
|
SCollection single = SCollection.of(only);
|
||||||
|
|
||||||
|
assertEquals(only.getBounds(), single.getBounds(),
|
||||||
|
"A single-child collection's bounds should equal the child's own bounds");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
223
src/test/java/ovh/gasser/newshapes/shapes/EdgeCaseTest.java
Normal file
223
src/test/java/ovh/gasser/newshapes/shapes/EdgeCaseTest.java
Normal file
@@ -0,0 +1,223 @@
|
|||||||
|
package ovh.gasser.newshapes.shapes;
|
||||||
|
|
||||||
|
import ovh.gasser.newshapes.App;
|
||||||
|
import ovh.gasser.newshapes.attributes.SelectionAttributes;
|
||||||
|
import org.junit.jupiter.api.Nested;
|
||||||
|
import org.junit.jupiter.api.Test;
|
||||||
|
|
||||||
|
import java.awt.*;
|
||||||
|
|
||||||
|
import static org.junit.jupiter.api.Assertions.*;
|
||||||
|
|
||||||
|
class EdgeCaseTest {
|
||||||
|
|
||||||
|
// -------------------------------------------------------------------------
|
||||||
|
// NegativeCoordinates
|
||||||
|
// -------------------------------------------------------------------------
|
||||||
|
|
||||||
|
@Nested
|
||||||
|
class NegativeCoordinates {
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void rectangleAtNegativeCoordsShouldPreserveBounds() {
|
||||||
|
SRectangle rect = SRectangle.create(-10, -20, 50, 50);
|
||||||
|
Rectangle bounds = rect.getBounds();
|
||||||
|
assertEquals(-10, bounds.x, "x should be -10");
|
||||||
|
assertEquals(-20, bounds.y, "y should be -20");
|
||||||
|
assertEquals(50, bounds.width, "width should be 50");
|
||||||
|
assertEquals(50, bounds.height, "height should be 50");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void circleAtNegativeCoordsShouldPreserveBounds() {
|
||||||
|
SCircle circle = SCircle.create(-30, -40, 25);
|
||||||
|
Rectangle bounds = circle.getBounds();
|
||||||
|
assertEquals(-30, bounds.x, "x should be -30");
|
||||||
|
assertEquals(-40, bounds.y, "y should be -40");
|
||||||
|
assertEquals(50, bounds.width, "width should be radius*2 = 50");
|
||||||
|
assertEquals(50, bounds.height, "height should be radius*2 = 50");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void triangleAtNegativeCoordsShouldPreserveBounds() {
|
||||||
|
STriangle tri = STriangle.create(-5, -15, 60, Color.RED, Color.BLACK);
|
||||||
|
Rectangle bounds = tri.getBounds();
|
||||||
|
assertEquals(-5, bounds.x, "x should be -5");
|
||||||
|
assertEquals(-15, bounds.y, "y should be -15");
|
||||||
|
assertEquals(60, bounds.width, "width should be 60");
|
||||||
|
assertEquals(60, bounds.height, "height should be 60");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void translateToNegativePositionShouldUpdateBoundsCorrectly() {
|
||||||
|
SRectangle rect = SRectangle.create(10, 20, 80, 40);
|
||||||
|
rect.translate(-50, -70);
|
||||||
|
Rectangle bounds = rect.getBounds();
|
||||||
|
assertEquals(-40, bounds.x, "x after translate should be -40");
|
||||||
|
assertEquals(-50, bounds.y, "y after translate should be -50");
|
||||||
|
// dimensions must be unchanged
|
||||||
|
assertEquals(80, bounds.width, "width must remain 80 after translate");
|
||||||
|
assertEquals(40, bounds.height, "height must remain 40 after translate");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// -------------------------------------------------------------------------
|
||||||
|
// ZeroDimensions
|
||||||
|
// -------------------------------------------------------------------------
|
||||||
|
|
||||||
|
@Nested
|
||||||
|
class ZeroDimensions {
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void rectangleWithZeroWidthShouldReturnZeroWidthFromFactory() {
|
||||||
|
SRectangle rect = SRectangle.create(0, 0, 0, 50);
|
||||||
|
assertEquals(0, rect.getBounds().width,
|
||||||
|
"factory should allow zero width without clamping");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void rectangleWithZeroHeightShouldReturnZeroHeightFromFactory() {
|
||||||
|
SRectangle rect = SRectangle.create(0, 0, 50, 0);
|
||||||
|
assertEquals(0, rect.getBounds().height,
|
||||||
|
"factory should allow zero height without clamping");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void circleWithZeroRadiusShouldHaveZeroBoundsDimensions() {
|
||||||
|
SCircle circle = SCircle.create(5, 10, 0);
|
||||||
|
assertEquals(0, circle.getRadius(), "radius should be 0");
|
||||||
|
assertEquals(0, circle.getBounds().width, "bounds width should be 0 (radius*2)");
|
||||||
|
assertEquals(0, circle.getBounds().height, "bounds height should be 0 (radius*2)");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// -------------------------------------------------------------------------
|
||||||
|
// ResizeClamping
|
||||||
|
// -------------------------------------------------------------------------
|
||||||
|
|
||||||
|
@Nested
|
||||||
|
class ResizeClamping {
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void rectangleResizedToNegativeShouldClampWidthToOne() {
|
||||||
|
// Start with a 10x10 rect and drag the E handle far to the left
|
||||||
|
SRectangle rect = SRectangle.create(0, 0, 10, 10);
|
||||||
|
rect.resize(ResizeHandle.E, -200, 0);
|
||||||
|
assertTrue(rect.getBounds().width >= 1,
|
||||||
|
"width must be clamped to a minimum of 1 after negative resize");
|
||||||
|
assertEquals(1, rect.getBounds().width,
|
||||||
|
"width should be exactly 1 after extreme negative resize on E handle");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void rectangleResizedToNegativeShouldClampHeightToOne() {
|
||||||
|
SRectangle rect = SRectangle.create(0, 0, 10, 10);
|
||||||
|
rect.resize(ResizeHandle.S, 0, -200);
|
||||||
|
assertTrue(rect.getBounds().height >= 1,
|
||||||
|
"height must be clamped to a minimum of 1 after negative resize");
|
||||||
|
assertEquals(1, rect.getBounds().height,
|
||||||
|
"height should be exactly 1 after extreme negative resize on S handle");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void circleResizedToNegativeShouldClampToTwo() {
|
||||||
|
SCircle circle = SCircle.create(0, 0, 50);
|
||||||
|
// Drag E handle far to the left → shrink
|
||||||
|
circle.resize(ResizeHandle.E, -500, 0);
|
||||||
|
assertTrue(circle.getBounds().width >= 2,
|
||||||
|
"circle width must be clamped to a minimum of 2");
|
||||||
|
assertTrue(circle.getBounds().height >= 2,
|
||||||
|
"circle height must be clamped to a minimum of 2");
|
||||||
|
assertEquals(2, circle.getBounds().width,
|
||||||
|
"circle width should be exactly 2 after extreme negative resize");
|
||||||
|
assertEquals(2, circle.getBounds().height,
|
||||||
|
"circle height should be exactly 2 after extreme negative resize");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// -------------------------------------------------------------------------
|
||||||
|
// NullHandling
|
||||||
|
// -------------------------------------------------------------------------
|
||||||
|
|
||||||
|
@Nested
|
||||||
|
class NullHandling {
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void textCreatedWithNullShouldReturnPlaceholder() {
|
||||||
|
SText text = SText.create(0, 0, null);
|
||||||
|
assertEquals(SText.PLACEHOLDER_TEXT, text.getText(),
|
||||||
|
"null input should be normalized to the placeholder text");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void textCreatedWithBlankStringShouldReturnPlaceholder() {
|
||||||
|
SText text = SText.create(0, 0, " ");
|
||||||
|
assertEquals(SText.PLACEHOLDER_TEXT, text.getText(),
|
||||||
|
"blank string input should be normalized to the placeholder text");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void getAttributesWithUnknownKeyShouldReturnNull() {
|
||||||
|
SRectangle rect = SRectangle.create(0, 0, 50, 50);
|
||||||
|
assertNull(rect.getAttributes("NONEXISTENT"),
|
||||||
|
"getAttributes() with an unknown key must return null");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void emptyCollectionCreationShouldNotThrow() {
|
||||||
|
assertDoesNotThrow(() -> SCollection.of(),
|
||||||
|
"SCollection.of() with no arguments must not throw");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void emptyCollectionGetBoundsShouldReturnWindowSize() {
|
||||||
|
SCollection collection = SCollection.of();
|
||||||
|
Rectangle bounds = collection.getBounds();
|
||||||
|
assertNotNull(bounds, "getBounds() on empty collection must not return null");
|
||||||
|
assertEquals(App.WIN_SIZE.width, bounds.width,
|
||||||
|
"empty collection bounds width should equal WIN_SIZE.width");
|
||||||
|
assertEquals(App.WIN_SIZE.height, bounds.height,
|
||||||
|
"empty collection bounds height should equal WIN_SIZE.height");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// -------------------------------------------------------------------------
|
||||||
|
// LargeValues
|
||||||
|
// -------------------------------------------------------------------------
|
||||||
|
|
||||||
|
@Nested
|
||||||
|
class LargeValues {
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void rectangleAtMaxIntHalfCoordsShouldNotThrow() {
|
||||||
|
int halfMax = Integer.MAX_VALUE / 2;
|
||||||
|
assertDoesNotThrow(() -> SRectangle.create(halfMax, halfMax, 100, 100),
|
||||||
|
"SRectangle.create() with very large coordinates must not throw");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void rectangleAtMaxIntHalfCoordsPreservesBounds() {
|
||||||
|
int halfMax = Integer.MAX_VALUE / 2;
|
||||||
|
SRectangle rect = SRectangle.create(halfMax, halfMax, 100, 100);
|
||||||
|
assertEquals(halfMax, rect.getBounds().x, "x should be Integer.MAX_VALUE/2");
|
||||||
|
assertEquals(halfMax, rect.getBounds().y, "y should be Integer.MAX_VALUE/2");
|
||||||
|
assertEquals(100, rect.getBounds().width, "width should be 100");
|
||||||
|
assertEquals(100, rect.getBounds().height, "height should be 100");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void translateWithLargeValuesShouldNotThrow() {
|
||||||
|
SRectangle rect = SRectangle.create(0, 0, 50, 50);
|
||||||
|
// Integer overflow is a known platform behaviour; we only assert no exception
|
||||||
|
assertDoesNotThrow(() -> rect.translate(Integer.MAX_VALUE, Integer.MAX_VALUE),
|
||||||
|
"translate() with Integer.MAX_VALUE must not throw (overflow is acceptable)");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void translateWithLargeNegativeValuesShouldNotThrow() {
|
||||||
|
SRectangle rect = SRectangle.create(0, 0, 50, 50);
|
||||||
|
assertDoesNotThrow(() -> rect.translate(Integer.MIN_VALUE, Integer.MIN_VALUE),
|
||||||
|
"translate() with Integer.MIN_VALUE must not throw (overflow is acceptable)");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -44,4 +44,40 @@ class STextTest {
|
|||||||
SText text = SText.create(0, 0, null);
|
SText text = SText.create(0, 0, null);
|
||||||
assertEquals(SText.PLACEHOLDER_TEXT, text.getText());
|
assertEquals(SText.PLACEHOLDER_TEXT, text.getText());
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void testUpdateMeasuredBoundsActuallyUpdatesBounds() {
|
||||||
|
SText text = SText.create(10, 20, "Hello");
|
||||||
|
text.updateMeasuredBounds(200, 30);
|
||||||
|
Rectangle bounds = text.getBounds();
|
||||||
|
assertEquals(200, bounds.width, "updateMeasuredBounds must update width");
|
||||||
|
assertEquals(30, bounds.height, "updateMeasuredBounds must update height");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void testUpdateMeasuredBoundsDoesNotChangePosition() {
|
||||||
|
SText text = SText.create(10, 20, "Hello");
|
||||||
|
text.updateMeasuredBounds(200, 30);
|
||||||
|
Rectangle bounds = text.getBounds();
|
||||||
|
assertEquals(10, bounds.x, "updateMeasuredBounds must not change x");
|
||||||
|
assertEquals(20, bounds.y, "updateMeasuredBounds must not change y");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void testUpdateMeasuredBoundsNegativeClampedToZero() {
|
||||||
|
SText text = SText.create(0, 0, "Hello");
|
||||||
|
text.updateMeasuredBounds(-5, -10);
|
||||||
|
Rectangle bounds = text.getBounds();
|
||||||
|
assertEquals(0, bounds.width, "negative width must be clamped to 0");
|
||||||
|
assertEquals(0, bounds.height, "negative height must be clamped to 0");
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void testUpdateMeasuredBoundsZeroIsAllowed() {
|
||||||
|
SText text = SText.create(0, 0, "Hello");
|
||||||
|
text.updateMeasuredBounds(0, 0);
|
||||||
|
Rectangle bounds = text.getBounds();
|
||||||
|
assertEquals(0, bounds.width);
|
||||||
|
assertEquals(0, bounds.height);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,128 +0,0 @@
|
|||||||
package ovh.gasser.newshapes.ui;
|
|
||||||
|
|
||||||
import org.junit.jupiter.api.Test;
|
|
||||||
import ovh.gasser.newshapes.attributes.SelectionAttributes;
|
|
||||||
import ovh.gasser.newshapes.shapes.SCollection;
|
|
||||||
import ovh.gasser.newshapes.shapes.SRectangle;
|
|
||||||
import ovh.gasser.newshapes.shapes.Shape;
|
|
||||||
|
|
||||||
import javax.swing.*;
|
|
||||||
import java.awt.*;
|
|
||||||
import java.awt.event.InputEvent;
|
|
||||||
import java.awt.event.MouseEvent;
|
|
||||||
import java.awt.image.BufferedImage;
|
|
||||||
import java.lang.reflect.InvocationTargetException;
|
|
||||||
|
|
||||||
import static org.junit.jupiter.api.Assertions.assertFalse;
|
|
||||||
import static org.junit.jupiter.api.Assertions.assertTrue;
|
|
||||||
|
|
||||||
class BoxSelectionTest {
|
|
||||||
|
|
||||||
@Test
|
|
||||||
void draggingSelectionBoxSelectsAllIntersectingShapes() throws Exception {
|
|
||||||
SRectangle first = SRectangle.create(20, 20, 30, 30);
|
|
||||||
SRectangle second = SRectangle.create(80, 80, 30, 30);
|
|
||||||
SRectangle outside = SRectangle.create(160, 160, 30, 30);
|
|
||||||
ShapesView view = createView(first, second, outside);
|
|
||||||
|
|
||||||
dragSelection(view, new Point(5, 5), new Point(100, 100), 0);
|
|
||||||
|
|
||||||
assertTrue(isSelected(first));
|
|
||||||
assertTrue(isSelected(second));
|
|
||||||
assertFalse(isSelected(outside));
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test
|
|
||||||
void shiftDraggingSelectionBoxAddsToExistingSelection() throws Exception {
|
|
||||||
SRectangle first = SRectangle.create(10, 10, 30, 30);
|
|
||||||
SRectangle second = SRectangle.create(80, 10, 30, 30);
|
|
||||||
SRectangle outside = SRectangle.create(160, 10, 30, 30);
|
|
||||||
ShapesView view = createView(first, second, outside);
|
|
||||||
|
|
||||||
click(view, new Point(20, 20), 0);
|
|
||||||
dragSelection(view, new Point(70, 5), new Point(120, 50), InputEvent.SHIFT_DOWN_MASK);
|
|
||||||
|
|
||||||
assertTrue(isSelected(first));
|
|
||||||
assertTrue(isSelected(second));
|
|
||||||
assertFalse(isSelected(outside));
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test
|
|
||||||
void shapesViewPaintsSelectionBoxDuringRendering() throws Exception {
|
|
||||||
ShapesView view = createView();
|
|
||||||
|
|
||||||
BufferedImage withoutSelectionBox = paintView(view, null);
|
|
||||||
BufferedImage withSelectionBox = paintView(view, new Rectangle(10, 10, 40, 40));
|
|
||||||
|
|
||||||
assertTrue(imagesDiffer(withoutSelectionBox, withSelectionBox));
|
|
||||||
}
|
|
||||||
|
|
||||||
private ShapesView createView(Shape... shapes) throws InvocationTargetException, InterruptedException {
|
|
||||||
final ShapesView[] ref = new ShapesView[1];
|
|
||||||
SwingUtilities.invokeAndWait(() -> {
|
|
||||||
ref[0] = new ShapesView(SCollection.of(shapes));
|
|
||||||
ref[0].setOpaque(true);
|
|
||||||
ref[0].setBackground(Color.WHITE);
|
|
||||||
ref[0].setSize(240, 240);
|
|
||||||
});
|
|
||||||
return ref[0];
|
|
||||||
}
|
|
||||||
|
|
||||||
private void click(ShapesView view, Point point, int modifiers) throws InvocationTargetException, InterruptedException {
|
|
||||||
dispatch(view, MouseEvent.MOUSE_PRESSED, point, modifiers);
|
|
||||||
dispatch(view, MouseEvent.MOUSE_RELEASED, point, modifiers);
|
|
||||||
}
|
|
||||||
|
|
||||||
private void dragSelection(ShapesView view, Point start, Point end, int modifiers) throws InvocationTargetException, InterruptedException {
|
|
||||||
dispatch(view, MouseEvent.MOUSE_PRESSED, start, modifiers);
|
|
||||||
dispatch(view, MouseEvent.MOUSE_DRAGGED, end, modifiers);
|
|
||||||
dispatch(view, MouseEvent.MOUSE_RELEASED, end, modifiers);
|
|
||||||
}
|
|
||||||
|
|
||||||
private void dispatch(ShapesView view, int eventId, Point point, int modifiers)
|
|
||||||
throws InvocationTargetException, InterruptedException {
|
|
||||||
SwingUtilities.invokeAndWait(() -> view.dispatchEvent(new MouseEvent(
|
|
||||||
view,
|
|
||||||
eventId,
|
|
||||||
System.currentTimeMillis(),
|
|
||||||
modifiers,
|
|
||||||
point.x,
|
|
||||||
point.y,
|
|
||||||
1,
|
|
||||||
false,
|
|
||||||
MouseEvent.BUTTON1
|
|
||||||
)));
|
|
||||||
}
|
|
||||||
|
|
||||||
private BufferedImage paintView(ShapesView view, Rectangle box)
|
|
||||||
throws InvocationTargetException, InterruptedException {
|
|
||||||
final BufferedImage[] ref = new BufferedImage[1];
|
|
||||||
SwingUtilities.invokeAndWait(() -> {
|
|
||||||
view.setCurrentSelectionBox(box);
|
|
||||||
BufferedImage image = new BufferedImage(240, 240, BufferedImage.TYPE_INT_ARGB);
|
|
||||||
Graphics2D graphics = image.createGraphics();
|
|
||||||
try {
|
|
||||||
view.paint(graphics);
|
|
||||||
} finally {
|
|
||||||
graphics.dispose();
|
|
||||||
}
|
|
||||||
ref[0] = image;
|
|
||||||
});
|
|
||||||
return ref[0];
|
|
||||||
}
|
|
||||||
|
|
||||||
private boolean imagesDiffer(BufferedImage first, BufferedImage second) {
|
|
||||||
for (int y = 0; y < first.getHeight(); y++) {
|
|
||||||
for (int x = 0; x < first.getWidth(); x++) {
|
|
||||||
if (first.getRGB(x, y) != second.getRGB(x, y)) {
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
private boolean isSelected(Shape shape) {
|
|
||||||
return ((SelectionAttributes) shape.getAttributes(SelectionAttributes.ID)).selected;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
Reference in New Issue
Block a user